diff options
| author | Simon Josefsson <simon@josefsson.org> | 2008-04-17 11:41:17 +0200 |
|---|---|---|
| committer | Simon Josefsson <simon@josefsson.org> | 2008-04-17 11:41:17 +0200 |
| commit | 595b45ed9162701d8b62e301afaebbee56cbb138 (patch) | |
| tree | 5de9632f97fb788696586b05edffd9947b3182db /lib/gnutls_handshake.c | |
| parent | 37f27eeb6694288d1985eb89c3fa1f4d0fc6c3e6 (diff) | |
| download | gnutls-595b45ed9162701d8b62e301afaebbee56cbb138.tar.gz | |
Remove all uses of gnutls_alloca/gnutls_afree.
Use normal gnutls_malloc instead. One reason is increased portability
to Windows, the other is that several of the uses may be unsafe
because the size of data allocated could be large. Reported by
Massimo Gaspari <massimo.gaspari@alice.it> in
<http://permalink.gmane.org/gmane.network.gnutls.general/1170>.
Diffstat (limited to 'lib/gnutls_handshake.c')
| -rw-r--r-- | lib/gnutls_handshake.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/lib/gnutls_handshake.c b/lib/gnutls_handshake.c index 100900d413..98aa86cb8f 100644 --- a/lib/gnutls_handshake.c +++ b/lib/gnutls_handshake.c @@ -933,7 +933,7 @@ _gnutls_send_handshake (gnutls_session_t session, void *i_data, /* first run */ datasize = i_datasize + HANDSHAKE_HEADER_SIZE; - data = gnutls_alloca (datasize); + data = gnutls_malloc (datasize); if (data == NULL) { gnutls_assert (); @@ -958,7 +958,7 @@ _gnutls_send_handshake (gnutls_session_t session, void *i_data, _gnutls_handshake_hash_add_sent (session, type, data, datasize)) < 0) { gnutls_assert (); - gnutls_afree (data); + gnutls_free (data); return ret; } @@ -968,7 +968,7 @@ _gnutls_send_handshake (gnutls_session_t session, void *i_data, _gnutls_handshake_io_send_int (session, GNUTLS_HANDSHAKE, type, data, datasize); - gnutls_afree (data); + gnutls_free (data); return ret; } @@ -1918,7 +1918,7 @@ _gnutls_send_server_hello (gnutls_session_t session, int again) return extdatalen; } - data = gnutls_alloca (datalen + extdatalen); + data = gnutls_malloc (datalen + extdatalen); if (data == NULL) { gnutls_assert (); @@ -1966,7 +1966,7 @@ _gnutls_send_server_hello (gnutls_session_t session, int again) ret = _gnutls_send_handshake (session, data, datalen, GNUTLS_HANDSHAKE_SERVER_HELLO); - gnutls_afree (data); + gnutls_free (data); return ret; } |