From 844cb3ec57354d21090987172f92ffd69818fc75 Mon Sep 17 00:00:00 2001 From: Daiki Ueno Date: Sun, 25 Apr 2021 06:50:03 +0200 Subject: .gitignore: ignore ctags, etags, and GNU global files Signed-off-by: Daiki Ueno --- .gitignore | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.gitignore b/.gitignore index 4bf0da343c..91be9f9a4b 100644 --- a/.gitignore +++ b/.gitignore @@ -3,6 +3,13 @@ /ABOUT-NLS AUTHORS ABOUT-NLS +# GNU global +GPATH +GSYMS +GRTAGS +GTAGS +# ctags, etags +TAGS aclocal.m4 aminclude_static.am autom4te.cache/ -- cgit v1.2.1 From 4599009cf9e0ffe9417b85a8d65319a017003d2e Mon Sep 17 00:00:00 2001 From: Daiki Ueno Date: Sun, 25 Apr 2021 06:51:20 +0200 Subject: tests: fix test script file name in distribution Signed-off-by: Daiki Ueno --- tests/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index ed32dadcc5..3ae5459745 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -475,7 +475,7 @@ pkcs11_tls_neg_pkcs11_no_key_LDADD = $(LDADD) $(LIBDL) endif endif -dist_check_SCRIPTS = rfc2253-escape-test rsa-md5-collision/rsa-md5-collision.sh systemkey.sh tls13/prf-early.sh +dist_check_SCRIPTS = rfc2253-escape-test.sh rsa-md5-collision/rsa-md5-collision.sh systemkey.sh tls13/prf-early.sh if !WINDOWS -- cgit v1.2.1 From c488a91ae4ec8e14d81d15a9dc129a7c8c212e54 Mon Sep 17 00:00:00 2001 From: Daiki Ueno Date: Sun, 25 Apr 2021 10:48:09 +0200 Subject: build: do not install .hmac files It turned out that distro package building process might perform post-processing (e.g., strip) of the shared libraries after install, and that may cause inconsistency with the installed .hmac files. Let's not try too hard on this but defer the final hmac calculation to distributions. It is still useful to keep our own fipshmac as it makes it easier to run FIPS tests. Signed-off-by: Daiki Ueno --- lib/Makefile.am | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/lib/Makefile.am b/lib/Makefile.am index 6eb175bf6f..f213be19a9 100644 --- a/lib/Makefile.am +++ b/lib/Makefile.am @@ -196,17 +196,6 @@ all-local: $(hmac_files) $(AM_V_GEN) $(builddir)/fipshmac .libs/$(gnutls_so) > $@-t && mv $@-t $@ CLEANFILES = $(hmac_files) - -install-exec-hook: $(hmac_files) - for file in $(hmac_files); do \ - $(INSTALL_DATA) $$file $(DESTDIR)$(libdir); \ - done - -uninstall-hook: - for file in $(hmac_files); do \ - basename=$$(expr $$file : '.*/\(.*\)'); \ - $(DESTDIR)$(libdir)/$$basename; \ - done endif if ENABLE_TROUSERS -- cgit v1.2.1 From 1934a16150043ffbc96a6b57722a95ab0d45631b Mon Sep 17 00:00:00 2001 From: Daiki Ueno Date: Sun, 25 Apr 2021 17:04:46 +0200 Subject: gnutls_x509_crt_get_dn: clarify null-termination of the output Signed-off-by: Daiki Ueno --- lib/x509/x509.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/x509/x509.c b/lib/x509/x509.c index 4e494d10e0..b56f6195b2 100644 --- a/lib/x509/x509.c +++ b/lib/x509/x509.c @@ -861,7 +861,8 @@ gnutls_x509_crt_get_issuer_dn_oid(gnutls_x509_crt_t cert, * described in RFC4514. The output string will be ASCII or UTF-8 * encoded, depending on the certificate data. * - * If @buf is null then only the size will be filled. + * The @buf returned will be null terminated and the @buf_size will account + * for the trailing null. If @buf is null then only the size will be filled. * * This function does not output a fully RFC4514 compliant string, if * that is required see gnutls_x509_crt_get_dn3(). -- cgit v1.2.1