delta/go-git.git/src/os/exec/exec.go, branch dev.inline

os/exec: add closeOnce.WriteString method

2016-11-16T02:24:30+00:00

Add an explicit WriteString method to closeOnce that acquires the
writers lock.  This overrides the one promoted from the
embedded *os.File field.  The promoted one naturally does not acquire
the lock, and can therefore race with the Close method.

Fixes #17647.

Change-Id: I3460f2a0d503449481cfb2fd4628b4855ab0ecdf
Reviewed-on: https://go-review.googlesource.com/33298
Run-TryBot: Ian Lance Taylor 
TryBot-Result: Gobot Gobot 
Reviewed-by: Brad Fitzpatrick

os/exec: document how Command fills in Cmd.Args

2016-10-28T19:18:29+00:00

Fixes #17536

Change-Id: Ica8c3d696848822ac65b7931455b1fd94809bfe8
Reviewed-on: https://go-review.googlesource.com/31710
Reviewed-by: Russ Cox

os/exec: allow simultaneous cmd.Wait and Write of cmd.StdinPipe

2016-10-18T12:48:03+00:00

cmd.StdinPipe returns an io.WriteCloser.
It's reasonable to expect the caller not to call Write and Close simultaneously,
but there is an implicit Close in cmd.Wait that's not obvious.
We already synchronize the implicit Close in cmd.Wait against
any explicit Close from the caller. Also synchronize that implicit
Close against any explicit Write from the caller.

Fixes #9307.

Change-Id: I8561e9369d6e5ac88dfbca1175549f6dfa04b8ac
Reviewed-on: https://go-review.googlesource.com/31148
Reviewed-by: Brad Fitzpatrick 
Reviewed-by: Ian Lance Taylor

os/exec: start checking for context cancelation in Start

2016-06-30T16:35:56+00:00

Previously we started checking for context cancelation in Wait, but
that meant that when using StdoutPipe context cancelation never took
effect.

Fixes #16222.

Change-Id: I89cd26d3499a6080bf1a07718ce38d825561899e
Reviewed-on: https://go-review.googlesource.com/24650
Reviewed-by: Brad Fitzpatrick 
Run-TryBot: Ian Lance Taylor 
TryBot-Result: Gobot Gobot

os/exec: remove Cmd.RunContext and Cmd.WaitContext, add CommandContext

2016-05-20T21:19:32+00:00

Fixes #15775

Change-Id: I0a6c2ca09d3850c3538494711f7a9801b9500411
Reviewed-on: https://go-review.googlesource.com/23300
Run-TryBot: Brad Fitzpatrick 
Reviewed-by: Brad Fitzpatrick

os/exec: fix variable shadow, don't leak goroutine

2016-04-28T20:56:25+00:00

Goroutine leak checking is still too tedious, so untested.

See #6705 which is my fault for forgetting to mail out.

Change-Id: I899fb311c9d4229ff1dbd3f54fe307805e17efee
Reviewed-on: https://go-review.googlesource.com/22581
Reviewed-by: Ahmed W. 
Run-TryBot: Brad Fitzpatrick 
Reviewed-by: Brad Fitzpatrick

os/exec: add Cmd.RunContext and Cmd.WaitContext

2016-04-28T19:06:41+00:00

Updates #14660

Change-Id: Ifa5c97ba327ad7ceea0a9a252e3dbd9d079dae54
Reviewed-on: https://go-review.googlesource.com/22529
Reviewed-by: Ian Lance Taylor 
Run-TryBot: Brad Fitzpatrick 
TryBot-Result: Gobot Gobot

os/exec: document that examples assume Unix

2016-01-06T17:58:48+00:00

Fixes #13693.

Change-Id: Ieb89d8a8874ee8c6b304de99dceb07193c26b60e
Reviewed-on: https://go-review.googlesource.com/18315
Reviewed-by: Brad Fitzpatrick

os/exec: make Cmd.Output include stderr in ExitError

2015-10-22T14:08:10+00:00

Change-Id: I3c6649d2f2521ab0843b13308569867d2e5f02da
Reviewed-on: https://go-review.googlesource.com/11415
Reviewed-by: Ian Lance Taylor 
Run-TryBot: Brad Fitzpatrick 
Reviewed-by: Andrew Gerrand 
TryBot-Result: Gobot Gobot

os/exec: close read pipe if copy to io.Writer fails

2015-07-22T21:37:18+00:00

Fixes #10400.

Change-Id: Ic486cb8af4c40660fd1a2e3d10986975acba3f19
Reviewed-on: https://go-review.googlesource.com/12537
Reviewed-by: Ian Lance Taylor