diff options
| author | Rob Pike <r@golang.org> | 2010-12-20 13:36:47 -0800 |
|---|---|---|
| committer | Rob Pike <r@golang.org> | 2010-12-20 13:36:47 -0800 |
| commit | 363d28aba1035bfd8b57d25abf16b9ce2443f9d8 (patch) | |
| tree | 21cd20980cabe98a4414cf361d6d46e795da8d02 | |
| parent | 3e17ebee9fbb749615b4065cbf503231aed783f2 (diff) | |
| download | go-363d28aba1035bfd8b57d25abf16b9ce2443f9d8.tar.gz | |
template: fix trivial bug: integers are not "empty"
Fixes issue 1357.
R=adg, gri
CC=golang-dev
http://codereview.appspot.com/3809041
| -rw-r--r-- | src/pkg/template/template.go | 2 | ||||
| -rw-r--r-- | src/pkg/template/template_test.go | 6 |
2 files changed, 7 insertions, 1 deletions
diff --git a/src/pkg/template/template.go b/src/pkg/template/template.go index be5c59aed..aa0507761 100644 --- a/src/pkg/template/template.go +++ b/src/pkg/template/template.go @@ -673,7 +673,7 @@ func empty(v reflect.Value) bool { case *reflect.SliceValue: return v.Len() == 0 } - return true + return false } // Look up a variable or method, up through the parent if necessary. diff --git a/src/pkg/template/template_test.go b/src/pkg/template/template_test.go index 1c491e34a..4075444a8 100644 --- a/src/pkg/template/template_test.go +++ b/src/pkg/template/template_test.go @@ -197,6 +197,12 @@ var tests = []*Test{ out: " Header\n", }, + &Test{ + in: "{.section integer}{@}{.end}", + + out: "77", + }, + // Repeated &Test{ in: "{.section pdata }\n" + |