diff options
Diffstat (limited to 'src/encoding')
| -rw-r--r-- | src/encoding/gob/encode.go | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/src/encoding/gob/encode.go b/src/encoding/gob/encode.go index b7bf8b002..04a85410c 100644 --- a/src/encoding/gob/encode.go +++ b/src/encoding/gob/encode.go @@ -281,15 +281,16 @@ func (enc *Encoder) encodeStruct(b *bytes.Buffer, engine *encEngine, value refle field := value.FieldByIndex(instr.index) if instr.indir > 0 { field = encIndirect(field, instr.indir) - } - if !valid(field) { - continue + // TODO: Is field guaranteed valid? If so we could avoid this check. + if !valid(field) { + continue + } } instr.op(instr, state, field) } } -// encodeArray encodes the array whose 0th element is at p. +// encodeArray encodes an array. func (enc *Encoder) encodeArray(b *bytes.Buffer, value reflect.Value, op encOp, elemIndir int, length int) { state := enc.newEncoderState(b) defer enc.freeEncoderState(state) @@ -300,6 +301,7 @@ func (enc *Encoder) encodeArray(b *bytes.Buffer, value reflect.Value, op encOp, elem := value.Index(i) if elemIndir > 0 { elem = encIndirect(elem, elemIndir) + // TODO: Is elem guaranteed valid? If so we could avoid this check. if !valid(elem) { errorf("encodeArray: nil element") } |