| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Fixes issue 2443.
R=ken2
CC=golang-dev
https://codereview.appspot.com/6997048
|
|
|
|
|
|
| |
R=rsc
CC=golang-dev
http://codereview.appspot.com/6128051
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Not a complete fix for issue 3342, but fixes the trivial case.
There may still be a race in the instants before and after
a scavenger-induced garbage collection.
Intended to be "obviously safe": a call to runtime?gosched
before main.main is no different than a call to runtime.Gosched
at the beginning of main.main, and it is (or had better be)
safe to call runtime.Gosched at any point during main.
Update issue 3342.
R=iant
CC=golang-dev
http://codereview.appspot.com/5919052
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Breaks closure test when GOMAXPROCS=2 or more.
??? original CL description
runtime: restore deadlock detection in the simplest case.
Fixes issue 3342.
R=iant, r, dave, rsc
CC=golang-dev, remy
http://codereview.appspot.com/5844051
Committer: Russ Cox <rsc@golang.org>
???
R=rsc
CC=golang-dev
http://codereview.appspot.com/5924045
|
|
|
|
|
|
|
|
|
|
| |
Fixes issue 3342.
R=iant, r, dave, rsc
CC=golang-dev, remy
http://codereview.appspot.com/5844051
Committer: Russ Cox <rsc@golang.org>
|
|
|
|
|
|
| |
R=golang-dev, gri, iant
CC=golang-dev
http://codereview.appspot.com/5882046
|
|
|
|
|
|
| |
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5695083
|
|
|
|
|
|
|
|
|
| |
Should be obviously correct. Includes minimal test case.
A future CL should clear up the logic around typecheckok and importpkg != nil someday.
R=rsc, dsymonds, rsc
CC=golang-dev
http://codereview.appspot.com/5652057
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Preserve test.
changeset: 11593:f1deaf35e1d1
user: Luuk van Dijk <lvd@golang.org>
date: Tue Jan 17 10:00:57 2012 +0100
summary: gc: fix infinite recursion for embedded interfaces
This is causing 'interface type loop' errors during compilation
of a complex program. I don't understand what's happening
well enough to boil it down to a simple test case, but undoing
this change fixes the problem.
The change being undone is fixing a corner case (uses of
pointer to interface in an interface definition) that basically
only comes up in erroneous Go programs. Let's not try to
fix this again until after Go 1.
Unfixes issue 1909.
TBR=lvd
CC=golang-dev
http://codereview.appspot.com/5555063
|
|
|
|
|
|
|
|
| |
This will permit gccgo to check test output.
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5554056
|
|
|
|
|
|
|
|
|
|
|
| |
This will make these tests more meaningful for gccgo, which
runs tests in parallel and has no equivalent to golden.out.
Remove ken/simpprint.go since it duplicates helloworld.go.
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5536058
|
|
|
|
|
|
|
|
|
| |
Now that Luuk's qualified exporting code
is in, fixing this bug is trivial.
R=ken2
CC=golang-dev
http://codereview.appspot.com/5479048
|
|
|
|
|
|
|
|
| |
Add copyright notice to nilptr.go.
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5139048
|
|
|
|
|
|
|
|
|
|
| |
The 512 MB array causes load delays on some systems.
Now that we have recover, we can do all the tests in
one binary, so that the delay is incurred just once.
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5142044
|
|
|
|
|
|
|
|
|
|
|
| |
The spec says that all methods are inherited from an anonymous
field. There is no exception for non-exported methods.
This is related to issue 1536.
R=rsc
CC=golang-dev
http://codereview.appspot.com/5012043
|
|
|
|
|
|
|
|
|
| |
Fixes issue 2241
while not breaking issue 1878 again.
R=rsc
CC=golang-dev
http://codereview.appspot.com/4988048
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Does as much as possible in data layout instead
of during the init function.
Handles var x = y; var y = z as a special case too,
because it is so prevalent in package unicode
(var Greek = _Greek; var _Greek = []...).
Introduces InitPlan description of initialized data
so that it can be traversed multiple times (for example,
in the copy handler).
Cuts package unicode's init function size by 8x.
All that remains there is map initialization, which
is on the chopping block too.
Fixes sinit.go test case.
Aggregate DATA instructions at end of object file.
Checkpoint. More to come.
R=ken2
CC=golang-dev
http://codereview.appspot.com/4969051
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make the stack traces more readable for new
Go programmers while preserving their utility for old hands.
- Change status number [4] to string.
- Elide frames in runtime package (internal details).
- Swap file:line and arguments.
- Drop 'created by' for main goroutine.
- Show goroutines in order of allocation:
implies main goroutine first if nothing else.
There is no option to get the extra frames back.
Uncomment 'return 1' at the bottom of symtab.c.
$ 6.out
throw: all goroutines are asleep - deadlock!
goroutine 1 [chan send]:
main.main()
/Users/rsc/g/go/src/pkg/runtime/x.go:22 +0x8a
goroutine 2 [select (no cases)]:
main.sel()
/Users/rsc/g/go/src/pkg/runtime/x.go:11 +0x18
created by main.main
/Users/rsc/g/go/src/pkg/runtime/x.go:19 +0x23
goroutine 3 [chan receive]:
main.recv(0xf8400010a0, 0x0)
/Users/rsc/g/go/src/pkg/runtime/x.go:15 +0x2e
created by main.main
/Users/rsc/g/go/src/pkg/runtime/x.go:20 +0x50
goroutine 4 [chan receive (nil chan)]:
main.recv(0x0, 0x0)
/Users/rsc/g/go/src/pkg/runtime/x.go:15 +0x2e
created by main.main
/Users/rsc/g/go/src/pkg/runtime/x.go:21 +0x66
$
$ 6.out index
panic: runtime error: index out of range
goroutine 1 [running]:
main.main()
/Users/rsc/g/go/src/pkg/runtime/x.go:25 +0xb9
$
$ 6.out nil
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0x22ca]
goroutine 1 [running]:
main.main()
/Users/rsc/g/go/src/pkg/runtime/x.go:28 +0x211
$
$ 6.out panic
panic: panic
goroutine 1 [running]:
main.main()
/Users/rsc/g/go/src/pkg/runtime/x.go:30 +0x101
$
R=golang-dev, qyzhai, n13m3y3r, r
CC=golang-dev
http://codereview.appspot.com/4907048
|
|
|
|
|
|
|
|
| |
Fixes issue 1952.
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/4611041
|
|
|
|
|
|
|
|
| |
The change is that 1.0<<2 is now okay.
R=ken2
CC=golang-dev
http://codereview.appspot.com/4524084
|
|
|
|
|
|
| |
R=rsc
CC=golang-dev
http://codereview.appspot.com/4548058
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The spec was adjusted in commit df410d6a4842 to allow the
implicit assignment of strutures with unexported fields in
method receivers. This change updates the compiler.
Also moved bug322 into fixedbugs and updated golden.out
to reflect the removal of the last known bug.
Fixes issue 1402.
R=golang-dev, gri, rsc
CC=golang-dev
http://codereview.appspot.com/4526069
Committer: Russ Cox <rsc@golang.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
go/types: update for export data format change
reflect: require package qualifiers to match during interface check
runtime: require package qualifiers to match during interface check
test: fixed bug324, adapt to be silent
Fixes issue 1550.
Issue 1536 remains open.
R=gri, ken2, r
CC=golang-dev
http://codereview.appspot.com/4442071
|
|
|
|
|
|
|
|
| |
Got lost when I introduced TUNSAFEPTR.
R=ken2
CC=golang-dev
http://codereview.appspot.com/4442046
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Failing at compile time requires that for each conversion
between two interface types the compiler compare the sets of
unexported methods to see if they come from different
packages. Since this test will fail approximately never on
real code, and since it can't catch all cases of the problem,
I don't think it's worth testing in the compiler. This CL
changes this test to look for a run-time panic rather than a
compile-time error.
R=gri, rsc1, iant2, rsc
CC=golang-dev
http://codereview.appspot.com/4332041
|
|
|
|
|
|
| |
R=gri, rsc1
CC=golang-dev
http://codereview.appspot.com/4328041
|
|
|
|
|
|
|
|
|
| |
Also: renamed fixedbugs/bug322.go to fixedbugs/bug323.go
because we already have a bugs/bug322.go and bug322.dir.
R=rsc
CC=golang-dev
http://codereview.appspot.com/4219044
|
|
|
|
|
|
|
|
| |
R=rsc
CC=golang-dev
http://codereview.appspot.com/4079063
Committer: Robert Griesemer <gri@golang.org>
|
|
|
|
|
|
| |
R=golang-dev, nigeltao, niemeyer, r
CC=golang-dev
http://codereview.appspot.com/4079053
|
|
|
|
|
|
|
|
|
|
|
| |
also:
cmplx -> complex
float64(1.0) -> 1.0
float64(1) -> 1.0
R=gri, r, gri1, r2
CC=golang-dev
http://codereview.appspot.com/3991043
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
$ 6.out
panic: runtime error: invalid memory address or nil pointer dereference
[signal 11 code=0x1 addr=0x0 pc=0x1c16]
runtime.panic+0xa7 /Users/rsc/g/go/src/pkg/runtime/proc.c:1089
runtime.panic(0xf6c8, 0x25c010)
runtime.panicstring+0x69 /Users/rsc/g/go/src/pkg/runtime/runtime.c:88
runtime.panicstring(0x24814, 0x0)
runtime.sigpanic+0x144 /Users/rsc/g/go/src/pkg/runtime/darwin/thread.c:465
runtime.sigpanic()
main.f+0x16 /Users/rsc/x.go:5
main.f()
main.main+0x1c /Users/rsc/x.go:9
main.main()
runtime.mainstart+0xf /Users/rsc/g/go/src/pkg/runtime/amd64/asm.s:77
runtime.mainstart()
runtime.goexit /Users/rsc/g/go/src/pkg/runtime/proc.c:149
runtime.goexit()
R=r
CC=golang-dev
http://codereview.appspot.com/4036042
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cc: same
runtime: test cc alignment (required moving #define of offsetof to runtime.h)
fix bug260
Fixes issue 482.
Fixes issue 609.
R=ken2, r
CC=golang-dev
http://codereview.appspot.com/3563042
|
|
|
|
|
|
| |
R=iant
CC=golang-dev, ken2
http://codereview.appspot.com/2182043
|
|
|
|
|
|
| |
R=rsc
CC=golang-dev
http://codereview.appspot.com/2127045
|
|
|
|
|
|
| |
R=ken2
CC=golang-dev
http://codereview.appspot.com/1731057
|
|
|
|
|
|
|
|
|
| |
( This CL is dependent on acceptance of
http://codereview.appspot.com/1913041/show )
R=go-dev
CC=golang-dev
http://codereview.appspot.com/1860045
|
|
|
|
|
|
| |
R=r
CC=golang-dev
http://codereview.appspot.com/1846051
|
|
|
|
|
|
|
|
| |
Fixes issue 915.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1856042
|
|
|
|
|
|
|
|
|
| |
Fixes issue 849.
Fixes issue 920.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1841042
|
|
|
|
|
|
| |
R=iant, ken2, r, r2, ken3
CC=golang-dev
http://codereview.appspot.com/1686044
|
|
|
|
|
|
| |
R=r
CC=golang-dev
http://codereview.appspot.com/1703041
|
|
|
|
|
|
|
|
| |
It fails with 6g. Once 6g is fixed up I will extend the value tests.
R=rsc, iant
CC=golang-dev
http://codereview.appspot.com/1677043
|
|
|
|
|
|
| |
R=r
CC=golang-dev
http://codereview.appspot.com/1644042
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Code for assignment, conversions now mirrors spec.
* Changed some snprint -> smprint.
* Renamed runtime functions to separate
interface conversions from type assertions:
convT2I, assertI2T, etc.
* Correct checking of \U sequences.
Fixes issue 840.
Fixes issue 830.
Fixes issue 778.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1303042
|
|
|
|
|
|
| |
R=gri
CC=golang-dev
http://codereview.appspot.com/1616041
|
|
|
|
|
|
| |
R=r
CC=golang-dev
http://codereview.appspot.com/1473042
|
|
|
|
|
|
| |
R=r, iant
CC=golang-dev
http://codereview.appspot.com/1433042
|
|
|
|
|
|
| |
R=rsc, r, iant
CC=golang-dev
http://codereview.appspot.com/1465041
|
|
|
|
|
|
| |
R=ken2
CC=golang-dev
http://codereview.appspot.com/1274042
|
|
|
|
|
|
|
|
|
|
| |
- accepted by gccgo, gofmt
- some not accepted by 6g
- spec revision forthcoming
R=rsc
CC=golang-dev
http://codereview.appspot.com/1279041
|