| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Fixes issue 8184.
LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://codereview.appspot.com/137510043
|
|
|
|
|
|
|
| |
LGTM=josharian, r
R=golang-codereviews, josharian, r
CC=golang-codereviews
https://codereview.appspot.com/120160043
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Following CL 68150047, the goos and goarch
variables are not currently set when the GOOS
and GOARCH environment variables are not set.
This made the content of the build tag to be
ignored in this case.
This CL sets goos and goarch to runtime.GOOS
and runtime.GOARCH when the GOOS and GOARCH
environments variables are not set.
LGTM=aram, bradfitz
R=golang-codereviews, aram, gobot, rsc, dave, bradfitz
CC=golang-codereviews, rsc
https://codereview.appspot.com/112490043
|
|
|
|
|
|
|
|
|
|
| |
This matters for NaCl, which seems to swamp my 4-core MacBook Pro otherwise.
It's not a correctness problem, just a usability problem.
LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://codereview.appspot.com/98600046
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some of the errorcheck tests have many many identical regexps.
Use a map to avoid storing the compiled form many many times
in memory. Change the filterRe to a simple string to avoid
the expense of those regexps as well.
Cuts the time for run.go on index2.go by almost 50x.
Noticed during debugging of issue 7344.
LGTM=bradfitz
R=bradfitz, josharian
CC=golang-codereviews
https://codereview.appspot.com/74380043
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See golang.org/s/go13nacl for design overview.
This CL is the mostly mechanical changes from rsc's Go 1.2 based NaCl branch, specifically 39cb35750369 to 500771b477cf from https://code.google.com/r/rsc-go13nacl. This CL does not include working NaCl support, there are probably two or three more large merges to come.
CL 15750044 is not included as it involves more invasive changes to the linker which will need to be merged separately.
The exact change lists included are
15050047: syscall: support for Native Client
15360044: syscall: unzip implementation for Native Client
15370044: syscall: Native Client SRPC implementation
15400047: cmd/dist, cmd/go, go/build, test: support for Native Client
15410048: runtime: support for Native Client
15410049: syscall: file descriptor table for Native Client
15410050: syscall: in-memory file system for Native Client
15440048: all: update +build lines for Native Client port
15540045: cmd/6g, cmd/8g, cmd/gc: support for Native Client
15570045: os: support for Native Client
15680044: crypto/..., hash/crc32, reflect, sync/atomic: support for amd64p32
15690044: net: support for Native Client
15690048: runtime: support for fake time like on Go Playground
15690051: build: disable various tests on Native Client
LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/68150047
Committer: Russ Cox <rsc@golang.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update issue 6853
For an ephemeral binary - one created, run, and then deleted -
there is no need to write dwarf debug information, since the
binary will not be used with gdb. In this case, instruct the linker
not to spend time and disk space generating the debug information
by passing the -w flag to the linker.
Omitting dwarf information reduces the size of most binaries by 25%.
We may be more aggressive about this in the future.
LGTM=bradfitz, r
R=r, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/65890043
|
|
|
|
|
|
|
|
| |
R=golang-codereviews, dave, iant
CC=golang-codereviews
https://codereview.appspot.com/45750044
Committer: Ian Lance Taylor <iant@golang.org>
|
|
|
|
|
|
|
|
|
| |
Among other things, it makes it easier to scan to
see what is slow.
R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/40040044
|
|
|
|
|
|
|
|
| |
Fixes issue 5087.
R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13812043
|
|
|
|
|
|
|
|
| |
R=bradfitz, dave, rsc, r
CC=golang-dev
https://codereview.appspot.com/10001045
Committer: Russ Cox <rsc@golang.org>
|
|
|
|
|
|
|
|
|
| |
The commands being run are 'go tool this' and 'go tool that',
and the go command will call Getwd during its init.
R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/7336045
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Expressions involving nil, even if they can be evaluated
at compile time, do not count as Go constants and cannot
be used in const initializers.
Fixes issue 4673.
Fixes issue 4680.
R=ken2
CC=golang-dev
https://codereview.appspot.com/7278043
|
|
|
|
|
|
|
|
|
| |
This enables a few tests that were only executed
unconditionnally.
R=rsc, minux.ma, bradfitz
CC=golang-dev
https://codereview.appspot.com/7103051
|
|
|
|
|
|
|
|
|
|
| |
runoutput styles tests generally consume a lot of memory. On arm platforms rotate?.go consume around 200mb each to compile, and as tests are sorted alphabetically, they all tend to run at once.
This change limits the number of runoutput jobs to 2 on arm platforms.
R=minux.ma, remyoudompheng, bradfitz, lucio.dere
CC=golang-dev
https://codereview.appspot.com/7099047
|
|
|
|
|
|
|
|
| |
Update issue 4139.
R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/7094047
|
|
|
|
|
|
|
|
|
|
| |
This allows test/dwarf to be supported by run.go.
Update issue 4139.
R=golang-dev, bradfitz, iant
CC=golang-dev
https://codereview.appspot.com/7064067
|
|
|
|
|
|
|
|
| |
Multiple files with the same package all get compiled together.
R=golang-dev, iant, dave
CC=golang-dev
https://codereview.appspot.com/7005053
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The patch makes the compile user an ordinary package-local
symbol for the name of embedded fields of builtin type.
This is incompatible with the fix delivered for issue 2687
(revision 3c060add43fb) but fixes it in a different way, because
the explicit symbol on the field makes the typechecker able to
find it in lookdot.
Fixes issue 3552.
R=lvd, rsc, daniel.morsing
CC=golang-dev
https://codereview.appspot.com/6866047
|
|
|
|
|
|
| |
R=golang-dev, remyoudompheng, iant, rsc
CC=golang-dev
http://codereview.appspot.com/6833043
|
|
|
|
|
|
|
|
|
| |
Running this test via "bash run" uncovered three different
bugs (4344, 4348, 4353). We need to run it by default.
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6832043
|
|
|
|
|
|
|
|
|
|
|
| |
The other tests either need a complex procedure
or are architecture- or OS-dependent.
Update issue 4139.
R=golang-dev, daniel.morsing, iant
CC=golang-dev
http://codereview.appspot.com/6618062
|
|
|
|
|
|
|
|
|
|
| |
testlib will complain about any unmatched errors left in errorchecks while run.go will not.
Fixes issue 4141.
R=golang-dev, minux.ma, remyoudompheng, rsc
CC=golang-dev
http://codereview.appspot.com/6614060
|
|
|
|
|
|
|
|
| |
Update issue 4139.
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6609051
|
|
|
|
|
|
| |
R=golang-dev, daniel.morsing
CC=golang-dev
http://codereview.appspot.com/6624060
|
|
|
|
|
|
|
|
| |
Update issue 4139.
R=golang-dev, minux.ma
CC=golang-dev
http://codereview.appspot.com/6620070
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rundir will compile each file in the directory in lexicographic order, link the last file as the main package and run the resulting program. rundircmpout is an related command, that will compare the output of the program to an corresponding .out file
errorcheckdir will compile each file in a directory in lexicographic order, running errorcheck on each file as it compiles. All compilations are assumed to be successful except for the last file. However, If a -0 flag is present on the command, the last compilation will also be assumed successful
This CL also includes a small refactoring of run.go. It was getting unwieldy and the meaning of the run commands was hidden behind argument line formatting.
Fixes issue 4058.
R=rsc, minux.ma, remyoudompheng, iant
CC=golang-dev
http://codereview.appspot.com/6554071
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Today, if run.go doesn't understand a test header line it just ignores
the test, making it too easy to write or edit tests that are not actually
being run.
- expand errorcheck to accept flags, so that bounds.go and escape*.go can run.
- create a whitelist of skippable tests in run.go; skipping others is an error.
- mark all skipped tests at top of file.
Update issue 4139.
R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6549054
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
use a function to get stdout and stderr, instead of depending
on a specific libc implementation.
also make test/run.go replace \r\n by \n before comparing
output.
Fixes issue 2121.
Part of issue 1741.
R=alex.brainman, rsc, r, remyoudompheng
CC=golang-dev
http://codereview.appspot.com/5847068
|
|
|
|
|
|
| |
R=golang-dev, dave, minux.ma, remyoudompheng
CC=golang-dev
http://codereview.appspot.com/6460093
|
|
|
|
|
|
|
|
|
| |
Enhances test/run.go to support testing other directories
Will enable stdio tests on Windows in a follow-up CL.
R=golang-dev, alex.brainman, rsc
CC=golang-dev
http://codereview.appspot.com/6220049
|
|
|
|
|
|
| |
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6454091
|
|
|
|
|
|
|
|
|
|
|
| |
we can't import "./bug0" on windows, as it will trigger
"import path contains invalid character ':'" error.
instead, we pass "-D." and "-I." to gc to override this
behavior. this idea is due to remyoudompheng.
R=golang-dev, r, alex.brainman, remyoudompheng
CC=golang-dev
http://codereview.appspot.com/6441074
|
|
|
|
|
|
|
|
|
|
| |
The compiledir pattern compiles all files xxx.dir/*.go
in lexicographic order (which is assumed to coincide with
the topological order of dependencies).
R=rsc
CC=golang-dev, remy
http://codereview.appspot.com/6440048
|
|
|
|
|
|
|
|
| |
Introduced "runoutput" cmd for running generated program
R=golang-dev, iant, bradfitz, remyoudompheng
CC=golang-dev
http://codereview.appspot.com/5869049
|
|
|
|
|
|
|
|
| |
Introduce a new skip cmd.
R=golang-dev, bradfitz, iant, iant
CC=golang-dev
http://codereview.appspot.com/5868048
|
|
|
|
|
|
|
|
| |
Xcode generates ._foo.go files.
R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5786055
|
|
|
|
|
|
|
|
| |
Let the outer environment filter down to the commands being run.
TBR=r
CC=golang-dev
http://codereview.appspot.com/5758066
|
|
|
|
|
|
|
|
| |
Lets us run multifile tests and tests with arguments.
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5753068
|
|
|
|
|
|
| |
R=rsc
CC=golang-dev
http://codereview.appspot.com/5753054
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, tweak run.go to use no more than 2x the
number of CPUs, and only one on ARM.
53.85u 13.33s 53.69r ./run
50.68u 12.13s 18.85r go run run.go
Fixes issue 2833.
R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5754047
|
|
|
|
|
|
| |
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5727068
|
|
|
|
|
|
| |
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5699060
|
|
|
|
|
|
|
|
|
|
| |
To find test files with legacy headers.
We can remove this flag once everything is converted.
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5694060
|
|
This doesn't run all ~750 of the tests, but most.
Progress on issue 2833
R=golang-dev, ality, rsc, r, r
CC=golang-dev
http://codereview.appspot.com/5625044
|