From cdd4a35fddb728a9bcba3594f0e2447744ac8a05 Mon Sep 17 00:00:00 2001
From: Andrew Gerrand <adg@golang.org>
Date: Thu, 8 Sep 2011 10:43:40 +1000
Subject: [release-branch.r60] goinstall: error out with paths that end with
 '/'

??? CL 4807048 / ae3b2b092cf7
goinstall: error out with paths that end with '/'

R=adg, rsc, tarmigan+golang
CC=golang-dev
http://codereview.appspot.com/4807048

Committer: Andrew Gerrand <adg@golang.org>
???

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/4968077
---
 src/cmd/goinstall/main.go | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/cmd/goinstall/main.go b/src/cmd/goinstall/main.go
index 910ab7090..baea260e5 100644
--- a/src/cmd/goinstall/main.go
+++ b/src/cmd/goinstall/main.go
@@ -182,6 +182,12 @@ func install(pkg, parent string) {
 		visit[pkg] = done
 	}()
 
+	// Don't allow trailing '/'
+	if _, f := filepath.Split(pkg); f == "" {
+		errorf("%s should not have trailing '/'\n", pkg)
+		return
+	}
+
 	// Check whether package is local or remote.
 	// If remote, download or update it.
 	tree, pkg, err := build.FindTree(pkg)
-- 
cgit v1.2.1