diff options
author | Christoph Reiter <reiter.christoph@gmail.com> | 2018-08-10 11:19:58 +0200 |
---|---|---|
committer | Christoph Reiter <reiter.christoph@gmail.com> | 2018-08-15 10:43:55 +0200 |
commit | 14dcc4a4f961bd6dd1d84ec858e0378cf43afa8b (patch) | |
tree | 356698c18599c17062e1f102b04f52558a94efc0 /Makefile.am | |
parent | f2be65b417b7179f5490c0735d053bd466f7f317 (diff) | |
download | gobject-introspection-14dcc4a4f961bd6dd1d84ec858e0378cf43afa8b.tar.gz |
tests: depend on flake8 instead of including pep8/pyflakes
g-i includes an old version of pep8 and pyflakes and uses that
during "make check".
It (1) doesn't catch all cases newer versions of pycodestyle/pyflakes catch
and (2) doesn't test all Python files (3) doesn't work with meson.
Instead of updating just remove them and depend on flake8 instead.
To run the checks simply run flake8 in the root dir.
This also makes it possible to run those checks when using meson and
not autotools.
To not get test suite failures on flake8 updates move the checks from
"make check" to an extra "make check.quality" target.
Diffstat (limited to 'Makefile.am')
-rw-r--r-- | Makefile.am | 21 |
1 files changed, 4 insertions, 17 deletions
diff --git a/Makefile.am b/Makefile.am index e071ec25..56dac796 100644 --- a/Makefile.am +++ b/Makefile.am @@ -53,30 +53,17 @@ EXTRA_DIST += \ $(pkgconfig_DATA) \ $(man_MANS) \ $(m4_DATA) \ - misc/pep8.py \ - misc/pyflakes.py \ misc/update-glib-annotations.py \ misc/update-gtkdoc-tests.py \ misc/verbump.py \ README.rst \ MSVC.README.rst \ meson.build \ - meson_options.txt - -# Default pep8.py --exclude + emacs backup files -PEP8_EXCLUDES=--exclude='.svn,CVS,.bzr,.hg,.git,__pycache__,.\#*' - -check-local: - @echo "TEST: PEP-8 INQUISITION" - @find $(top_srcdir)/giscanner -name \*.py | sort | uniq | xargs \ - $(PYTHON) $(top_srcdir)/misc/pep8.py --max-line-length=99 --ignore=E128,W503 $(PEP8_EXCLUDES) - @find $(top_srcdir)/tests -name \*.py | sort | uniq | xargs \ - $(PYTHON) $(top_srcdir)/misc/pep8.py --ignore=E127,E402,E501,E731 $(PEP8_EXCLUDES) - -check-pyflakes: - @echo " CHECK Pyflakes" - @find $(top_srcdir)/giscanner -name \*.py | sort | uniq | xargs $(PYTHON) $(top_srcdir)/misc/pyflakes.py + meson_options.txt \ + .flake8 +check.quality: + (cd $(abs_top_srcdir) && $(PYTHON) -m flake8); # Colin's handy Makefile bits for: # 1) stuffing tarballs with pre-generated scripts from your workstation |