summaryrefslogtreecommitdiff
path: root/girepository
Commit message (Collapse)AuthorAgeFilesLines
* girepository: Annotate array and array-length parameterRico Tzschichholz2016-12-103-6/+6
|
* girepository: Annotate iterator arguments as (inout)Rico Tzschichholz2016-09-152-2/+2
|
* gthash: free cmph objectsTobias Mueller2016-09-121-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | If not done, it would leak the memory as address sanitizer reports: ==1294==ERROR: LeakSanitizer: detected memory leaks Direct leak of 40 byte(s) in 1 object(s) allocated from: #0 0x7fa7a94b7602 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98602) #1 0x44c7a7 in __config_new girepository/cmph/cmph_structs.c:11 #2 0x44aaa7 in cmph_config_new girepository/cmph/cmph.c:291 #3 0x446fb5 in _gi_typelib_hash_builder_prepare girepository/gthash.c:114 #4 0x406cf7 in add_directory_index_section girepository/girmodule.c:270 #5 0x409ee6 in _g_ir_module_build_typelib girepository/girmodule.c:546 #6 0x404ada in main tools/compiler.c:217 #7 0x7fa7a70d482f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f) ==4091==ERROR: LeakSanitizer: detected memory leaks Direct leak of 40 byte(s) in 1 object(s) allocated from: #0 0x7fc20c854602 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98602) #1 0x44a3f3 in cmph_io_vector_new girepository/cmph/cmph.c:228 #2 0x44a965 in cmph_io_vector_adapter girepository/cmph/cmph.c:276 #3 0x446f9f in _gi_typelib_hash_builder_prepare girepository/gthash.c:113 #4 0x406cf7 in add_directory_index_section girepository/girmodule.c:270 #5 0x409ee6 in _g_ir_module_build_typelib girepository/girmodule.c:546 #6 0x404ada in main tools/compiler.c:217 #7 0x7fc20a47182f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
* docs: Clarify return value documentationEmmanuele Bassi2016-05-181-1/+1
| | | | Be a bit more specific than just saying "the transfer".
* docs: Fix return value descriptionEmmanuele Bassi2016-05-181-1/+1
| | | | | The return value of g_callable_info_get_caller_owns() is not a boolean any more.
* gdump: do not leak gfile objectsPaolo Borelli2016-05-081-1/+8
|
* girepository: Merge overrides with the regular search pathCarlos Garnacho2016-05-021-29/+3
| | | | | | | | | | | | | | | | | | | | | | This reverts commit e81c4681cc88a00fcd841c5a68d860d3714b55d7 The GI_TYPELIB_PATH envvar will still allow overriding the default typelib dir (based on gobject-introspection libdir), but applications will have the last say about typelib lookup directories. The resulting lookup order is now: - Paths added through g_irepository_prepend_search_path() - Paths in GI_TYPELIB_PATH - The default gobject introspection lookup dir This makes g_irespository_prepend_search_path() work as announced despite environment variables. If any application was relying on GI_TYPELIB_PATH overriding the paths of this function call (for e.g. make check, or to be able to run code inside the project tree), it is encouraged to set up a similar envvar for their application specific lookup dir, or perform this override through other means. https://bugzilla.gnome.org/show_bug.cgi?id=765735
* Fix code styleChun-wei Fan2016-03-171-4/+6
| | | | | Make my last patch to this file conform to the code style in the rest of this file.
* cmph/bdz.c: Work Around MSVC 2012 x64 Compiler BugChun-wei Fan2016-03-161-0/+6
| | | | | | | | | | | Due to an MSVC 2012 x64 compiler issue, the compiler generates bad code for bdz.c, so the for loop in assign() continues running until the point i falls below zero, causing an access violation when we try to do curr_edge=queue[i]; (line 427 in bdz.c). Address this issue by breaking out of the loop at the end of it when i reaches 0 after doing the necessary processing. https://bugzilla.gnome.org/show_bug.cgi?id=733595
* girepository: Fix some memory leaks in gdump.cPhilip Withnall2016-02-261-0/+8
| | | | | | | | | These were leaking memory when dumping introspection data from projects for building their GIR files. That’s generally not a problem, unless you’re trying to build the project with -fsanitize=address, which causes the GIR build phase to error out due to leaking memory. https://bugzilla.gnome.org/show_bug.cgi?id=762653
* Revert "libgirepository: Refuse to run in setuid applications"Colin Walters2015-12-091-13/+0
| | | | | | | | | | | | This reverts commit 98bb6c91b710a95efe4cfeb303daeec3381b9c98. It breaks programs simply executed *transitively* from a setuid binary like the dbus daemon launch helper. https://bugzilla.redhat.com/show_bug.cgi?id=1285991 Conflicts: girepository/girepository.c
* girepository: Fix memory leak in g_irepository_get_dependencies()Garrett Regier2015-11-201-3/+5
| | | | | | The transitive_dependencies GHashTable was being leaked. https://bugzilla.gnome.org/show_bug.cgi?id=758448
* repository: Fix format string error in previous commitColin Walters2015-10-121-1/+1
| | | | Regression from df21d1f362a810f48a23b7c121bf09ce398539c7
* girepository: Use constant time calculation for sections after Object fieldsSimon Feltman2015-10-106-53/+101
| | | | | | | | | | | | Add "n_field_callbacks" to ObjectBlob which represents the number of object fields which are also callbacks. This a allows a constant time computation for accessing sections after fields. Track writing of this field by passing an extra argument through the girnode writers recursive call structure. This essentally reverts a portion of commit 7027bb256d0d1ab which added a linear time computation for accessing sections after fields. Update typelib validator to also ensure n_field_callbacks is properly set. https://bugzilla.gnome.org/show_bug.cgi?id=700338
* girparser: Avoid a crash with an unset transfer annotationColin Walters2015-10-041-2/+2
| | | | | | Spotted by Coverity. https://bugzilla.gnome.org/show_bug.cgi?id=752549
* girepository: Drop executable bits from cmph .[ch] filesColin Walters2015-10-0410-0/+0
| | | | | | No reason for it. https://bugzilla.gnome.org/show_bug.cgi?id=752931
* girepository: Add missing includeColin Walters2015-09-261-0/+1
| | | | For previous commit.
* gitypeinfo: Expand documentation for g_type_info_is_pointer()Philip Withnall2015-09-261-0/+5
| | | | | | | | Note that (direction [in]out) parameters are only pointers if the underlying type being transferred is a pointer, i.e. if the formal parameter is a pointer to a pointer or deeper. https://bugzilla.gnome.org/show_bug.cgi?id=720201
* libgirepository: Refuse to run in setuid applicationsColin Walters2015-09-241-0/+12
| | | | | | | | We know of at least one privilege escalation path via `GI_TYPELIB_PATH`. I don't want to audit for others. If someone shows up with a use case we can talk. https://bugzilla.gnome.org/show_bug.cgi?id=755472
* girepository: Remove "optimization" for found prefixesJasper St. Pierre2015-07-271-11/+0
| | | | | | | | | | | | | | | This optimization is bugged and broken in the case of certain libraries. GNOME uses a lot of prefixes with "G", so we'll almost always have found the prefix. This is specifically a problem for something like GXml.xDocument, which uses a type name starting with a lower-case letter, which fools the prefix logic, but we're also fooled by the "G" appearing in GLib and Gio. A more sophisticated version of this check would have three passes: check prefix with type-case, check prefix without type-case, global search, but this is an edge case and it doesn't feel worth it to write.
* girepository: Support GError exceptions on callbacksGarrett Regier2015-06-214-13/+25
| | | | | | | | | | | Generalize "throws" attribute to SignatureBlob which can be used by all callable blob types. Keep FunctionBlob and VFuncBlob throw attributes around and functional for compatibility. Refactor girwriter.c to write out throws attribute for all callable types. Based on a patch by Simon Feltman. https://bugzilla.gnome.org/show_bug.cgi?id=729543
* girepository: Add g_struct_info_find_field()Garrett Regier2015-06-212-0/+47
| | | | | | | | | | | Add find_field utility function for finding a field info by name. Beyond convenience, this should be faster than manually using the get_n_fields and get_field functions because get_field does an additional iteration for each field to calculate offsets O(n^2). Thus find_field combines the offset and comparison computations into a single loop O(n). Based on a patch by Simon Feltman.
* scanner/girepository: remove GdkRectangle->CairoRectangleInt automatic ↵Lionel Landwerlin2015-05-111-12/+0
| | | | | | conversion https://bugzilla.gnome.org/show_bug.cgi?id=748832
* Fix docs for g_irepository_get_shared_library()Garrett Regier2015-03-101-5/+6
| | | | | https://bugzilla.gnome.org/show_bug.cgi?id=744536 Signed-off-by: Garrett Regier <garrett.regier@riftio.com>
* girepository: Add g_irepository_get_immediate_dependencies()Philip Withnall2015-02-164-10/+131
| | | | | | | | | | | | | | | | g_irepository_get_dependencies() is supposed to return the transitive closure of all dependencies of the given namespace. However, it just loads the dependencies field from the typelib, which is supposed to only list immediate dependencies. Introduce a new g_irepository_get_immediate_dependencies() which does this, and rewrite g_irepository_get_dependencies() to build the transitive closure of all its namespace dependencies. This does not require loading any new typelibs, as the transitive closure of dependencies should already have been loaded by g_irepository_require() or g_irepository_load_typelib(). https://bugzilla.gnome.org/show_bug.cgi?id=743782
* girepository: Document semantics of dependencies and includes betterPhilip Withnall2015-02-161-4/+4
| | | | | | | | Make it clear that both the dependencies field in the typelib, and the include elements in the GIR AST, are for immediate dependencies, not transitive ones. https://bugzilla.gnome.org/show_bug.cgi?id=743782
* girepository: Fix NULL return from g_irepository_get_dependencies()Philip Withnall2015-02-161-1/+9
| | | | | | | If a typelib had no dependencies, g_irepository_get_dependencies() would return NULL, rather than an empty NULL-terminated vector. https://bugzilla.gnome.org/show_bug.cgi?id=743782
* build: Export Symbols Using Compiler DirectivesChun-wei Fan2014-08-151-197/+0
| | | | | | | | | | | Use compiler directives for exporting symbols for the build of libgirepository and also for the test libraries, like what is now done in GLib and GTK+ so that maintaining a separate .symbols (and .def files) would not be needed, in which the correct compiler directive is determined during configure time. Drop all the .def files and the .symbols file as we would not be using them anymore. https://bugzilla.gnome.org/show_bug.cgi?id=732669
* girepository: Add Header for Version MacrosChun-wei Fan2014-08-1522-0/+505
| | | | | | | | | | | | | | | This adds a header to the girepository library, which is then included either directly or indirectly by the other headers so that all the public symbols (and the 2 symbols in gitypelib-internal.h used by the tools) are decorated by a macro, that can later be used to export the symbols and also to be used to display compile-time warnings for usage of deprecated APIs, which is like what is now being done in GLib (and GTK+, Clutter, and so on). This marks the first step that we begin to stop depending on the .symbols/ .def files to export the symbols. https://bugzilla.gnome.org/show_bug.cgi?id=732669
* girepository: Include config.h First in All SourcesChun-wei Fan2014-07-0720-6/+40
| | | | | | | | | This includes config.h in all the C-sources of girepository so that we can get the correct export directive from config.h during compile time and therefore export the symbols as necessary, like what GLib and GTK+ is currently doing. https://bugzilla.gnome.org/show_bug.cgi?id=732669
* Parse and expose ownership transfer for instance parametersGiovanni Campagna2014-07-037-6/+108
| | | | | | | | | | | Knowing the ownership transfer for instance parameters is necessary for correct memory management of functions which "eat" their instance argument, such as g_dbus_method_invocation_return_*. Parse this information from the gir file and store in the typelib, and then provide new API on GICallableInfo to retrieve this. https://bugzilla.gnome.org/show_bug.cgi?id=729662
* gibaseinfo: Expand g_base_info_iterate_attributes() documentationPhilip Withnall2014-06-231-1/+4
| | | | | | | Clarify what an attribute is, in response to a question on gir-devel-list. https://bugzilla.gnome.org/show_bug.cgi?id=732078
* girepository: change giarginfo docsRyan Lortie2014-05-141-3/+8
| | | | | | | Clarify the meaning of 'may be null' in the docs: it refers to the value of the argument itself, not the reference to the argument. https://bugzilla.gnome.org/show_bug.cgi?id=660879
* compiler: girparser: parse 'nullable' attributeRyan Lortie2014-05-061-1/+16
| | | | | | | | | | | Parse the 'nullable' attribute on parameters and function return types. Additionally, tweak the meaning of the 'allow-none' attribute. We now only treat it as equivalent to 'nullable' for non-out parameters. For out parameters, we treat it to mean the same as the already-recognised 'optional' parameter (which we only recently started actually using). https://bugzilla.gnome.org/show_bug.cgi?id=660879
* girepository: ArgBlob: rename allow_none parameterRyan Lortie2014-05-065-11/+11
| | | | | | | | | Rename the "allow_none" parameter on internal/private structure ArgBlob to "nullable". This is a straight rename with no other changes. https://bugzilla.gnome.org/show_bug.cgi?id=660879
* g-ir-compiler: Add support for callback fields on GObjectsSimon Feltman2014-02-273-50/+71
| | | | | | | | | | | | | | | | | Use ParseState enum instead of a boolean for the ParseContexts embedded_type flag. This allows specific tracking of the embedded type currently being parsed which can now either be STATE_STRUCT_FIELD or STATE_CLASS_FIELD (or allow for future expansion). Add ParseState::STATE_NONE as the default for this field. Fix GObject FieldBlob validation to take into account the sizeof CallbackBlobs (copied from the struct validator). Add static g_object_info_get_field_offset which parallels g_struct_info_get_field_offset which is needed since callback fields may vary in size. https://bugzilla.gnome.org/show_bug.cgi?id=725198
* giobjectinfo: Add missing transfer annotation to find_signal ()Rico Tzschichholz2014-01-231-1/+1
|
* typelib compiler: properly initialise memoryRyan Lortie2013-12-302-1/+4
| | | | | | | | | | | | | | The typelib compiler was writing uninitialised memory to the output file. There were two sources of this uninitialised memory: the hash writer included some uninitialised memory in its output, and the bytes added after the hash output for padding were also not being initialised. Fix this by passing the padded size to the hash code writer function and having that function initialise the entire memory region to zero before writing. https://bugzilla.gnome.org/show_bug.cgi?id=721177
* scanner: Support boolean constantsFlorian Müllner2013-11-291-2/+2
| | | | | | | | Aliasing TRUE or FALSE is not very common, but done occasionally for extra clarity. Namely G_SOURCE_REMOVE / G_SOURCE_CONTINUE are self-explanatory, unlike the "raw" booleans. https://bugzilla.gnome.org/show_bug.cgi?id=719566
* girnode: Fix a NULL pointer deference if a namespace can’t be foundPhilip Withnall2013-11-061-0/+5
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=711541
* GIVFuncInfo: allow retrieving the address of an interface vfuncGiovanni Campagna2013-10-221-5/+31
| | | | | | | | Don't assume that the parent of a GIVFuncInfo is a GIObjectInfo, it could be a GIInterfaceInfo, if the vfunc is part of interface instead of a class. https://bugzilla.gnome.org/show_bug.cgi?id=688375
* docs: fix up reference docs a bitDieter Verfaillie2013-10-1043-449/+1018
| | | | | | | | | | | | | - require GTK-Doc 1.19 - remove sgml mode - automatically generate gi.types (needs GTK-Doc 1.19) - fix https://bugzilla.gnome.org/show_bug.cgi?id=700025 [WIP] - rearange sections a bit [WIP] - add gi-building, gi-programming sections [WIP] - mark missing docs with TODO, which is only marginaly better than nothing but at least can be grepped :) https://bugzilla.gnome.org/show_bug.cgi?id=571648
* girepository: remove glib-compatDieter Verfaillie2013-10-093-27/+0
| | | | | We depend on glib-2.0 >= 2.36.0, so no need to keep a 2.22.X compatibility symbol around...
* giscanner: fix description field storage in .gir filesDieter Verfaillie2013-10-081-1/+2
| | | | | | | | | | | | | | | | | | GTK-Doc description fields for tags can contain multiple lines and even multiple paragraphs. Whitespace cannot be preserved in XML attributes, so we move the "deprecated" description text into a "<doc-deprecated />" element right next to where we already have the "<doc />" element. Keep the "deprecated" attribute around for backwards compatibility though, but set its value to "1" (analogous to the "writable", "contruct", etc attributes) if the annotated symbol is marked as deprecated. While at it, add <doc-version /> and <doc-stability /> which was not yet available in the .gir files... This takes care of the "Since:", "Stability:" and "Deprecated:" GTK-Doc tags. Nothing needs to be done for the "Returns:" tag as as we already write a "<doc />" child element on "<return-value />".
* giscanner: store code before and after comment blockDieter Verfaillie2013-10-081-1/+1
| | | | | | so we can later use them to re-write source files containing broken GTK-Doc comment blocks where /** is preceded by and/or */ is followed by code...
* Use case insensitive compare for signal "when" attributeSimon Feltman2013-10-051-2/+2
| | | | | | | | Update parser to use g_ascii_strcasecmp instead of strcmp. This fixes incorrect flags being set when the incomming gir is using lowercase values for the "when" attribute. https://bugzilla.gnome.org/show_bug.cgi?id=709462
* g_irepository_dump: Update doc to match codeSimon Kågedal Reimer2013-06-051-2/+4
| | | | | | | The input file no longer only consists of names of get_type-functions, instead begins with either "get-type:" or "error-quark:". https://bugzilla.gnome.org/show_bug.cgi?id=701639
* Add printf attributeChristian Persch2013-05-051-0/+3
| | | | | | This fixes a compiler warning when using -Wmissing-format-attribute. https://bugzilla.gnome.org/show_bug.cgi?id=698521
* typelib: Also ignore typelibs with empty c:prefixColin Walters2013-04-151-1/+1
| | | | | | | As seen in xlib.gir at least; this is something we should probably ban though. https://bugzilla.gnome.org/697759
* girparser: Also honor legacy c:prefixColin Walters2013-04-151-0/+3
| | | | | | | vala generates this, and we need to honor it now that we're using the c:prefix as an optimization when searching for gtypes. https://bugzilla.gnome.org/697759