From 578717e32c3c15fb2e99068e0ef9ee90171fd8ba Mon Sep 17 00:00:00 2001 From: "Owen W. Taylor" Date: Tue, 21 Apr 2009 10:57:50 -0400 Subject: Fix checks in gfield.c When checking if the readable/writable flags are missing for the fields we are trying to read and write, use (a & flag) == 0, not (!a & flag). http://bugzilla.gnome.org/show_bug.cgi?id=579727 --- girepository/gfield.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/girepository/gfield.c b/girepository/gfield.c index 2fa98227..94c2fb59 100644 --- a/girepository/gfield.c +++ b/girepository/gfield.c @@ -25,7 +25,7 @@ g_field_info_get_field (GIFieldInfo *field_info, GITypeInfo *type_info; gboolean result = FALSE; - if (!g_field_info_get_flags (field_info) & GI_FIELD_IS_READABLE) + if ((g_field_info_get_flags (field_info) & GI_FIELD_IS_READABLE) == 0) return FALSE; offset = g_field_info_get_offset (field_info); @@ -219,7 +219,7 @@ g_field_info_get_field (GIFieldInfo *field_info, * to write fields where memory management would by required. A field * with a type such as 'char *' must be set with a setter function. * - * Returns: %TRUE if reading the field succeeded, otherwise %FALSE + * Returns: %TRUE if writing the field succeeded, otherwise %FALSE */ gboolean g_field_info_set_field (GIFieldInfo *field_info, @@ -230,7 +230,7 @@ g_field_info_set_field (GIFieldInfo *field_info, GITypeInfo *type_info; gboolean result = FALSE; - if (!g_field_info_get_flags (field_info) & GI_FIELD_IS_WRITABLE) + if ((g_field_info_get_flags (field_info) & GI_FIELD_IS_WRITABLE) == 0) return FALSE; offset = g_field_info_get_offset (field_info); -- cgit v1.2.1