From 5d68eb77b26a8054cad3d37144c8ad2fb0a3ebaf Mon Sep 17 00:00:00 2001 From: Emmanuele Bassi Date: Wed, 22 Nov 2017 16:23:49 +0000 Subject: meson: Use symbol visibility for giscanner module Remove the existing TODO and avoid playing games with the linker. We already have a mechanism in place for controlling he visibility of our symbols. Signed-off-by: Nirbheek Chauhan --- giscanner/giscannermodule.c | 2 +- giscanner/meson.build | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/giscanner/giscannermodule.c b/giscanner/giscannermodule.c index 4c1f00f3..77de82d6 100644 --- a/giscanner/giscannermodule.c +++ b/giscanner/giscannermodule.c @@ -53,7 +53,7 @@ #endif /* forward declaration */ -MOD_INIT(_giscanner); +_GI_EXTERN MOD_INIT(_giscanner); #define NEW_CLASS(ctype, name, cname, num_methods) \ static const PyMethodDef _Py##cname##_methods[num_methods]; \ diff --git a/giscanner/meson.build b/giscanner/meson.build index 5a92a169..dc166f5a 100644 --- a/giscanner/meson.build +++ b/giscanner/meson.build @@ -72,9 +72,9 @@ giscanner_lib = static_library('giscanner', dependencies: [glib_dep, gobject_dep, gio_dep, gmodule_dep], ) -# TODO: -export-symbols-regex "init_giscanner|PyInit__giscanner" giscanner_pymod = py3.extension_module('_giscanner', 'giscannermodule.c', link_with: giscanner_lib, + c_args: [gi_hidden_visibility_cflags], dependencies: [glib_dep, gobject_dep, gio_dep, gmodule_dep, dependency('python3')], install: true, -- cgit v1.2.1