From 5e61825e2ed0412f49c21ba2f24893a8d305ec4b Mon Sep 17 00:00:00 2001
From: Christoph Reiter <reiter.christoph@gmail.com>
Date: Sun, 29 Jul 2018 16:02:43 +0200
Subject: build: enable -Wsign-compare

Except for the generated lexer code which triggers it with the
version of flex used in our CI.
---
 Makefile-giscanner.am | 2 +-
 configure.ac          | 6 +++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/Makefile-giscanner.am b/Makefile-giscanner.am
index 7f437d0e..4f08934c 100644
--- a/Makefile-giscanner.am
+++ b/Makefile-giscanner.am
@@ -23,7 +23,7 @@ libgiscanner_la_SOURCES = \
 	giscanner/scannerparser.y
 libgiscanner_la_CPPFLAGS = -I$(top_srcdir)/girepository -I$(top_srcdir)/giscanner
 libgiscanner_la_LIBADD = $(GOBJECT_LIBS) $(GIO_LIBS)
-libgiscanner_la_CFLAGS = $(GOBJECT_CFLAGS) $(GIO_CFLAGS) $(WARN_CFLAGS)
+libgiscanner_la_CFLAGS = $(GOBJECT_CFLAGS) $(GIO_CFLAGS) $(WARN_CFLAGS_FLEX)
 libgiscanner_la_LDFLAGS = $(WARN_LDFLAGS)
 
 # Python module
diff --git a/configure.ac b/configure.ac
index c8148c25..759f1bc0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -66,12 +66,16 @@ AX_COMPILER_FLAGS(,, [yes])
 AX_APPEND_COMPILE_FLAGS([-Wno-duplicated-branches -Wno-switch-enum])
 # FIXME: Fix the warnings and remove the flags
 AX_APPEND_COMPILE_FLAGS([-Wno-redundant-decls -Wno-switch-default -Wno-deprecated-declarations -Wno-type-limits])
-AX_APPEND_COMPILE_FLAGS([-Wno-implicit-fallthrough -Wno-sign-compare])
+AX_APPEND_COMPILE_FLAGS([-Wno-implicit-fallthrough])
 
 WARN_CFLAGS_PYTHON="$WARN_CFLAGS"
 AX_APPEND_COMPILE_FLAGS([-Wno-discarded-qualifiers], [WARN_CFLAGS_PYTHON])
 AC_SUBST(WARN_CFLAGS_PYTHON)
 
+WARN_CFLAGS_FLEX="$WARN_CFLAGS"
+AX_APPEND_COMPILE_FLAGS([-Wno-sign-compare], [WARN_CFLAGS_FLEX])
+AC_SUBST(WARN_CFLAGS_FLEX)
+
 # Checks for libraries.
 AC_CHECK_LIB([dl], [dlopen])
 
-- 
cgit v1.2.1