From 85b1d70b93211415d975deff6050f1401743e72d Mon Sep 17 00:00:00 2001 From: Sam Thursfield Date: Fri, 14 Apr 2017 13:02:35 +0100 Subject: Fix 'Bad file descriptor' error when checking libtool version Running g-ir-scanner on Fedora 25 (libtool 2.4.6) produces the following message on stderr, twice: /usr/bin/libtool: line 2460: printf: write error: Bad file descriptor This is because we were redirecting stdout to /dev/null incorrectly -- we were opening /dev/null for reading rather than for writing. https://bugzilla.gnome.org/show_bug.cgi?id=781312 --- giscanner/utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/giscanner/utils.py b/giscanner/utils.py index aff5393a..da848d52 100644 --- a/giscanner/utils.py +++ b/giscanner/utils.py @@ -159,7 +159,7 @@ def get_libtool_command(options): libtool_cmd = 'glibtool' try: subprocess.check_call([libtool_cmd, '--version'], - stdout=open(os.devnull)) + stdout=open('/dev/null', 'w')) except (subprocess.CalledProcessError, OSError): # If libtool's not installed, assume we don't need it return None -- cgit v1.2.1