From 72c670cebf938868ae2a4d71b990cea0f0b7a114 Mon Sep 17 00:00:00 2001 From: Chun-wei Fan Date: Mon, 11 Mar 2019 12:30:36 +0800 Subject: MSVC.README.rst: Update VS 2008/x64 build notes It appears that tests/repository/gitypelibtest.c needs to be added to the list of files that we must change the optimization flag from /O2 to /O1 in order that the Visual Studio 2008 x64 compiler does not hang, due to compiler optimization issues. --- MSVC.README.rst | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'MSVC.README.rst') diff --git a/MSVC.README.rst b/MSVC.README.rst index 42d3b1da..be1988b6 100644 --- a/MSVC.README.rst +++ b/MSVC.README.rst @@ -83,9 +83,10 @@ On x64 builds, building girepository\girepository-1.0-1.dll may hang during comp If this happens, terminate all 'cl.exe' processes, which will terminate the build process. Open build.ninja and change the compiler flags by changing /O2 to /O1 for all the sources that hang during compilation. At this time of writing, girepository\girwriter.c, -girepository\girparser.c and girepository\girnode.c are affected--this is due to an issue -in Visual Studio 2008's x64 compiler in regards to optimization. Re-attempt the build, and -the build should complete normally. This does not affect Win32/x86 builds. +girepository\girparser.c, girepository\girnode.c and tests\repository\gitypelibtest.c are +affected--this is due to an issue in Visual Studio 2008's x64 compiler in regards to +optimization. Re-attempt the build, and the build should complete normally. This does not +affect Win32/x86 builds. On all Visual Studio 2008 builds, after successfully completing/installing the build, run the following so that we ensure the manifests are embedded to the built DLLs and EXEs:: -- cgit v1.2.1