From 749df9a4c0ad63069cac8c5d17325175584b20d4 Mon Sep 17 00:00:00 2001 From: Simon Feltman Date: Thu, 1 May 2014 03:51:50 -0700 Subject: giscanner: Sort unknown parameters in error message Sort the parameters displayed for the "unknown parameters" error message. The parameter names are stored in a set which returns a different ordering between Python 2 and 3 (set/dict ordering should not be relied upon anyhow). This fixes test failures in warning tests. https://bugzilla.gnome.org/show_bug.cgi?id=679438 --- giscanner/maintransformer.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'giscanner/maintransformer.py') diff --git a/giscanner/maintransformer.py b/giscanner/maintransformer.py index fc59fa80..1a91c9fb 100644 --- a/giscanner/maintransformer.py +++ b/giscanner/maintransformer.py @@ -802,7 +802,8 @@ class MainTransformer(object): (param, ) = unused text = ", should be '%s'" % (param, ) else: - text = ", should be one of %s" % (', '.join("'%s'" % p for p in unused), ) + text = ", should be one of %s" % \ + (', '.join("'%s'" % p for p in sorted(unused)), ) param = block.params.get(doc_name) message.warn("%s: unknown parameter '%s' in documentation " -- cgit v1.2.1