diff options
| author | Abseil Team <absl-team@google.com> | 2019-09-25 18:40:52 -0400 |
|---|---|---|
| committer | Gennadiy Civil <misterg@google.com> | 2019-09-27 16:48:33 -0400 |
| commit | cb3f7ce1deef5084306c929528a9728afdb17164 (patch) | |
| tree | 1e25e13562a6eabd76d9ba4abc0d1832927e09c1 | |
| parent | a783ade7c2448d7feabe9874aecf8c83b67422c0 (diff) | |
| download | googletest-git-cb3f7ce1deef5084306c929528a9728afdb17164.tar.gz | |
Googletest export
Makes testing::ResultOf() work with non-copyable arguments.
PiperOrigin-RevId: 271222632
| -rw-r--r-- | googlemock/include/gmock/gmock-matchers.h | 6 | ||||
| -rw-r--r-- | googlemock/test/gmock-matchers_test.cc | 10 |
2 files changed, 14 insertions, 2 deletions
diff --git a/googlemock/include/gmock/gmock-matchers.h b/googlemock/include/gmock/gmock-matchers.h index bf9eb205..28e188bb 100644 --- a/googlemock/include/gmock/gmock-matchers.h +++ b/googlemock/include/gmock/gmock-matchers.h @@ -1858,7 +1858,9 @@ struct CallableTraits { static void CheckIsValid(Functor /* functor */) {} template <typename T> - static auto Invoke(Functor f, T arg) -> decltype(f(arg)) { return f(arg); } + static auto Invoke(Functor f, const T& arg) -> decltype(f(arg)) { + return f(arg); + } }; // Specialization for function pointers. @@ -1889,7 +1891,7 @@ class ResultOfMatcher { template <typename T> operator Matcher<T>() const { - return Matcher<T>(new Impl<T>(callable_, matcher_)); + return Matcher<T>(new Impl<const T&>(callable_, matcher_)); } private: diff --git a/googlemock/test/gmock-matchers_test.cc b/googlemock/test/gmock-matchers_test.cc index 88f144d1..03735267 100644 --- a/googlemock/test/gmock-matchers_test.cc +++ b/googlemock/test/gmock-matchers_test.cc @@ -4318,6 +4318,16 @@ TEST(ResultOfTest, WorksForLambdas) { EXPECT_FALSE(matcher.Matches(1)); } +TEST(ResultOfTest, WorksForNonCopyableArguments) { + Matcher<std::unique_ptr<int>> matcher = ResultOf( + [](const std::unique_ptr<int>& str_len) { + return std::string(static_cast<size_t>(*str_len), 'x'); + }, + "xxx"); + EXPECT_TRUE(matcher.Matches(std::unique_ptr<int>(new int(3)))); + EXPECT_FALSE(matcher.Matches(std::unique_ptr<int>(new int(1)))); +} + const int* ReferencingFunction(const int& n) { return &n; } struct ReferencingFunctor { |