diff options
| author | Aliaksey Kandratsenka <alk@tut.by> | 2013-11-16 11:35:32 -0800 |
|---|---|---|
| committer | Aliaksey Kandratsenka <alk@tut.by> | 2013-11-16 11:35:32 -0800 |
| commit | 2bf83af65664a2badbaebdb722ad498e8b38548c (patch) | |
| tree | 3fbe5b06f98a5846f642eab9e61d4bed262fdaef | |
| parent | b3b19269783cf1ed163bdb447cef9ca11b10851c (diff) | |
| download | gperftools-2bf83af65664a2badbaebdb722ad498e8b38548c.tar.gz | |
issue-587: fix typos in unit test scripts
As proposed by Hannes Weisbach.
The argument will be garbled because of a misplaced brace, for example
(heap-checker_unittest.sh):
HEAP_CHECKER="${1:-$BINDIR}/heap-checker_unittest"
which should be:
HEAP_CHECKER="${1:-$BINDIR/heap-checker_unittest}"
This unit test is used to check the binaries heap-checker_unittest and
heap-checker_debug_unittest. With the typo, the executable
heap-checker_debug_unittest is never actually run.
| -rwxr-xr-x | src/tests/heap-checker-death_unittest.sh | 2 | ||||
| -rwxr-xr-x | src/tests/heap-checker_unittest.sh | 2 | ||||
| -rwxr-xr-x | src/tests/heap-profiler_unittest.sh | 2 | ||||
| -rwxr-xr-x | src/tests/tcmalloc_unittest.sh | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/src/tests/heap-checker-death_unittest.sh b/src/tests/heap-checker-death_unittest.sh index ab4a666..752a7ad 100755 --- a/src/tests/heap-checker-death_unittest.sh +++ b/src/tests/heap-checker-death_unittest.sh @@ -44,7 +44,7 @@ if [ "x$1" = "x-h" -o "x$1" = "x--help" ]; then exit 1 fi -EXE="${1:-$BINDIR}/heap-checker_unittest" +EXE="${1:-$BINDIR/heap-checker_unittest}" TMPDIR="/tmp/heap_check_death_info" ALARM() { diff --git a/src/tests/heap-checker_unittest.sh b/src/tests/heap-checker_unittest.sh index 765e6c7..3c9c0e9 100755 --- a/src/tests/heap-checker_unittest.sh +++ b/src/tests/heap-checker_unittest.sh @@ -48,7 +48,7 @@ if [ "x$1" = "x-h" -o "$1" = "x--help" ]; then exit 1 fi -HEAP_CHECKER="${1:-$BINDIR}/heap-checker_unittest" +HEAP_CHECKER="${1:-$BINDIR/heap-checker_unittest}" PPROF_PATH="${2:-$PPROF_PATH}" TMPDIR=/tmp/heap_check_info diff --git a/src/tests/heap-profiler_unittest.sh b/src/tests/heap-profiler_unittest.sh index ad0a1ec..b4c2e9f 100755 --- a/src/tests/heap-profiler_unittest.sh +++ b/src/tests/heap-profiler_unittest.sh @@ -52,7 +52,7 @@ if [ "x$1" = "x-h" -o "x$1" = "x--help" ]; then exit 1 fi -HEAP_PROFILER="${1:-$BINDIR}/heap-profiler_unittest" +HEAP_PROFILER="${1:-$BINDIR/heap-profiler_unittest}" PPROF="${2:-$PPROF_PATH}" TEST_TMPDIR=/tmp/heap_profile_info diff --git a/src/tests/tcmalloc_unittest.sh b/src/tests/tcmalloc_unittest.sh index 5958d7c..7f806b5 100755 --- a/src/tests/tcmalloc_unittest.sh +++ b/src/tests/tcmalloc_unittest.sh @@ -38,7 +38,7 @@ # behavior, just performance. BINDIR="${BINDIR:-.}" -TCMALLOC_UNITTEST="${1:-$BINDIR}/tcmalloc_unittest" +TCMALLOC_UNITTEST="${1:-$BINDIR/tcmalloc_unittest}" TMPDIR=/tmp/tcmalloc_unittest rm -rf $TMPDIR || exit 2 |