diff options
| author | Daniel Kahn Gillmor <dkg@fifthhorseman.net> | 2018-12-04 20:29:40 +0300 |
|---|---|---|
| committer | Daniel Kahn Gillmor <dkg@fifthhorseman.net> | 2018-12-05 02:40:25 +0300 |
| commit | 5e21e61cfef809a7194ff94fb3aac525169a26b5 (patch) | |
| tree | cb1145cfd3ea49c436f00f6c625ba05f670d9dd2 | |
| parent | fefa46173e506b0e4156e73a250d6915fe229223 (diff) | |
| download | gpgme-5e21e61cfef809a7194ff94fb3aac525169a26b5.tar.gz | |
python: ctx.decrypt() has problematic error handling
* lang/python/src/core.py (Context.decrypt): document odd
error-handling behavior as a potential problem to be addressed.
Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
| -rw-r--r-- | lang/python/src/core.py | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/lang/python/src/core.py b/lang/python/src/core.py index 3bd6f717..f3202eb1 100644 --- a/lang/python/src/core.py +++ b/lang/python/src/core.py @@ -427,6 +427,10 @@ class Context(GpgmeWrapper): results=results) if verify: + # FIXME: should we really throw BadSignature, even if + # we've encountered some good signatures? as above, once + # we hit this error, there is no way to accept it and + # continue to process the remaining signatures. if any(s.status != errors.NO_ERROR for s in verify_result.signatures): raise errors.BadSignatures(verify_result, results=results) |