diff options
| author | Eric S. Raymond <esr@thyrsus.com> | 2015-03-30 17:10:53 -0400 |
|---|---|---|
| committer | Eric S. Raymond <esr@thyrsus.com> | 2015-03-30 17:10:53 -0400 |
| commit | 28bf37132d86cc59320e21d843960d086cef664c (patch) | |
| tree | bf085b5f89f1d1061b6a88ecc66c50721b13d86c /driver_nmea0183.c | |
| parent | ecb7e1ff3ec73000918c56861c55258c2d4deada (diff) | |
| download | gpsd-28bf37132d86cc59320e21d843960d086cef664c.tar.gz | |
Retire splint from our set of static analyzers.
The proximate cause was that we've been seing emission of error
messages that were randomly and disturbingly variable across different
environments - notably Raspbian and Gentoo splint gave nontrivially
different results than Ubuntu 14.10 splint. And this was *not* due to
Ubuntu patches! A pristine splint built from the 3.1.2 tarball on
Ubuntu didn't match the Raspbian and Gentoo results either.
But this has been coming for a while. Easy access to more modern
static analyzers such as coverity, scan-build and cppcheck has been
decreasing the utility of splint, which is unmaintained and somewhat
buggy and not easy to use.
Only file not cleaned is ppsthread.c, because Gary has been working
on it during this cleanup.
All regression tests pass. PPS observed live on GR601-W.
Diffstat (limited to 'driver_nmea0183.c')
| -rw-r--r-- | driver_nmea0183.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/driver_nmea0183.c b/driver_nmea0183.c index 81e5878e..0b817b9a 100644 --- a/driver_nmea0183.c +++ b/driver_nmea0183.c @@ -1336,7 +1336,6 @@ static gps_mask_t processMTK3301(int c UNUSED, char *field[], * **************************************************************************/ -/*@ -mayaliasunique @*/ gps_mask_t nmea_parse(char *sentence, struct gps_device_t * session) /* parse an NMEA sentence, unpack it into a session structure */ { @@ -1349,7 +1348,6 @@ gps_mask_t nmea_parse(char *sentence, struct gps_device_t * session) bool cycle_continue; /* cycle continuer? */ nmea_decoder decoder; } nmea_phrase[] = { - /*@ -nullassign @*/ {"PGRMC", 0, false, NULL}, /* ignore Garmin Sensor Config */ {"PGRME", 7, false, processPGRME}, {"PGRMI", 0, false, NULL}, /* ignore Garmin Sensor Init */ @@ -1398,7 +1396,6 @@ gps_mask_t nmea_parse(char *sentence, struct gps_device_t * session) {"TXT", 5, false, processTXT}, {"ZDA", 4, false, processZDA}, {"VTG", 0, false, NULL}, /* ignore Velocity Track made Good */ - /*@ +nullassign @*/ }; int count; @@ -1422,7 +1419,6 @@ gps_mask_t nmea_parse(char *sentence, struct gps_device_t * session) return ONLINE_SET; } - /*@ -usedef @*//* splint 3.1.1 seems to have a bug here */ /* make an editable copy of the sentence */ (void)strlcpy((char *)session->nmea.fieldcopy, sentence, sizeof(session->nmea.fieldcopy) - 1); /* discard the checksum part */ @@ -1441,13 +1437,11 @@ gps_mask_t nmea_parse(char *sentence, struct gps_device_t * session) /* while there is a search string and we haven't run off the buffer... */ while ((p != NULL) && (p <= t)) { session->nmea.field[count] = p; /* we have a field. record it */ - /*@ -compdef @*/ if ((p = strchr(p, ',')) != NULL) { /* search for the next delimiter */ *p = '\0'; /* replace it with a NUL */ count++; /* bump the counters and continue */ p++; } - /*@ +compdef @*/ } /* point remaining fields at empty string, just in case */ @@ -1586,7 +1580,6 @@ gps_mask_t nmea_parse(char *sentence, struct gps_device_t * session) return retval; } -/*@ +mayaliasunique @*/ #endif /* NMEA_ENABLE */ void nmea_add_checksum(char *sentence) |