diff options
| author | Eric S. Raymond <esr@thyrsus.com> | 2015-03-30 17:10:53 -0400 |
|---|---|---|
| committer | Eric S. Raymond <esr@thyrsus.com> | 2015-03-30 17:10:53 -0400 |
| commit | 28bf37132d86cc59320e21d843960d086cef664c (patch) | |
| tree | bf085b5f89f1d1061b6a88ecc66c50721b13d86c /monitor_superstar2.c | |
| parent | ecb7e1ff3ec73000918c56861c55258c2d4deada (diff) | |
| download | gpsd-28bf37132d86cc59320e21d843960d086cef664c.tar.gz | |
Retire splint from our set of static analyzers.
The proximate cause was that we've been seing emission of error
messages that were randomly and disturbingly variable across different
environments - notably Raspbian and Gentoo splint gave nontrivially
different results than Ubuntu 14.10 splint. And this was *not* due to
Ubuntu patches! A pristine splint built from the 3.1.2 tarball on
Ubuntu didn't match the Raspbian and Gentoo results either.
But this has been coming for a while. Easy access to more modern
static analyzers such as coverity, scan-build and cppcheck has been
decreasing the utility of splint, which is unmaintained and somewhat
buggy and not easy to use.
Only file not cleaned is ppsthread.c, because Gary has been working
on it during this cleanup.
All regression tests pass. PPS observed live on GR601-W.
Diffstat (limited to 'monitor_superstar2.c')
| -rw-r--r-- | monitor_superstar2.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/monitor_superstar2.c b/monitor_superstar2.c index f4aa08d7..489c7a8f 100644 --- a/monitor_superstar2.c +++ b/monitor_superstar2.c @@ -15,7 +15,6 @@ static bool superstar2_initialize(void) { int i; - /*@ -onlytrans @*/ /* "heavily inspired" by monitor_nmea.c */ if ((satwin = derwin(devicewin, 15, 27, 7, 0)) == NULL) return false; @@ -26,7 +25,6 @@ static bool superstar2_initialize(void) (void)mvwprintw(satwin, (int)(i + 2), 1, "%2d", i); (void)mvwprintw(satwin, 14, 1, " Satellite Data & Status "); (void)wattrset(satwin, A_NORMAL); - /*@ +onlytrans @*/ return true; } @@ -45,10 +43,8 @@ static void display_superstar2_svinfo(unsigned char *buf, size_t data_len) char el; unsigned short az; - /*@ +charint */ if ((porn = (unsigned char)getub(buf, off) & 0x1f) == 0) porn = ((unsigned char)getub(buf, off + 3) >> 1) + 87; - /*@ -charint */ ss = (unsigned char)getub(buf, off + 4); el = (char)getsb(buf, off + 1); @@ -56,11 +52,9 @@ static void display_superstar2_svinfo(unsigned char *buf, size_t data_len) ((getub(buf, off + 3) & 0x1) << 1)); fl = (unsigned char)getub(buf, off) & 0xe0; (void)wmove(satwin, i + 2, 4); - /*@ +charint */ (void)wprintw(satwin, "%3u %3d %2d %02d %02x %c", porn, az, el, ss, fl, ((fl & 0x60) == 0x60) ? 'Y' : ' '); - /*@ -charint */ } (void)wnoutrefresh(satwin); return; |