diff options
| author | Eric S. Raymond <esr@thyrsus.com> | 2015-03-30 17:10:53 -0400 |
|---|---|---|
| committer | Eric S. Raymond <esr@thyrsus.com> | 2015-03-30 17:10:53 -0400 |
| commit | 28bf37132d86cc59320e21d843960d086cef664c (patch) | |
| tree | bf085b5f89f1d1061b6a88ecc66c50721b13d86c /monitor_ubx.c | |
| parent | ecb7e1ff3ec73000918c56861c55258c2d4deada (diff) | |
| download | gpsd-28bf37132d86cc59320e21d843960d086cef664c.tar.gz | |
Retire splint from our set of static analyzers.
The proximate cause was that we've been seing emission of error
messages that were randomly and disturbingly variable across different
environments - notably Raspbian and Gentoo splint gave nontrivially
different results than Ubuntu 14.10 splint. And this was *not* due to
Ubuntu patches! A pristine splint built from the 3.1.2 tarball on
Ubuntu didn't match the Raspbian and Gentoo results either.
But this has been coming for a while. Easy access to more modern
static analyzers such as coverity, scan-build and cppcheck has been
decreasing the utility of splint, which is unmaintained and somewhat
buggy and not easy to use.
Only file not cleaned is ppsthread.c, because Gary has been working
on it during this cleanup.
All regression tests pass. PPS observed live on GR601-W.
Diffstat (limited to 'monitor_ubx.c')
| -rw-r--r-- | monitor_ubx.c | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/monitor_ubx.c b/monitor_ubx.c index 7a95540e..11a290bf 100644 --- a/monitor_ubx.c +++ b/monitor_ubx.c @@ -21,7 +21,6 @@ static bool ubx_initialize(void) { int i; - /*@ -onlytrans @*/ /* "heavily inspired" by monitor_nmea.c */ if ((satwin = derwin(devicewin, 19, 28, 0, 0)) == NULL) return false; @@ -32,7 +31,6 @@ static bool ubx_initialize(void) display(satwin, (int)(i + 2), 1, "%2d", i); display(satwin, 18, 7, " NAV_SVINFO "); (void)wattrset(satwin, A_NORMAL); - /*@ -onlytrans @*/ /* "heavily inspired" by monitor_nmea.c */ if ((navsolwin = derwin(devicewin, 13, 51, 0, 28)) == NULL) @@ -123,7 +121,6 @@ static void display_nav_svinfo(unsigned char *buf, size_t data_len) return; } -/*@ -mustfreeonly -compdestroy @*/ static void display_nav_sol(unsigned char *buf, size_t data_len) { unsigned short gw = 0; @@ -136,10 +133,6 @@ static void display_nav_sol(unsigned char *buf, size_t data_len) if (data_len != 52) return; -#ifdef S_SPLINT_S - assert(navsolwin != NULL); -#endif /* S_SPLINT_S */ - navmode = (unsigned char)getub(buf, 10); flags = (unsigned int)getub(buf, 11); @@ -178,7 +171,6 @@ static void display_nav_sol(unsigned char *buf, size_t data_len) (void)wattrset(navsolwin, A_NORMAL); (void)wmove(navsolwin, 7, 7); - /*@ -compdef @*/ { unsigned int day = tow / 8640000; unsigned int tod = tow % 8640000; @@ -192,7 +184,6 @@ static void display_nav_sol(unsigned char *buf, size_t data_len) (void)wprintw(navsolwin, "%u %02u:%02u:%05.2f", day, h, m, (double)s / 100); (void)wattrset(navsolwin, A_NORMAL); } - /*@ +compdef @*/ (void)wmove(navsolwin, 8, 11); if ((flags & (UBX_SOL_VALID_WEEK | UBX_SOL_VALID_TIME)) != 0) { (void)wprintw(navsolwin, "%d+%10.3lf", gw, (double)(tow / 1000.0)); @@ -216,7 +207,6 @@ static void display_nav_sol(unsigned char *buf, size_t data_len) (void)wnoutrefresh(navsolwin); } -/*@ +mustfreeonly +compdestroy @*/ static void display_nav_dop(unsigned char *buf, size_t data_len) { |