| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Signed-off-by: Michael Brown <mbrown@fensystems.co.uk>
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
This change breaks regression tests ansd is uneccessary. Because of the
guard "if (session->fixcnt <= PPS_MIN_FIXES): in timehint.c, time
hints won't be shipped until fixes have been seen.
With this fix, regression tests pass again.
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
gps.h says one thung, the NMEA0183 driver another. Needs investigation.
All regression tests pass (significant after Sanjeev's recent changes).
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The proximate cause was that we've been seing emission of error
messages that were randomly and disturbingly variable across different
environments - notably Raspbian and Gentoo splint gave nontrivially
different results than Ubuntu 14.10 splint. And this was *not* due to
Ubuntu patches! A pristine splint built from the 3.1.2 tarball on
Ubuntu didn't match the Raspbian and Gentoo results either.
But this has been coming for a while. Easy access to more modern
static analyzers such as coverity, scan-build and cppcheck has been
decreasing the utility of splint, which is unmaintained and somewhat
buggy and not easy to use.
Only file not cleaned is ppsthread.c, because Gary has been working
on it during this cleanup.
All regression tests pass. PPS observed live on GR601-W.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
No output change, just send text contents to stderr on LOG_WARN.
scons check passes
|
|
|
|
| |
Now I can find things and satisfy my OCD.
|
| |
|
|
|
|
| |
No code changes, just a comment.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is done so we can add a "log" hook to the pps_thread_t
structure (this is not done yet) and harmonize with the name of the
outer logging function. If that name had been left as gpsd_report()
there would have been scope for bad confusion with the report_hook
member.
Also, remove two stray duplicative printf calls from the NMEA2000 driver
(drivers shouldn't have printfs!) and fix one typo.
This is a step towards factoring out ntplib. For that to happen, the
PPS thread code needs to be decoupled from the core session structure.
No logic changes. Object compatibility preserved. All regression tests pass.
|
| |
|
|
|
|
| |
All regression tests pass.
|
|
|
|
|
| |
All regression tests pass. Required one test rebuild for QZNSS; Beidou
test added.
|
| |
|
| |
|
|
|
|
| |
This change doesn't affect generated binary code.
|
|
|
|
|
|
| |
Don't use constant/expression from an array's definition when referring
to its size. Eliminates redundancy and avoids problems when array size
changes. The change doesn't affect generated code.
|
|
|
|
|
|
|
| |
Instead, set the used member in the satellites array directly where possible.
The NMEA0183 and TSIP drivers still need a local equivalent.
This changes pseudo-NMEA GSA output in several binary-protocol tests.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
...from a set of parallel arrays. This change flushed out a
longstanding bug in the computation of DOPs for estimated error bars.
Some test-load rebuilds were required:
geostar-geos1m-binary.log.chk: With this change error
estimates are computed and reported.
trimble-lassen_iq-3dfix.log, trimble-lassen_iq-3dfix.log: the
change revealed a bug in the computation of satellite-seen bits.
Error estimates did not change.
navcom.log: Error estimates changed.
With these rebuilds, all regression tests pass.
|
|
|
|
| |
Required 13 regression-test rebuilds.
|
|
|
|
| |
All regression tests pass.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
...with calls to gps_notify(), which indirects to its output method
through a slot in an errout structure. Usually the errout structure
lives inside the session context, but because struct errout_t is its
own thing this does not have to be the case. One large clique of
gpsd_notify() calls, in packet.c and isgps.c, looks at a struct
errout_t copy in a lexer control block
This change is not complete. Remnant gpsd_report calls need to be changed,
and gpsmon needs to be tweaked so that the struct_error_t in its context
is a non-defaukt hook updating the cuses display rather than simply
dumping to stderr. Also the report label functionality needs to be added.
All regression tests pass.
|
|
|
|
|
|
| |
A major step towards eliminating reverse linkage.
All regression tests pass.
|
|
|
|
|
| |
Fixes Savannah bug #42407: wrong interpretation of NMEA messages for mixed
GPS/GLONASS recievers.
|
|
|
|
|
| |
This isn't ideal. Wgen a GPS emits both we get two SKY reports per cycle,
with the second one cumulative.
|
|
|
|
| |
All regression tests pass.
|
|
|
|
|
|
|
| |
This time, the NMEA privarte storage is outside the union, so mode-switching
won't step on stuff.
All regression tests pass.
|
|
|
|
|
|
|
| |
Required a regression-test rebuild, of course. The field is still set by
the TSIP and SiRF drivers; the SiRF driver actually uses it. It may be
possible to eliminate the TSIP uses, but so far attempting this has
produced odd regression-test failures.
|
| |
|
|
|
|
|
|
|
| |
No logic changes. All regression tests pass.
The real point here is to get all the code for time-related edge cases
into timebase.c so it can be reviewed as a unit.
|
| |
|
|
|
|
| |
This logging level is intended to directly explain accompanying I/O messages.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
More is needed near driver_nmea0183.c:1108.
|
| |
|
| |
|