| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit d1965788249d7e22cdde4021d452cf0dc6c6b9bd.
This breaks my build on Gentoo running gcc 4.9.2
libgps_shm.c: In function 'int gps_shm_read(gps_data_t*)':
libgps_shm.c:122:12: error: no match for 'operator=' (operand types are
'gps_data_t' and 'volatile gps_data_t')
noclobber = shared->gpsdata;
^
libgps_shm.c:122:12: note: candidate is:
In file included from gpsd.h:350:0,
from libgps_shm.c:30:
gps.h:1918:8: note: gps_data_t& gps_data_t::operator=(const gps_data_t&)
struct gps_data_t {
^
gps.h:1918:8: note: no known conversion for argument 1 from 'volatile
gps_data_t' to 'const gps_data_t&'
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The proximate cause was that we've been seing emission of error
messages that were randomly and disturbingly variable across different
environments - notably Raspbian and Gentoo splint gave nontrivially
different results than Ubuntu 14.10 splint. And this was *not* due to
Ubuntu patches! A pristine splint built from the 3.1.2 tarball on
Ubuntu didn't match the Raspbian and Gentoo results either.
But this has been coming for a while. Easy access to more modern
static analyzers such as coverity, scan-build and cppcheck has been
decreasing the utility of splint, which is unmaintained and somewhat
buggy and not easy to use.
Only file not cleaned is ppsthread.c, because Gary has been working
on it during this cleanup.
All regression tests pass. PPS observed live on GR601-W.
|
| |
|
|
|
|
| |
gpsd_config.h needs time_t which is in time.h
OS X builds now. Untested.
|
| |
|
|
|
|
|
| |
HAVE_TERMIOS_H was some sort of relic, apparently always on. I don't think the
code would have compiled without it.
All regression tests pass.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Guard includes of termios.h with #ifdef HAVE_TERMIOS_H.
Test for termios.h in scons, and define/undefine HAVE_TERMIOS_H accordingly.
Fixes the below error seen on cygwin, which lacks termios.h:
In file included from gpsutils.c:22:0:
gpsd.h:349:21: fatal error: termios.h: No such file or directory
#include <termios.h>
^
|
| |
|
|
|
| |
Turned up a bug in where a counter was incremented un the Navcom driver;
this required one test rebuild.
|
| |
|
|
| |
This change doesn't affect generated binary code.
|
| |
|
|
|
|
| |
Don't use constant/expression from an array's definition when referring
to its size. Eliminates redundancy and avoids problems when array size
changes. The change doesn't affect generated code.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
gps2udp.c: In function 'send_udp':
gps2udp.c:117:19: warning: passing argument 5 of 'sendto' from
incompatible pointer type
ssize_t status = sendto(sock[channel],
^
In file included from gps2udp.c:38:0:
/usr/include/sys/socket.h:38:11: note: expected 'const struct sockaddr
*' but argument is of type 'struct sockaddr_in *'
ssize_t sendto (int, const void *, size_t __len, int __flags,
^
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
This came up in connection with Android. According to SuS this shouln't be
necessary if sys/time.h was included, but oh well. While we;re at it, rearrange
some includes for more consistent order.
All regression tests pass.
|
| | |
|
| |
|
|
|
|
|
| |
Found by: Ferry Huberts <mailings@hupie.com>
atoi() never returns errno set, yet errno was tested for.
strtol() does set errno, and does other checks.
|
| |
|
|
| |
From: Ferry Huberts <mailings@hupie.com>
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
Signed-off-by: Eric S. Raymond <esr@thyrsus.com>
|
| |
|
|
| |
Signed-off-by: Eric S. Raymond <esr@thyrsus.com>
|
| |
|
|
|
|
| |
Coverity found a potential overrun bug.
All regression tests pass. PPS is live.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
|
|
Signed-off-by: Eric S. Raymond <esr@thyrsus.com>
|
