summaryrefslogtreecommitdiff
path: root/libgps_dbus.c
Commit message (Collapse)AuthorAgeFilesLines
* libgps_dbus: Fix compiler warning of DBusHandlerResult signal_handler()Gary E. Miller2018-09-111-1/+2
| | | | Missing, unused, 3rd parameter.
* dbus timeout parameter is in milliseconds.Robert Norris2017-03-041-1/+1
| | | | | | | | | | | | | | | | The value passed into gps_mainloop() and thuis gps_dbus_mainloop() is in microseconds. Thus to convert from microseconds to milliseconds, one needs to divide by 1000 (not multiply!). This also prevents the timeout value overflowing, when a large value timeout is passed in. NB This timeout value appears not to be actually used by current versions of dbus, see this bug: https://bugs.freedesktop.org/show_bug.cgi?id=100062 Signed-off-by: Fred Wright <fw@fwright.net>
* Shift libgps_dbus inclusion of syslog.h only if dbus is being used.Rob Norris2016-03-071-1/+1
| | | | | This can simplify the build of libgps on all platforms, otherwise detection of syslog capability and further #ifdef clauses around syslog usage would be required.
* Ensure memory is freed in gps library client on dbus failures.Rob Norris2016-03-051-0/+4
| | | | Signed-off-by: Jon Schlueter <jon.schlueter@gmail.com>
* Retire splint from our set of static analyzers.Eric S. Raymond2015-03-301-4/+2
| | | | | | | | | | | | | | | | | | | The proximate cause was that we've been seing emission of error messages that were randomly and disturbingly variable across different environments - notably Raspbian and Gentoo splint gave nontrivially different results than Ubuntu 14.10 splint. And this was *not* due to Ubuntu patches! A pristine splint built from the 3.1.2 tarball on Ubuntu didn't match the Raspbian and Gentoo results either. But this has been coming for a while. Easy access to more modern static analyzers such as coverity, scan-build and cppcheck has been decreasing the utility of splint, which is unmaintained and somewhat buggy and not easy to use. Only file not cleaned is ppsthread.c, because Gary has been working on it during this cleanup. All regression tests pass. PPS observed live on GR601-W.
* Implement POSIX clock_gettime(3) for systems that lack it (like Mac OS X).Eric S. Raymond2015-03-011-1/+0
| | | | | | | On Mac OS X it will get proper nanosecond precision; elsewhere, only microseconds. Hides the conformance failure from the rest of the code. All regression tests pass.
* Fix minor build failure due to moving definition of UNUSED.Eric S. Raymond2015-02-261-0/+1
| | | | | All regression tests pass.
* Fixed incorrect string argument to dbus_message_get_args().Andrey Mazo2013-09-261-1/+1
| | | | | | | | | | | | | | | | | | | | Existing behavior leads to unexpected results because it's actually something like static char gpsd_devname[BUFSIZ]; ... *((char**)&gpsd_devname) = "qqq"; which actually stores address of "qqq" in first several bytes of gpsd_devname[] (at least with gcc and clang). DBus documentation on dbus_message_get_args() [1] states that "The variable argument list should contain the type of the argument followed by a pointer to where the value should be stored." ".. the returned values are constant; do not free them. They point into the DBusMessage." [1] http://dbus.freedesktop.org/doc/api/html/group__DBusMessage.html#gad8953f53ceea7de81cde792e3edd0230 Signed-off-by: Andrey Mazo <mazo@telum.ru>
* Nuke trailing whitespace in C source.Eric S. Raymond2012-09-071-1/+1
|
* Use UNUSED rather than uselessly setting a parameter, which triggers a ↵ukyg9e5r6k7gubiekd62012-09-071-4/+1
| | | | | | compiler warning. Signed-off-by: Eric S. Raymond <esr@thyrsus.com>
* Remove a dependency on the Gnome libraries.Eric S. Raymond2011-10-031-11/+4
|
* Remove duplicate code.Michael Tatarinov2011-09-301-1/+0
| | | | Signed-off-by: Eric S. Raymond <esr@thyrsus.com>
* Magic-number elimination.Eric S. Raymond2011-09-301-2/+2
| | | | All three exports work.
* Re-do runtime dispatch in the client library.Eric S. Raymond2011-09-301-2/+5
|
* Runtime dispatch to methods is working in the client library.Eric S. Raymond2011-09-281-1/+1
|
* Avoid a name collision.Eric S. Raymond2011-09-281-2/+2
|
* First step in runtime export dispatch for the client library.Eric S. Raymond2011-09-281-0/+2
|
* Repair compilation of DBUS + Qt.Eric S. Raymond2011-09-281-0/+1
|
* Get back to a state where the shm export works.Eric S. Raymond2011-09-271-2/+2
|
* Converge the library APIs for different transports more closely.Eric S. Raymond2011-09-271-2/+2
|
* More refactoring.Eric S. Raymond2011-09-271-10/+6
| | | | | gpxlogger currently works with socket and DBUS methods but fails with a segfault in the shm code.
* More refactoring. Bring DBUS API closer to the generic one.Eric S. Raymond2011-09-271-26/+44
|
* Refactoring step and minor fixes.Eric S. Raymond2011-09-271-3/+2
|
* Remove incorrect comment.Eric S. Raymond2011-09-271-1/+0
|
* Belated commit of new file created by gpxlogger refactoring.Eric S. Raymond2011-09-271-0/+133