| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Missing, unused, 3rd parameter.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The value passed into gps_mainloop() and thuis gps_dbus_mainloop()
is in microseconds.
Thus to convert from microseconds to milliseconds, one needs to divide by
1000 (not multiply!).
This also prevents the timeout value overflowing, when a large value
timeout is passed in.
NB This timeout value appears not to be actually used by current versions
of dbus, see this bug: https://bugs.freedesktop.org/show_bug.cgi?id=100062
Signed-off-by: Fred Wright <fw@fwright.net>
|
|
|
|
|
| |
This can simplify the build of libgps on all platforms,
otherwise detection of syslog capability and further #ifdef clauses around syslog usage would be required.
|
|
|
|
| |
Signed-off-by: Jon Schlueter <jon.schlueter@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The proximate cause was that we've been seing emission of error
messages that were randomly and disturbingly variable across different
environments - notably Raspbian and Gentoo splint gave nontrivially
different results than Ubuntu 14.10 splint. And this was *not* due to
Ubuntu patches! A pristine splint built from the 3.1.2 tarball on
Ubuntu didn't match the Raspbian and Gentoo results either.
But this has been coming for a while. Easy access to more modern
static analyzers such as coverity, scan-build and cppcheck has been
decreasing the utility of splint, which is unmaintained and somewhat
buggy and not easy to use.
Only file not cleaned is ppsthread.c, because Gary has been working
on it during this cleanup.
All regression tests pass. PPS observed live on GR601-W.
|
|
|
|
|
|
|
| |
On Mac OS X it will get proper nanosecond precision; elsewhere, only
microseconds. Hides the conformance failure from the rest of the code.
All regression tests pass.
|
|
|
|
|
| |
All regression tests pass.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Existing behavior leads to unexpected results because it's actually
something like
static char gpsd_devname[BUFSIZ];
...
*((char**)&gpsd_devname) = "qqq";
which actually stores address of "qqq" in first several bytes of gpsd_devname[] (at least with gcc and clang).
DBus documentation on dbus_message_get_args() [1] states that
"The variable argument list should contain the type of the argument
followed by a pointer to where the value should be stored."
".. the returned values are constant; do not free them. They point into
the DBusMessage."
[1] http://dbus.freedesktop.org/doc/api/html/group__DBusMessage.html#gad8953f53ceea7de81cde792e3edd0230
Signed-off-by: Andrey Mazo <mazo@telum.ru>
|
| |
|
|
|
|
|
|
| |
compiler warning.
Signed-off-by: Eric S. Raymond <esr@thyrsus.com>
|
| |
|
|
|
|
| |
Signed-off-by: Eric S. Raymond <esr@thyrsus.com>
|
|
|
|
| |
All three exports work.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
gpxlogger currently works with socket and DBUS methods but fails with
a segfault in the shm code.
|
| |
|
| |
|
| |
|
|
|