| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
reset...PRIVATE(gpsdata)->tick
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
Thus remove the 'UNUSED' compiler hint.
TESTED:
Still compiles without any complaints
Signed-off-by: Fred Wright <fw@fwright.net>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This creates a header for os_compat.c, and moves the related
prototypes into it from gpsd_config.h (as created by SConstruct),
after adding references to it to gpsd.h (via gpsd.h-tail) and a few
other sources that need it but don't include gpsd.h.
It also removes includes of <time.h> in the places where they were
only needed for the code now removed from gpsd_config.h.
TESTED:
Ran "scons build-all check" on OSX 10.9 (with strlcat/strlcpy but no
clock_gettime), OSX 10.12 (with strlcat/strlcpy and clock_gettime),
and Ubuntu 14 (with clock_gettime but no strlcat/strlcpy). Also
verified that fallback versions were not being included where
unnecessary.
|
|
|
|
| |
XOPEN_SOURCE 500 means X/Open 1995. Seems saef enough.
|
|
|
|
|
|
|
|
| |
In file included from libgps_shm.c:27:0:
/usr/include/sys/ipc.h:24:3: warning: #warning "Files using this header
must be compiled with _GNU_SOURCE or _XOPEN_SOURCE" [-Wcpp]
# warning "Files using this header must be compiled with _GNU_SOURCE or
_XOPEN_S
|
|
|
|
|
|
|
|
| |
unsuccessful gps_shm_open()
Check that the structure exists before trying to use a component of it.
Signed-off-by: Gary E. Miller <gem@rellim.com>
|
|
|
|
|
|
|
|
| |
privdata must be explicitly set to NULL after use,
otherwise if gps_close() is (incorrectly) called again before
a new gps_open() then a double free condition can occur.
Signed-off-by: Gary E. Miller <gem@rellim.com>
|
| |
|
| |
|
|
|
|
| |
Fix due to Simon Hradecky <shradecky@nomissoft.com>.
|
| |
|
|
|
|
| |
The code was checking "privdata" pointer instead of shmat() result.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit d1965788249d7e22cdde4021d452cf0dc6c6b9bd.
This breaks my build on Gentoo running gcc 4.9.2
libgps_shm.c: In function 'int gps_shm_read(gps_data_t*)':
libgps_shm.c:122:12: error: no match for 'operator=' (operand types are
'gps_data_t' and 'volatile gps_data_t')
noclobber = shared->gpsdata;
^
libgps_shm.c:122:12: note: candidate is:
In file included from gpsd.h:350:0,
from libgps_shm.c:30:
gps.h:1918:8: note: gps_data_t& gps_data_t::operator=(const gps_data_t&)
struct gps_data_t {
^
gps.h:1918:8: note: no known conversion for argument 1 from 'volatile
gps_data_t' to 'const gps_data_t&'
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The proximate cause was that we've been seing emission of error
messages that were randomly and disturbingly variable across different
environments - notably Raspbian and Gentoo splint gave nontrivially
different results than Ubuntu 14.10 splint. And this was *not* due to
Ubuntu patches! A pristine splint built from the 3.1.2 tarball on
Ubuntu didn't match the Raspbian and Gentoo results either.
But this has been coming for a while. Easy access to more modern
static analyzers such as coverity, scan-build and cppcheck has been
decreasing the utility of splint, which is unmaintained and somewhat
buggy and not easy to use.
Only file not cleaned is ppsthread.c, because Gary has been working
on it during this cleanup.
All regression tests pass. PPS observed live on GR601-W.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
JSON wait was in uSec, but SHM wait was in Sec. Made both uSec
and documented three places.
|
|
|
|
|
|
| |
gpsd_config.h needs time_t which is in time.h
OS X builds now. Untested.
|
|
|
|
|
|
| |
Also, make sure it reurns false on timeout.
All regression tests pass.
|
| |
|
|
|
|
|
|
| |
Also, ensure this always happens within the regression-test driver.
All regression tests pass.
|
|
|
|
| |
All regression tests pass.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
Also, fix how configuratuin in libgps_shm.c and smexport.h is handled.
Based on a patch by Samuel Cuella <samuel.cuella@supinfo.com>, but cleaned
up some to obey local conventions better.
All regression tests pass.
|
| |
|
| |
|
|
|
|
| |
This has been broken for two years and nobody noticed!
|
| |
|
| |
|
|
|
|
| |
Timeout argument is presently ignored.
|
|
|
|
| |
Signed-off-by: Eric S. Raymond <esr@thyrsus.com>
|
|
|
|
| |
All three exports work.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
All regression tests pass. All three exports work in gpxlogger.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|