From 133b508f1fa8a6bdaae78d1a75a2eff8dcacf426 Mon Sep 17 00:00:00 2001 From: "Eric S. Raymond" Date: Sun, 24 Jan 2016 14:57:18 -0500 Subject: Fix very minor bugs revealed by OWASP analysis. --- drivers.c | 1 + lcdgps.c | 1 + test_geoid.c | 8 ++++---- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers.c b/drivers.c index 5834bced..0ce47e8d 100644 --- a/drivers.c +++ b/drivers.c @@ -1251,6 +1251,7 @@ static bool aivdm_decode(const char *buf, size_t buflen, "ignoring bogus AIS channel '12'.\n"); return false; } + /* fall through */ case 'A': ais_context = &session->driver.aivdm.context[0]; session->driver.aivdm.ais_channel ='A'; diff --git a/lcdgps.c b/lcdgps.c index b346951f..910f38da 100644 --- a/lcdgps.c +++ b/lcdgps.c @@ -304,6 +304,7 @@ int main(int argc, char *argv[]) default: (void)fprintf(stderr, "Unknown -l argument: %s\n", optarg); } + break; case 's': sleep(10); continue; diff --git a/test_geoid.c b/test_geoid.c index 7c349010..8f0480af 100644 --- a/test_geoid.c +++ b/test_geoid.c @@ -22,13 +22,13 @@ int main(int argc, char **argv) lat = atof(argv[1]); lon = atof(argv[2]); - if (lat > 90. || lat < -90.) { - fprintf(stderr, " -90 <= lat=%s(%.f) <= 90 ?\n", argv[1], lat); + if (lon > 180.0 || lat < -180.0) { + fprintf(stderr, " -180 <= lon=%s(%.f) <= 180 ?\n", argv[2], lon); return 1; } - if (lon > 180. || lat < -180.) { - fprintf(stderr, " -180 <= lon=%s(%.f) <= 180 ?\n", argv[2], lon); + if (lat > 90.0 || lat < -90.0) { + fprintf(stderr, " -90 <= lat=%s(%.f) <= 90 ?\n", argv[1], lat); return 1; } -- cgit v1.2.1