From d17e6edd5d13490da6fc3edf8e032801d8380b50 Mon Sep 17 00:00:00 2001 From: "Eric S. Raymond" Date: Wed, 6 Sep 2017 20:47:40 -0400 Subject: Revert a previous change to suppress cppcheck warning... ...that breaks the build on some platforms. --- driver_garmin.c | 3 ++- driver_garmin_txt.c | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/driver_garmin.c b/driver_garmin.c index 46d3d0ad..3b17a84a 100644 --- a/driver_garmin.c +++ b/driver_garmin.c @@ -236,7 +236,8 @@ typedef struct __attribute__((__packed__)) union { //int8_t chars[MAX_BUFFER_SIZE]; - //uint8_t uchars[MAX_BUFFER_SIZE]; + // cppcheck-suppress unusedStructMember + uint8_t uchars[MAX_BUFFER_SIZE]; cpo_pvt_data pvt; cpo_sat_data sats; } mData; diff --git a/driver_garmin_txt.c b/driver_garmin_txt.c index c14c5161..e8e878a2 100644 --- a/driver_garmin_txt.c +++ b/driver_garmin_txt.c @@ -172,6 +172,7 @@ static int gar_decode(const struct gps_context_t *context, } /* second character in prefix is flag for negative number */ if (preflen >= 2) { + // cppcheck-suppress arrayIndexOutOfBounds if (buf[0] == prefix[1]) { sign = -1.0; break; -- cgit v1.2.1