From 1a61f70b5daed5996fff4738ce41101af943003b Mon Sep 17 00:00:00 2001 From: "Eric S. Raymond" Date: Mon, 30 Mar 2015 18:28:23 -0400 Subject: Write scan-build suppressions to it runs clean. Promote scan-build to be onere of the stock pre-release checks. Fix one minor cppcheck nit. --- contrib/motosend.c | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) (limited to 'contrib/motosend.c') diff --git a/contrib/motosend.c b/contrib/motosend.c index 05c73530..30731588 100644 --- a/contrib/motosend.c +++ b/contrib/motosend.c @@ -168,19 +168,21 @@ char *gpsd_hexdump(char *binbuf, size_t binbuflen) int gpsd_hexpack(char *src, char *dst, int len) { - int i, l, k; + int i, l; - l = (int)(strlen(src) / 2); - if ((l < 1) || (l > len)) - return -1; + l = (int)(strlen(src) / 2); + if ((l < 1) || (l > len)) + return -1; - bzero(dst, len); - for (i = 0; i < l; i++) - if ((k = hex2bin(src+i*2)) != -1) - dst[i] = (char)(k & 0xff); - else - return -1; - return l; + bzero(dst, len); + for (i = 0; i < l; i++) { + int k; + if ((k = hex2bin(src+i*2)) != -1) + dst[i] = (char)(k & 0xff); + else + return -1; + } + return l; } int hex2bin(char *s) -- cgit v1.2.1