From a0ce32af15add094f888efb3f1b8ee33d7baa990 Mon Sep 17 00:00:00 2001 From: "Eric S. Raymond" Date: Tue, 29 Mar 2011 11:13:59 -0400 Subject: scan-build cleanup. All regression tests pass, code splints clean. --- driver_evermore.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'driver_evermore.c') diff --git a/driver_evermore.c b/driver_evermore.c index a8534d75..729583ff 100644 --- a/driver_evermore.c +++ b/driver_evermore.c @@ -154,7 +154,6 @@ gps_mask_t evermore_parse(struct gps_device_t * session, unsigned char *buf, /* time to unstuff it and discard the header and footer */ cp = buf + 2; - tp = buf2; if (*cp == 0x10) cp++; datalen = (size_t) * cp++; @@ -165,17 +164,14 @@ gps_mask_t evermore_parse(struct gps_device_t * session, unsigned char *buf, datalen -= 2; /*@ -usedef @*/ + buf2[0] = '\0'; /* prevent 'Assigned value is garbage or undefined' from scan-build */ + tp = buf2; for (i = 0; i < (size_t) datalen; i++) { *tp = *cp++; if (*tp == 0x10) cp++; tp++; } - - /* bail out if no payload (scan-build throws spurious error otherwise) */ - if (tp <= buf2) - return 0; - type = (unsigned char)getub(buf2, 1); /*@ +usedef @*/ -- cgit v1.2.1