From 28bf37132d86cc59320e21d843960d086cef664c Mon Sep 17 00:00:00 2001
From: "Eric S. Raymond" <esr@thyrsus.com>
Date: Mon, 30 Mar 2015 17:10:53 -0400
Subject: Retire splint from our set of static analyzers.

The proximate cause was that we've been seing emission of error
messages that were randomly and disturbingly variable across different
environments - notably Raspbian and Gentoo splint gave nontrivially
different results than Ubuntu 14.10 splint. And this was *not* due to
Ubuntu patches!  A pristine splint built from the 3.1.2 tarball on
Ubuntu didn't match the Raspbian and Gentoo results either.

But this has been coming for a while.  Easy access to more modern
static analyzers such as coverity, scan-build and cppcheck has been
decreasing the utility of splint, which is unmaintained  and somewhat
buggy and not easy to use.

Only file not cleaned is ppsthread.c, because Gary has been working
on it during this cleanup.

All regression tests pass. PPS observed live on GR601-W.
---
 gpsdctl.c | 8 --------
 1 file changed, 8 deletions(-)

(limited to 'gpsdctl.c')

diff --git a/gpsdctl.c b/gpsdctl.c
index 017dd1c9..21d27e44 100644
--- a/gpsdctl.c
+++ b/gpsdctl.c
@@ -7,17 +7,13 @@
 #include <string.h>
 #include <fcntl.h>
 #include <sys/stat.h>
-#ifndef S_SPLINT_S
 #include <unistd.h>
-#endif /* S_SPLINT_S */
 #include <syslog.h>
 #include <stdbool.h>
 #include <stdlib.h>
 #include <stdio.h>
 #include <assert.h>
-#ifndef S_SPLINT_S
 #include <sys/socket.h>
-#endif /* S_SPLINT_S */
 
 #include "gpsd.h"
 
@@ -62,7 +58,6 @@ static int gpsd_control(char *action, char *argument)
      * gpsd.c. Be careful about keeping them in sync, or hotplugging
      * will have mysterious failures.
      */
-    /*@ -sefparams @*/
     if (strcmp(action, "add") == 0) {
 	/*
 	 * Force the group-read & group-write bits on, so gpsd will still be
@@ -84,7 +79,6 @@ static int gpsd_control(char *action, char *argument)
 	(void)syslog(LOG_ERR, "unknown action \"%s\"", action);
 	status = -1;
     }
-    /*@ +sefparams @*/
     (void)close(connect);
     //syslog(LOG_DEBUG, "gpsd_control ends");
     return status;
@@ -97,7 +91,6 @@ int main(int argc, char *argv[])
 	(void)syslog(LOG_ERR, "requires action and argument (%d)", argc);
 	exit(EXIT_FAILURE);
     } else {
-	/*@-observertrans@*/
 	char *sockenv = getenv("GPSD_SOCKET");
 	char *optenv = getenv("GPSD_OPTIONS");
 
@@ -113,6 +106,5 @@ int main(int argc, char *argv[])
 	    exit(EXIT_FAILURE);
 	else
 	    exit(EXIT_SUCCESS);
-	/*@+observertrans@*/
     }
 }
-- 
cgit v1.2.1