From 6ee9556f2fea231303a488f07a8b0e0a9f552dc4 Mon Sep 17 00:00:00 2001 From: "Eric S. Raymond" Date: Sat, 31 Jan 2015 15:16:55 -0500 Subject: Back out the attempt to use VTIME. According to Matthias Drochner at http://lists.lysator.liu.se/pipermail/lsh-bugs/2003q4/000151.html: I thought I'd give lsh a try, just to see how it compares to openssh... The client didn't work well on NetBSD, got a message like "unexpected EWOULDBLOCK" on each keystroke. Looked a bit deeper and found that stdin is set to O_NONBLOCK and a raw tty mode with c_cc[VMIN] > 1 and c_cc[VTIME] > 0. I'll append a little test program which does the same. I've tried it on 3 operating systems (Linux, NetBSD, Digital UNIX), and it behaves differently on each: -on Linux, if a key is pressed, the read returns immediately with that one character -on NetBSD, the read returns with no data but EWOULDBLOCK -on D'UNIX, the poll() doesn't teturn before 4 keypresses are done; the read() returns these 4 characters Indeed, in SUSv2's termios page is a sentence which says that if both O_NONBLOCK and VTIME>0 are set, the behaviour is more or less undefined. I've solved my immediate problems by setting VMIN to 1 instead of 4 in unix_interact.c:do_make_raw(), but VTIME is still pointless, so I wouldn't call this a clean solution. All regression tests pass. --- gpsdecode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'gpsdecode.c') diff --git a/gpsdecode.c b/gpsdecode.c index ece81d57..f31a59f6 100644 --- a/gpsdecode.c +++ b/gpsdecode.c @@ -621,7 +621,7 @@ static void decode(FILE *fpin, FILE*fpout) break; } } - printf("%s (%d): %u\n", np, i-1, (unsigned int)minima[i]); + printf("%s (%d): %d\n", np, i-1, (unsigned int)minima[i]); } } } -- cgit v1.2.1