From fccb36a8cc93990b22e0c4bdbd264e4d3a885e5d Mon Sep 17 00:00:00 2001
From: "Eric S. Raymond" <esr@thyrsus.com>
Date: Tue, 15 Jan 2013 06:52:23 -0500
Subject: Do *not* clear DOPs every time a satellite picture comes from the
 receiver.

Required a regression-test rebuild.

The immediate reason for this was Savannah bug bug #37810:
satellites_used always zero via gpsd socket with multi nmea GSA/GSV. As the
user reporting said:

The "satellites_used" field in a "struct gps_data_t" filled in by
"gps_read" is always returning zero.

This module emits GNGSA messages in a group of three. My information
is that the first GNGSA pertains to GPS, second to GLONASS, third to
QZSS. It also emits GSV messages using talker id's GL,GP,QZ.

The larger point is that DOPs are likely to be valid for longer than
a GSV reporting cycle; they change only slowly as the actual sat
configuration does.  So it makes sense to retain them.
---
 test/daemon/polarx2.log.chk | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

(limited to 'test/daemon/polarx2.log.chk')

diff --git a/test/daemon/polarx2.log.chk b/test/daemon/polarx2.log.chk
index 67cac327..846ea0c3 100644
--- a/test/daemon/polarx2.log.chk
+++ b/test/daemon/polarx2.log.chk
@@ -18,7 +18,7 @@ $GPGSV,5,2,17,08,22,167,,10,65,329,44,13,62,040,44,17,06,199,*79
 $GPGSV,5,3,17,20,11,098,,23,31,049,45,33,45,190,,35,26,238,*77
 $GPGSV,5,4,17,37,16,112,,39,33,133,,44,04,101,,49,33,133,*7C
 $GPGSV,5,5,17,50,45,190,*43
-{"class":"SKY","tag":"GSV","satellites":[{"PRN":2,"el":46,"az":305,"ss":0,"used":false},{"PRN":4,"el":74,"az":240,"ss":0,"used":false},{"PRN":5,"el":14,"az":290,"ss":0,"used":false},{"PRN":7,"el":46,"az":134,"ss":0,"used":false},{"PRN":8,"el":22,"az":167,"ss":0,"used":false},{"PRN":10,"el":65,"az":329,"ss":44,"used":true},{"PRN":13,"el":62,"az":40,"ss":44,"used":true},{"PRN":17,"el":6,"az":199,"ss":0,"used":false},{"PRN":20,"el":11,"az":98,"ss":0,"used":false},{"PRN":23,"el":31,"az":49,"ss":45,"used":true},{"PRN":120,"el":45,"az":190,"ss":0,"used":false},{"PRN":122,"el":26,"az":238,"ss":0,"used":false},{"PRN":124,"el":16,"az":112,"ss":0,"used":false},{"PRN":126,"el":33,"az":133,"ss":0,"used":false},{"PRN":131,"el":4,"az":101,"ss":0,"used":false},{"PRN":136,"el":33,"az":133,"ss":0,"used":false},{"PRN":137,"el":45,"az":190,"ss":0,"used":false}]}
+{"class":"SKY","tag":"GSV","vdop":0.00,"hdop":10.50,"pdop":10.50,"satellites":[{"PRN":2,"el":46,"az":305,"ss":0,"used":false},{"PRN":4,"el":74,"az":240,"ss":0,"used":false},{"PRN":5,"el":14,"az":290,"ss":0,"used":false},{"PRN":7,"el":46,"az":134,"ss":0,"used":false},{"PRN":8,"el":22,"az":167,"ss":0,"used":false},{"PRN":10,"el":65,"az":329,"ss":44,"used":true},{"PRN":13,"el":62,"az":40,"ss":44,"used":true},{"PRN":17,"el":6,"az":199,"ss":0,"used":false},{"PRN":20,"el":11,"az":98,"ss":0,"used":false},{"PRN":23,"el":31,"az":49,"ss":45,"used":true},{"PRN":120,"el":45,"az":190,"ss":0,"used":false},{"PRN":122,"el":26,"az":238,"ss":0,"used":false},{"PRN":124,"el":16,"az":112,"ss":0,"used":false},{"PRN":126,"el":33,"az":133,"ss":0,"used":false},{"PRN":131,"el":4,"az":101,"ss":0,"used":false},{"PRN":136,"el":33,"az":133,"ss":0,"used":false},{"PRN":137,"el":45,"az":190,"ss":0,"used":false}]}
 $GPGST,112258.00,0.223,320.494,3.861,1.782,320.339,10.685,182.631*6C
 {"class":"GST","tag":"GST","time":"1970-01-02T07:10:58.000Z","rms":0.223,"major":320.494,"minor":3.861,"orient":1.782,"lat":320.339,"lon":10.685,"alt":182.631}
 $GPGBS,112258.00,155.875,14.949,71.523,13,0.000,0.000,0.000*68
@@ -36,7 +36,7 @@ $GPGSV,5,2,17,08,22,167,,10,65,329,44,13,62,040,44,17,06,199,*79
 $GPGSV,5,3,17,20,11,098,,23,31,049,44,33,45,190,,35,26,238,*76
 $GPGSV,5,4,17,37,16,112,,39,33,133,,44,04,101,,49,33,133,*7C
 $GPGSV,5,5,17,50,45,190,*43
-{"class":"SKY","tag":"GSV","satellites":[{"PRN":2,"el":46,"az":305,"ss":0,"used":false},{"PRN":4,"el":74,"az":240,"ss":0,"used":false},{"PRN":5,"el":14,"az":290,"ss":0,"used":false},{"PRN":7,"el":46,"az":134,"ss":0,"used":false},{"PRN":8,"el":22,"az":167,"ss":0,"used":false},{"PRN":10,"el":65,"az":329,"ss":44,"used":true},{"PRN":13,"el":62,"az":40,"ss":44,"used":true},{"PRN":17,"el":6,"az":199,"ss":0,"used":false},{"PRN":20,"el":11,"az":98,"ss":0,"used":false},{"PRN":23,"el":31,"az":49,"ss":44,"used":true},{"PRN":120,"el":45,"az":190,"ss":0,"used":false},{"PRN":122,"el":26,"az":238,"ss":0,"used":false},{"PRN":124,"el":16,"az":112,"ss":0,"used":false},{"PRN":126,"el":33,"az":133,"ss":0,"used":false},{"PRN":131,"el":4,"az":101,"ss":0,"used":false},{"PRN":136,"el":33,"az":133,"ss":0,"used":false},{"PRN":137,"el":45,"az":190,"ss":0,"used":false}]}
+{"class":"SKY","tag":"GSV","vdop":0.00,"hdop":10.50,"pdop":10.50,"satellites":[{"PRN":2,"el":46,"az":305,"ss":0,"used":false},{"PRN":4,"el":74,"az":240,"ss":0,"used":false},{"PRN":5,"el":14,"az":290,"ss":0,"used":false},{"PRN":7,"el":46,"az":134,"ss":0,"used":false},{"PRN":8,"el":22,"az":167,"ss":0,"used":false},{"PRN":10,"el":65,"az":329,"ss":44,"used":true},{"PRN":13,"el":62,"az":40,"ss":44,"used":true},{"PRN":17,"el":6,"az":199,"ss":0,"used":false},{"PRN":20,"el":11,"az":98,"ss":0,"used":false},{"PRN":23,"el":31,"az":49,"ss":44,"used":true},{"PRN":120,"el":45,"az":190,"ss":0,"used":false},{"PRN":122,"el":26,"az":238,"ss":0,"used":false},{"PRN":124,"el":16,"az":112,"ss":0,"used":false},{"PRN":126,"el":33,"az":133,"ss":0,"used":false},{"PRN":131,"el":4,"az":101,"ss":0,"used":false},{"PRN":136,"el":33,"az":133,"ss":0,"used":false},{"PRN":137,"el":45,"az":190,"ss":0,"used":false}]}
 $GPGST,112259.00,0.374,324.240,3.859,1.775,324.084,10.757,184.716*6B
 {"class":"GST","tag":"GST","time":"1970-01-02T07:10:59.000Z","rms":0.374,"major":324.240,"minor":3.859,"orient":1.775,"lat":324.084,"lon":10.757,"alt":184.716}
 $GPGBS,112259.00,98.761,11.743,50.103,13,0.000,0.000,0.000*57
@@ -54,7 +54,7 @@ $GPGSV,5,2,17,08,22,167,,10,65,329,44,13,62,040,43,17,06,199,*7E
 $GPGSV,5,3,17,20,11,098,,23,31,049,44,33,45,190,,35,26,238,*76
 $GPGSV,5,4,17,37,16,112,,39,33,133,,44,04,101,,49,33,133,*7C
 $GPGSV,5,5,17,50,45,190,*43
-{"class":"SKY","tag":"GSV","satellites":[{"PRN":2,"el":46,"az":305,"ss":0,"used":false},{"PRN":4,"el":74,"az":240,"ss":0,"used":false},{"PRN":5,"el":14,"az":290,"ss":0,"used":false},{"PRN":7,"el":46,"az":134,"ss":0,"used":false},{"PRN":8,"el":22,"az":167,"ss":0,"used":false},{"PRN":10,"el":65,"az":329,"ss":44,"used":true},{"PRN":13,"el":62,"az":40,"ss":43,"used":true},{"PRN":17,"el":6,"az":199,"ss":0,"used":false},{"PRN":20,"el":11,"az":98,"ss":0,"used":false},{"PRN":23,"el":31,"az":49,"ss":44,"used":true},{"PRN":120,"el":45,"az":190,"ss":0,"used":false},{"PRN":122,"el":26,"az":238,"ss":0,"used":false},{"PRN":124,"el":16,"az":112,"ss":0,"used":false},{"PRN":126,"el":33,"az":133,"ss":0,"used":false},{"PRN":131,"el":4,"az":101,"ss":0,"used":false},{"PRN":136,"el":33,"az":133,"ss":0,"used":false},{"PRN":137,"el":45,"az":190,"ss":0,"used":false}]}
+{"class":"SKY","tag":"GSV","vdop":0.00,"hdop":10.50,"pdop":10.50,"satellites":[{"PRN":2,"el":46,"az":305,"ss":0,"used":false},{"PRN":4,"el":74,"az":240,"ss":0,"used":false},{"PRN":5,"el":14,"az":290,"ss":0,"used":false},{"PRN":7,"el":46,"az":134,"ss":0,"used":false},{"PRN":8,"el":22,"az":167,"ss":0,"used":false},{"PRN":10,"el":65,"az":329,"ss":44,"used":true},{"PRN":13,"el":62,"az":40,"ss":43,"used":true},{"PRN":17,"el":6,"az":199,"ss":0,"used":false},{"PRN":20,"el":11,"az":98,"ss":0,"used":false},{"PRN":23,"el":31,"az":49,"ss":44,"used":true},{"PRN":120,"el":45,"az":190,"ss":0,"used":false},{"PRN":122,"el":26,"az":238,"ss":0,"used":false},{"PRN":124,"el":16,"az":112,"ss":0,"used":false},{"PRN":126,"el":33,"az":133,"ss":0,"used":false},{"PRN":131,"el":4,"az":101,"ss":0,"used":false},{"PRN":136,"el":33,"az":133,"ss":0,"used":false},{"PRN":137,"el":45,"az":190,"ss":0,"used":false}]}
 $GPGST,112300.00,0.593,328.088,3.859,1.768,327.932,10.833,186.824*69
 {"class":"GST","tag":"GST","time":"1970-01-02T07:11:40.000Z","rms":0.593,"major":328.088,"minor":3.859,"orient":1.768,"lat":327.932,"lon":10.833,"alt":186.824}
 $GPGBS,112300.00,76.953,10.529,42.020,13,0.000,0.000,0.000*59
@@ -72,7 +72,7 @@ $GPGSV,5,2,17,08,22,167,,10,65,329,44,13,62,040,43,17,06,199,*7E
 $GPGSV,5,3,17,20,11,098,,23,31,049,44,33,45,190,,35,26,238,*76
 $GPGSV,5,4,17,37,16,112,,39,33,133,,44,04,101,,49,33,133,*7C
 $GPGSV,5,5,17,50,45,190,*43
-{"class":"SKY","tag":"GSV","satellites":[{"PRN":2,"el":46,"az":305,"ss":0,"used":false},{"PRN":4,"el":74,"az":240,"ss":0,"used":false},{"PRN":5,"el":14,"az":290,"ss":0,"used":false},{"PRN":7,"el":46,"az":134,"ss":0,"used":false},{"PRN":8,"el":22,"az":167,"ss":0,"used":false},{"PRN":10,"el":65,"az":329,"ss":44,"used":true},{"PRN":13,"el":62,"az":40,"ss":43,"used":true},{"PRN":17,"el":6,"az":199,"ss":0,"used":false},{"PRN":20,"el":11,"az":98,"ss":0,"used":false},{"PRN":23,"el":31,"az":49,"ss":44,"used":true},{"PRN":120,"el":45,"az":190,"ss":0,"used":false},{"PRN":122,"el":26,"az":238,"ss":0,"used":false},{"PRN":124,"el":16,"az":112,"ss":0,"used":false},{"PRN":126,"el":33,"az":133,"ss":0,"used":false},{"PRN":131,"el":4,"az":101,"ss":0,"used":false},{"PRN":136,"el":33,"az":133,"ss":0,"used":false},{"PRN":137,"el":45,"az":190,"ss":0,"used":false}]}
+{"class":"SKY","tag":"GSV","vdop":0.00,"hdop":10.50,"pdop":10.50,"satellites":[{"PRN":2,"el":46,"az":305,"ss":0,"used":false},{"PRN":4,"el":74,"az":240,"ss":0,"used":false},{"PRN":5,"el":14,"az":290,"ss":0,"used":false},{"PRN":7,"el":46,"az":134,"ss":0,"used":false},{"PRN":8,"el":22,"az":167,"ss":0,"used":false},{"PRN":10,"el":65,"az":329,"ss":44,"used":true},{"PRN":13,"el":62,"az":40,"ss":43,"used":true},{"PRN":17,"el":6,"az":199,"ss":0,"used":false},{"PRN":20,"el":11,"az":98,"ss":0,"used":false},{"PRN":23,"el":31,"az":49,"ss":44,"used":true},{"PRN":120,"el":45,"az":190,"ss":0,"used":false},{"PRN":122,"el":26,"az":238,"ss":0,"used":false},{"PRN":124,"el":16,"az":112,"ss":0,"used":false},{"PRN":126,"el":33,"az":133,"ss":0,"used":false},{"PRN":131,"el":4,"az":101,"ss":0,"used":false},{"PRN":136,"el":33,"az":133,"ss":0,"used":false},{"PRN":137,"el":45,"az":190,"ss":0,"used":false}]}
 $GPGST,112301.00,0.737,331.967,3.860,1.762,331.810,10.910,188.939*61
 {"class":"GST","tag":"GST","time":"1970-01-02T07:11:41.000Z","rms":0.737,"major":331.967,"minor":3.860,"orient":1.762,"lat":331.810,"lon":10.910,"alt":188.939}
 $GPGBS,112301.00,64.299,9.828,45.570,13,0.000,0.000,0.000*65
@@ -90,4 +90,4 @@ $GPGSV,5,2,17,08,22,167,,10,65,329,43,13,62,040,43,17,06,199,*79
 $GPGSV,5,3,17,20,11,098,,23,31,049,44,33,45,190,,35,26,238,*76
 $GPGSV,5,4,17,37,16,112,,39,33,133,,44,04,101,,49,33,133,*7C
 $GPGSV,5,5,17,50,45,190,*43
-{"class":"SKY","tag":"GSV","satellites":[{"PRN":2,"el":46,"az":305,"ss":0,"used":false},{"PRN":4,"el":74,"az":240,"ss":0,"used":false},{"PRN":5,"el":14,"az":290,"ss":0,"used":false},{"PRN":7,"el":46,"az":134,"ss":0,"used":false},{"PRN":8,"el":22,"az":167,"ss":0,"used":false},{"PRN":10,"el":65,"az":329,"ss":43,"used":true},{"PRN":13,"el":62,"az":40,"ss":43,"used":true},{"PRN":17,"el":6,"az":199,"ss":0,"used":false},{"PRN":20,"el":11,"az":98,"ss":0,"used":false},{"PRN":23,"el":31,"az":49,"ss":44,"used":true},{"PRN":120,"el":45,"az":190,"ss":0,"used":false},{"PRN":122,"el":26,"az":238,"ss":0,"used":false},{"PRN":124,"el":16,"az":112,"ss":0,"used":false},{"PRN":126,"el":33,"az":133,"ss":0,"used":false},{"PRN":131,"el":4,"az":101,"ss":0,"used":false},{"PRN":136,"el":33,"az":133,"ss":0,"used":false},{"PRN":137,"el":45,"az":190,"ss":0,"used":false}]}
+{"class":"SKY","tag":"GSV","vdop":0.00,"hdop":10.50,"pdop":10.50,"satellites":[{"PRN":2,"el":46,"az":305,"ss":0,"used":false},{"PRN":4,"el":74,"az":240,"ss":0,"used":false},{"PRN":5,"el":14,"az":290,"ss":0,"used":false},{"PRN":7,"el":46,"az":134,"ss":0,"used":false},{"PRN":8,"el":22,"az":167,"ss":0,"used":false},{"PRN":10,"el":65,"az":329,"ss":43,"used":true},{"PRN":13,"el":62,"az":40,"ss":43,"used":true},{"PRN":17,"el":6,"az":199,"ss":0,"used":false},{"PRN":20,"el":11,"az":98,"ss":0,"used":false},{"PRN":23,"el":31,"az":49,"ss":44,"used":true},{"PRN":120,"el":45,"az":190,"ss":0,"used":false},{"PRN":122,"el":26,"az":238,"ss":0,"used":false},{"PRN":124,"el":16,"az":112,"ss":0,"used":false},{"PRN":126,"el":33,"az":133,"ss":0,"used":false},{"PRN":131,"el":4,"az":101,"ss":0,"used":false},{"PRN":136,"el":33,"az":133,"ss":0,"used":false},{"PRN":137,"el":45,"az":190,"ss":0,"used":false}]}
-- 
cgit v1.2.1