Inclusion order is not supposed to matter for standard C header files, so treating this as a code style issue. * src/devices/grodvi/dvi.cpp: * src/devices/grolj4/lj4.cpp: * src/include/stringclass.h: * src/libs/libbib/linear.cpp: * src/libs/libbib/search.cpp: * src/libs/libdriver/printer.cpp: * src/libs/libgroff/assert.cpp: * src/libs/libgroff/color.cpp: * src/libs/libgroff/errarg.cpp: * src/libs/libgroff/font.cpp: * src/libs/libgroff/nametoindex.cpp: * src/libs/libgroff/prime.cpp: * src/libs/libgroff/relocate.cpp: * src/libs/libgroff/searchpath.cpp: * src/preproc/eqn/box.cpp: * src/preproc/eqn/delim.cpp: * src/preproc/eqn/pile.cpp: * src/preproc/eqn/script.cpp: * src/preproc/html/pre-html.cpp: * src/preproc/pic/pic.h: * src/preproc/preconv/preconv.cpp: * src/preproc/soelim/soelim.cpp: * src/roff/groff/groff.cpp: * src/roff/troff/troff.h: * src/utils/hpftodit/hpftodit.cpp: * src/utils/indxbib/indxbib.cpp: * src/utils/lkbib/lkbib.cpp: * src/utils/lookbib/lookbib.cpp: * src/utils/tfmtodit/tfmtodit.cpp: Do it.
Switch to using system's assert.h header file. It is futile to attempt to preserve compatibility with ISO C90 systems by providing a bespoke predicate-reporting assert() (a C99 feature) when gnulib, which we require, itself demands C99. This ensures that `static_assert` remains defined so that gnulib can use it. Thanks to Bruno Haible for the consultation. <https://lists.gnu.org/archive/html/groff/2023-02/msg00034.html> * src/include/assert.h: Delete. * src/devices/grodvi/dvi.cpp: * src/devices/grolbp/lbp.cpp: * src/devices/grolj4/lj4.cpp: * src/include/itable.h: * src/include/stringclass.h: * src/libs/libbib/linear.cpp: * src/libs/libbib/search.cpp: * src/libs/libdriver/printer.cpp: * src/libs/libgroff/assert.cpp: * src/libs/libgroff/color.cpp: * src/libs/libgroff/errarg.cpp: * src/libs/libgroff/font.cpp: * src/libs/libgroff/nametoindex.cpp: * src/libs/libgroff/prime.cpp: * src/libs/libgroff/relocate.cpp: * src/libs/libgroff/searchpath.cpp: * src/preproc/eqn/box.cpp: * src/preproc/eqn/delim.cpp: * src/preproc/eqn/pile.cpp: * src/preproc/eqn/script.cpp: * src/preproc/html/pre-html.cpp: * src/preproc/pic/pic.h: * src/preproc/preconv/preconv.cpp: * src/preproc/soelim/soelim.cpp: * src/roff/groff/groff.cpp: * src/roff/troff/troff.h: * src/utils/hpftodit/hpftodit.cpp: * src/utils/indxbib/indxbib.cpp: * src/utils/lkbib/lkbib.cpp: * src/utils/lookbib/lookbib.cpp: * src/utils/tfmtodit/tfmtodit.cpp: Respell "assert.h" inclusion with angle brackets instead of quotation marks. Fixes <https://savannah.gnu.org/bugs/?63078>. * ANNOUNCE: Update bug counts.
Correct numerous typos and solecisms throughout the source tree. * ChangeLog: * ChangeLog.115: * ChangeLog.116: * ChangeLog.117: * ChangeLog.118: * ChangeLog.119: * ChangeLog.121: * ChangeLog.122: * Makefile.am: * NEWS: * PROBLEMS: * README: * contrib/chem/chem.am: * contrib/chem/chem.pl: * contrib/glilypond/README.txt: * contrib/glilypond/glilypond.pl: * contrib/hdtbl/groff_hdtbl.7.man: * contrib/mm/ChangeLog: * contrib/mm/m.tmac: * contrib/pdfmark/pdfmark.ms: * doc/automake.mom: * doc/groff.texi: * doc/me-revisions: * doc/webpage.ms: * m4/lib-link.m4: * man/groff.7.man: * man/groff_diff.7.man: * man/roff.7.man: * src/devices/grohtml/post-html.cpp: * src/devices/grolbp/lbp.h: * src/devices/gropdf/TODO: * src/devices/gropdf/gropdf.1.man: * src/devices/gropdf/gropdf.pl: * src/devices/xditview/ChangeLog: * src/devices/xditview/xditview.c: * src/libs/libdriver/input.cpp: * src/libs/libgroff/glyphuni.cpp: * src/preproc/eqn/eqn.1.man: * src/preproc/grn/gprint.h: * src/preproc/grn/main.cpp: * src/preproc/html/pre-html.cpp: * src/preproc/preconv/preconv.cpp: * src/preproc/tbl/table.cpp: * src/roff/groff/pipeline.c: * src/roff/groff/tests/substring_works.sh: * src/roff/groff/tests/use_point_size_escape_with_single_digit_arg.sh: * src/roff/troff/div.cpp: * src/roff/troff/input.cpp: * src/roff/troff/troff.1.man: * src/utils/grog/grog.pl: * src/utils/indxbib/indxbib.cpp: * src/utils/tfmtodit/tfmtodit.1.man: * tmac/doc-old.tmac: * tmac/doc.tmac: * tmac/groff_man.7.man.in: * tmac/hyphen.fr: Do it. Fixes <https://savannah.gnu.org/bugs/?63589>. Thanks to Bjarni Ingi Gislason for the report. * ANNOUNCE: Update bug counts. I also killed some pointless white space, refilled affected lines at 72 columns where convenient and non-disruptive to existing text flow, and corrected a misspelling of Ralph Corderoy's surname.
* src/libs/libdriver/input.cpp (do_file): Make use of positioning commands before the first page is started fatal errors; they suggest ill-formed input. The 'p' command clobbers the vertical position anyway. (See https://bugs.debian.org/421437 for discussion.)
Tidy up #includes of the "assert.h" header, which we locally provide to ensure a C99-conformant implementation. Drop inclusion of header from files that don't directly need it, add it where they do, and spell the inclusion consistently with double quotes to cue the reader of its local status. * src/devices/grodvi/dvi.cpp: * src/devices/grolj4/lj4.cpp: * src/libs/libdriver/printer.cpp: * src/preproc/eqn/box.cpp: * src/preproc/eqn/delim.cpp: * src/preproc/eqn/pile.cpp: * src/preproc/eqn/script.cpp: Add inclusion. * src/include/driver.h: * src/libs/libgroff/fontfile.cpp: * src/preproc/eqn/eqn.h: * src/preproc/html/pushback.cpp: * src/preproc/refer/refer.h: * src/preproc/tbl/table.h: * src/utils/addftinfo/addftinfo.cpp: Drop inclusion. * src/include/itable.h: * src/include/stringclass.h: * src/libs/libbib/linear.cpp: * src/libs/libbib/search.cpp: * src/libs/libgroff/color.cpp: * src/libs/libgroff/font.cpp: * src/libs/libgroff/nametoindex.cpp: * src/libs/libgroff/prime.cpp: * src/libs/libgroff/searchpath.cpp: * src/preproc/html/pre-html.cpp: * src/preproc/preconv/preconv.cpp: * src/preproc/soelim/soelim.cpp: * src/utils/indxbib/indxbib.cpp: * src/utils/lkbib/lkbib.cpp: * src/utils/lookbib/lookbib.cpp: Respell inclusion. Fixes <https://savannah.gnu.org/bugs/?63079>. Thanks to Bjarni Ingi Gislason for the report. Also annotate our assert.h to indicate why it's there. Also update editor aid comments and drop old style Emacs file-local variable setting.
Boolify and rename internal library function from `invalid_input_char` to `is_invalid_input_char`. * src/include/lib.h: Do it. * src/libs/libgroff/font.cpp (text_file::next_line): * src/preproc/eqn/lex.cpp (file_input::read_line): * src/preproc/eqn/main.cpp (read_line, main): * src/preproc/pic/lex.cpp (file_input::read_line, simple_file_input::get, simple_file_input::peek): * src/preproc/pic/main.cpp (top_input::get, top_input::peek, do_file): * src/preproc/refer/command.cpp (input_stack::push_file): * src/preproc/refer/refer.cpp (do_file, do_bib): * src/roff/troff/env.cpp (environment::make_tag): * src/roff/troff/input.cpp (file_iterator::fill, file_iterator::peek) (get_char_for_escape_parameter, transparent_translate, read_request) (asciify, input_char_description, read_string, transparent_file) (set_string): Update call sites.
* src/libs/libgroff/error.cpp (do_error_with_file_and_line): Trivially refactor. Use separate string constant for invariant material. (This will make it easier to, for example, store the diagnostic level strings in an array that can be indexed by their corresponding `enum` type.)
[libgroff]: Update return type of `font::load_desc` function to enable more informative diagnostics from callers. * src/include/font.h (font::load_desc): Change return type from `bool` to `const char` pointer. * src/libs/libgroff/font.cpp (font::load_desc): Return null pointer literal on failed `open()` or validation failures. Return filespec on success. * src/libs/libdriver/input.cpp (do_file): * src/preproc/grn/main.cpp (getres): * src/roff/groff/groff.cpp (main): * src/roff/troff/input.cpp (main): Compare `font::load_desc()` return value to null pointer literal instead of treating it as a Boolean. * src/roff/groff/groff.cpp (main): Report full filespec of troublesome "DESC" file when complainiing of missing "postpro" directive.
* src/libs/libgroff/fontfile.cpp (font::open_file): Refactor. Move more logic, including memory allocation, inside conditional that accepts only file names without '/' characters, skipping unnecessary work in the alternative. Annotate use of zero literals as null pointers to ease any future migration to ISO C++11. Add 'const' qualifier to variable that doesn't require modification (and which is used in the LHS of an equality comparison, so that clumsy operator misuse will provoke a compiler warning). Fixes <https://savannah.gnu.org/bugs/?62532>. Thanks to Bjarni Ingi Gislason for the report.