From 1ca115c44bca894a6bbb2334e60a361dbd64a157 Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Thu, 14 Jun 2012 15:04:33 +0200 Subject: ffmpegviddec: Properly error out when codec doesn't open Avoids ending up using an un-set codec --- ext/ffmpeg/gstffmpegviddec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ext/ffmpeg/gstffmpegviddec.c b/ext/ffmpeg/gstffmpegviddec.c index 3554ead..a4afe08 100644 --- a/ext/ffmpeg/gstffmpegviddec.c +++ b/ext/ffmpeg/gstffmpegviddec.c @@ -413,7 +413,7 @@ gst_ffmpegviddec_set_format (GstVideoDecoder * decoder, { GstFFMpegVidDec *ffmpegdec; GstFFMpegVidDecClass *oclass; - gboolean ret = TRUE; + gboolean ret = FALSE; ffmpegdec = (GstFFMpegVidDec *) decoder; oclass = (GstFFMpegVidDecClass *) (G_OBJECT_GET_CLASS (ffmpegdec)); @@ -528,6 +528,8 @@ gst_ffmpegviddec_set_format (GstVideoDecoder * decoder, gst_video_codec_state_unref (ffmpegdec->input_state); ffmpegdec->input_state = gst_video_codec_state_ref (state); + ret = TRUE; + done: GST_OBJECT_UNLOCK (ffmpegdec); -- cgit v1.2.1