summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJulien Isorce <jisorce@oblong.com>2017-08-11 07:48:37 -0700
committerJulien Isorce <jisorce@oblong.com>2017-08-17 14:08:24 +0100
commitbb3778a1acc8eb8314c6a043634eabfd5f0026d5 (patch)
treed3bcc326d44c69e3024cd83a679a42cb2fd8a684
parenteec88a965106d66e1b327b9bc15a114b6b0f262e (diff)
downloadgst-omx-bb3778a1acc8eb8314c6a043634eabfd5f0026d5.tar.gz
omxvideodec: remove wrong SettingsChanged ack
Partially revert 1b7d0b8: omxvideodec: handle IL 1.2 behavior for OMX_SetParameter It turned out it was a problem in the decoder which was not updating some local variables upon SetParameter. https://bugzilla.gnome.org/show_bug.cgi?id=783976
-rw-r--r--omx/gstomxvideodec.c14
1 files changed, 1 insertions, 13 deletions
diff --git a/omx/gstomxvideodec.c b/omx/gstomxvideodec.c
index b0178b1..2c79781 100644
--- a/omx/gstomxvideodec.c
+++ b/omx/gstomxvideodec.c
@@ -2301,23 +2301,11 @@ gst_omx_video_dec_set_format (GstVideoDecoder * decoder,
return FALSE;
}
}
-#if OMX_VERSION_MINOR == 2
- /* In OMX-IL 1.2.0, the nFrameWidth/Height changes are propagated to the
- * the output port upon call to the SetParameter on in port above. This
- * propagation triggers a SettingsChanged event. It is up to the client
- * to decide if this event should lead to reconfigure the port. Here
- * this is clearly informal so lets just acknowledge the event to avoid
- * output port reconfiguration. Note that the SettingsChanged event will
- * be sent in-context of the SetParameter call above. So the event is
- * garantie to be proceeded in the handle_message call below. */
- if (gst_omx_port_mark_reconfigured (self->dec_out_port) != OMX_ErrorNone)
- return FALSE;
-#else
+
GST_DEBUG_OBJECT (self, "Updating outport port definition");
if (gst_omx_port_update_port_definition (self->dec_out_port,
NULL) != OMX_ErrorNone)
return FALSE;
-#endif
gst_buffer_replace (&self->codec_data, state->codec_data);
self->input_state = gst_video_codec_state_ref (state);