summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNicolas Dufresne <nicolas.dufresne@collabora.com>2018-09-07 22:55:41 -0400
committerNicolas Dufresne <nicolas.dufresne@collabora.com>2018-09-10 17:09:11 -0400
commit35abdd16d1b3130f5b98d73ba2a4ae3f8eab549f (patch)
tree2d70cd54fb03f5daa4001174ea1e496ed576210c
parent04e1f76b600001d1b69139388432ba6fd0281fff (diff)
downloadgst-omx-35abdd16d1b3130f5b98d73ba2a4ae3f8eab549f.tar.gz
omxvideodec: Remove spurious unlock in error case
This was forgotton in previous patch. We no long hold the lock when goto invalid_buffer is called. https://bugzilla.gnome.org/show_bug.cgi?id=715192
-rw-r--r--omx/gstomxvideodec.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/omx/gstomxvideodec.c b/omx/gstomxvideodec.c
index 848d0b1..e1aec3f 100644
--- a/omx/gstomxvideodec.c
+++ b/omx/gstomxvideodec.c
@@ -1912,13 +1912,12 @@ eos:
GST_VIDEO_DECODER_STREAM_LOCK (self);
self->downstream_flow_ret = flow_ret;
+ GST_VIDEO_DECODER_STREAM_UNLOCK (self);
/* Here we fallback and pause the task for the EOS case */
if (flow_ret != GST_FLOW_OK)
goto flow_error;
- GST_VIDEO_DECODER_STREAM_UNLOCK (self);
-
return;
}
@@ -1958,7 +1957,6 @@ invalid_buffer:
("Invalid sized input buffer"));
gst_pad_push_event (GST_VIDEO_DECODER_SRC_PAD (self), gst_event_new_eos ());
gst_omx_video_dec_pause_loop (self, GST_FLOW_NOT_NEGOTIATED);
- GST_VIDEO_DECODER_STREAM_UNLOCK (self);
return;
}