summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Release 1.15.901.15.90Tim-Philipp Müller2019-04-116-47/+176
|
* meson: add -Wundef as additional warning flagTim-Philipp Müller2019-04-101-0/+1
|
* omx: fix autotools build for generic targetTim-Philipp Müller2019-04-101-1/+1
| | | | | | | gstomxvideoenc.c:2874:7: error: "USE_OMX_TARGET_ZYNQ_USCALE_PLUS" is not defined, evaluates to 0 [-Werror=undef] #elif USE_OMX_TARGET_ZYNQ_USCALE_PLUS Works on meson because it doesn't use -Wundef
* Add Gitlab CI configurationJordan Petridis2019-04-061-0/+1
| | | | | | | | | | | This commit adds a .gitlab-ci.yml file, which uses a feature to fetch the config from a centralized repository. The intent is to have all the gstreamer modules use the same configuration. The configuration is currently hosted at the gst-ci repository under the gitlab/ci_template.yml path. Part of https://gitlab.freedesktop.org/gstreamer/gstreamer-project/issues/29
* omx: disable OMX_API_TRACE code if gst debug is disabledGuillaume Desmottes2019-03-261-0/+6
| | | | | No need to create debug structs which won't be used as DEBUG macros are no-op.
* omx: log Get/SetParameter/Config callsGuillaume Desmottes2019-03-261-0/+476
| | | | Extend OMX_API_TRACE by logging component configuration calls.
* omxbufferpool: don't use CAT_PERFORMANCE if pool will copyGuillaume Desmottes2019-03-261-4/+1
| | | | | | | | | | This was the single place where this category was used in gst-omx so most users, including me, are generally not turning it and were missing this important information from logs. The copying code uses gst_video_frame_copy() which is already logging with CAT_PERFORMANCE so we can still have this information when using only this debug category.
* omxvideodec: add debug if proposed pool can't provide enough buffersGuillaume Desmottes2019-03-261-0/+2
| | | | | We were silently ignoring the pool which was pretty confusing when debugging.
* omx: Add hardware classifiers to encoders/decodersCharlie Turner2019-03-2618-18/+18
|
* meson: sync warnings flags with -goodGuillaume Desmottes2019-03-251-0/+60
| | | | | | | Add more warnings flags and disabled unused variable warnings if gst debug system is disabled. Copied from gst-plugins-good/meson.build
* Back to developmentTim-Philipp Müller2019-03-044-8/+8
|
* Release 1.15.21.15.2Tim-Philipp Müller2019-02-266-101/+288
|
* meson: add options to disable examples, tests and tools and bump meson ↵Tim-Philipp Müller2019-02-142-7/+21
| | | | requirement
* omxvideo: use GST_VIDEO_CAPS_MAKE() for template capsGuillaume Desmottes2019-01-254-6/+8
| | | | | Simplify the code and so we advertise the formats actually supported by gst-omx.
* omxvideoenc: validate cpb-size and initial-delayGuillaume Desmottes2019-01-251-11/+19
| | | | cpb-size cannot be smaller than initial-delay.
* omxvideodec: Remove duplicated QoS codeNicolas Dufresne2019-01-251-10/+1
| | | | | The 'finish' function do the exact same check / drop, there is no need to duplicate this here.
* omxvideodec: Remove dead codeNicolas Dufresne2019-01-252-16/+0
| | | | | The omxvideodec base class have a totally unused prepare_frame() vritual function, remove it.
* omxvideoenc: add adaptive gop-mode optionVarunkumar Allagadapa2019-01-251-0/+2
| | | | Added adaptive gop-mode option to ZYNQ_USCALE_PLUS encoder properties
* omxvideoenc: Add dynamic framerate supportNicolas Dufresne2019-01-251-0/+52
| | | | | Instead of going through a full reset, try and change the framerate config on the encoder when only the framerate have change.
* Release 1.15.11.15.1Tim-Philipp Müller2019-01-176-58/+1702
|
* omxvideoenc: Add dynamic IDR insertion support on zynqVarunkumar Allagadapa2019-01-091-0/+9
| | | | As the pi, the zynq has its own API to request keyframe.
* omxbufferpool: fix race when releasing input buffersGuillaume Desmottes2019-01-083-1/+13
| | | | | | | | | If buffers were released from the pool while gst_omx_video_enc_handle_frame() was waiting for new buffers, gst_omx_port_acquire_buffer() was never awaken as the buffers weren't released through OMX's messaging system. GQueue isn't thread safe so also protect it with the lock mutex.
* omxbufferpool: fix early input buffer releaseGuillaume Desmottes2018-12-214-11/+1
| | | | | | | | | | | | | | | | | We used to track the 'allocating' status on the pool. It is used while allocating so output buffers aren't passed right away to OMX and input ones are not re-added to the pending queue. This was causing a bug when exporting buffers to v4l2src. On start v4l2src acquires a buffer, read its stride and release it right away. As no buffer was received by the encoder element at this point, 'allocating' was still on TRUE and so the the buffer wasn't put back to the pending queue and, as result, no longer available to the pool. Fix this by checking the active status of the pool instead of manually tracking it down. The pool is considered as active at the very end of the activation process so we're good when buffers are released during the activation.
* Automatic update of common submoduleThibault Saunier2018-12-051-0/+0
| | | | From ed78bee to 59cb678
* omx: fix OMX_EventBufferFlag OMX_API_TRACE structGuillaume Desmottes2018-11-261-1/+2
| | | | The GType was missing from the second field of the struct.
* Update git locations to gitlabMatthew Waters2018-11-052-3/+3
|
* omx: rename OMX_PERFORMANCE debug cat to OMX_API_TRACEGuillaume Desmottes2018-09-261-20/+20
| | | | | | | This debug category can now be used to track more OMX calls and events so best to rename it to something more generic. https://bugzilla.gnome.org/show_bug.cgi?id=797171
* omx: log OMX commands with OMX_PERFORMANCE debug categoryGuillaume Desmottes2018-09-191-0/+55
| | | | | | | It has been useful to have a clear raw and structured view of the gst <-> OMX exchanges when debugging. https://bugzilla.gnome.org/show_bug.cgi?id=797171
* omx: factor out gst_omx_component_send_command()Guillaume Desmottes2018-09-191-5/+18
| | | | | | No semantic change. I'm going to add extra debug in this function. https://bugzilla.gnome.org/show_bug.cgi?id=797171
* omx: log OMX events with OMX_PERFORMANCE debug categoryGuillaume Desmottes2018-09-191-0/+141
| | | | | | | It has been useful to have a clear raw and structured view of the gst <-> OMX exchanges when debugging. https://bugzilla.gnome.org/show_bug.cgi?id=797171
* omx: rename log_omx_performance() to log_omx_performance_buffer()Guillaume Desmottes2018-09-191-6/+6
| | | | | | I'm about to log more things under this category https://bugzilla.gnome.org/show_bug.cgi?id=797171
* omxvideoenc: Remove spurious lockingNicolas Dufresne2018-09-101-7/+3
| | | | | | | | The method we call in the context of pushing a buffer are all thread safe. Holding a lock would prevent input buffers from being queued while pushing. https://bugzilla.gnome.org/show_bug.cgi?id=715192
* omxvideoenc: Remove unneeded size checkNicolas Dufresne2018-09-101-11/+7
| | | | | | | We only enter this branch if nFilledLen > 0, there is not need to check again. https://bugzilla.gnome.org/show_bug.cgi?id=715192
* omxvideodec: Remove spurious unlock in error caseNicolas Dufresne2018-09-101-3/+1
| | | | | | | This was forgotton in previous patch. We no long hold the lock when goto invalid_buffer is called. https://bugzilla.gnome.org/show_bug.cgi?id=715192
* omxvideodec: don't hold the stream lock when trying to push a frameNicolas Dufresne2018-08-311-4/+2
| | | | | | | | | | The base class methods will lock this properly when needed, there seems to be no need to lock it explicitly. This allows the patch in gstvideodec for unlocking the stream lock when pushing buffers out to work. https://bugzilla.gnome.org/show_bug.cgi?id=715192
* omxvideodec: don't import OMX buffers from downstreamGuillaume Desmottes2018-08-301-4/+16
| | | | | | | | | | | | | | We already have code configuring the encoder stride and slice height when receiving the first buffer from upstream. We don't have an equivalent when the encoder is exporting its buffers to the decoder. There is no point adding it and making the code even more complex as we wouldn't gain anything by exporting from the encoder to the decoder. The dynamic buffer mode already ensures 0-copy between OMX components. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxvideoenc: implement dmabuf export on input buffersGuillaume Desmottes2018-08-305-62/+309
| | | | | | | | | | Propose pool upstream so input buffers can be allocated by the port and exported as dmabuf. The actual OMX buffers are allocated when the pool is activated, so we don't end up doing useless allocations if the pool isn't used. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omx: allow gst_omx_port_acquire_buffer() to not wait for buffersGuillaume Desmottes2018-08-307-20/+34
| | | | | | Will be needed to implement GST_BUFFER_POOL_ACQUIRE_FLAG_DONTWAIT. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxvideodec: don't import non-dmabuf when dec is in dmabuf modeGuillaume Desmottes2018-08-301-0/+7
| | | | | | Fix 'omxh264dec ! videocrop' pipeline. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxvideodec: factor out gst_omx_try_importing_buffer()Guillaume Desmottes2018-08-301-22/+64
| | | | | | No semantic change, just make the code clearer and improve debug output. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxvideodec: fix gst_video_info_from_caps() caps assertionGuillaume Desmottes2018-08-301-0/+3
| | | | | | | The "use buffers" code path uses gst_video_info_from_caps() which is asserting if caps is NULL (because pool was rejected). https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxvideodec: fix pool caps reference stealingGuillaume Desmottes2018-08-301-1/+1
| | | | | | | gst_buffer_pool_config_get_params() doesn't ref the returning caps; so gst_caps_replace() was unreffing the reference owned by the pool. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxvideodec: prevent timeout when shutting down because of pending out buffersGuillaume Desmottes2018-08-301-2/+9
| | | | | | | | | | | The OMX transition state to Loaded won't be complete until all buffers have been freed. There is no point waiting, and timeout, if we know that output buffers haven't been freed yet. The typical scenario is output buffers being still used downstream and being freed later when released back to the pool. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxbufferpool: reference the OMX componentGuillaume Desmottes2018-08-301-1/+3
| | | | | | | | | Now that the pool is responsible of freeing the OMX buffers, we need to ensure that the OMX component stay alive while the pool is as we rely on the component to free the buffers. The GstOMXPort is owned by the component so no need to ref this one. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* turn GstOMXComponent to a GstMiniObjectGuillaume Desmottes2018-08-307-8/+37
| | | | | | Will use it for refcounting. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxbufferpool: deallocate OMX buffers when stoppingGuillaume Desmottes2018-08-302-13/+19
| | | | | | | | The pool is stopped when all the buffers have been released. Deallocate when stopping so we are sure that the buffers aren't still used by another element. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omx: call gst_omx_buffer_unmap() when handling BUFFER_DONEGuillaume Desmottes2018-08-301-5/+7
| | | | | | | | | | | | | When using a input buffer pool, the buffer may be released to the pool when gst_omx_buffer_unmap() is called. We need to have buf->used unset at this point as the pool may use it to check the status of the pool. {Empty,Fill}BufferDone is called from OMX internal threads while messages are handled from gst elements' thread. Best to do all this when handling the message so we don't mess with OMX threads and keep the original thread/logic split. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxvideo{enc,dec}: stop calling shutdown() in change_stateGuillaume Desmottes2018-08-302-6/+0
| | | | | | | | | | | | | This is no longer needed since we implemented close() vfuncs as the encoder/decoder base class already take care of calling close() (which is calling shutdown()) in its own change_state implementation. We also move the shut down of the component from PAUSED_TO_READY to READY_TO_NULL. By doing so upstream will have already deactivated the pool from the encoder and so won't be preventing the OMX state change as the buffers will all be released. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omx: factor out gst_omx_buffer_get/set_omx_buf()Guillaume Desmottes2018-08-303-14/+25
| | | | | | | Move the qdata code to helper functions as I'm going to need them in omxvideoenc to implement dmabuf export. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxvideoenc: factor out gst_omx_video_enc_set_to_idle()Guillaume Desmottes2018-08-301-30/+38
| | | | | | | No semantic change. We'll have to use this when the input pool is activated so we can allocate buffers. https://bugzilla.gnome.org/show_bug.cgi?id=796918