| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
| |
After handling codec config, codec frame should be unreffed.
|
|
|
|
|
| |
This has proven to be very useful when debugging to detect bugs where we
match the wrong gst frame with an output OMX buffer.
|
|
|
|
|
|
| |
Those debug infos have proved to be very helpful when debugging
timestamp issues. They are often linked to gst-omx picking the wrong
frame when trying to map from OMX.
|
|
|
|
|
| |
If decoder outputs internal buffer and not use OMX_UseBuffer,
downstream bufferpool should be stopped.
|
|
|
|
|
|
| |
Add a property to control the number of frames for reference.
Min and max value is based on OpenMAX IL 1.2.0 Specification.
|
|
|
|
|
|
|
| |
This means we can use some newer features and get rid of some
boilerplate code using the G_DECLARE_* macros.
As discussed on IRC, 2.44 is old enough by now to start depending on it.
|
| |
|
|
|
|
| |
They are no longer used anywhere
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
One big restriction of the OMX buffer pool has always been
that the GstMemory objects were flagged with NO_SHARE.
This was because the buffer pool needed to be sure that when
a buffer returned to the pool, it would be safe to release the
OMX buffer back to OpenMAX.
With this change, this is no longer a restriction. What this
commit introduces is a new allocator that allows us to track
the GstMemory objects independently. Now, when a buffer returns
to the pool, it is not necessary for the memory to be released
as well. We simply track the memory's ref count in the allocator
and we return the OMX buffer back when the memory's ref count
drops to 0.
The reason for doing this is to allow implementing zero-copy
transfers in situations where we may need to copy or map a
certain region of the buffer. For instance, omxh264enc ! h264parse
should be possible to be zero-copy by using an OMX buffer pool
between them.
|
|
|
|
|
|
|
|
|
| |
gst_memory_map() is already adding the offset to the mapped pointer.
Doing it in the memory implementation was resulting in the offset being
accounted twice.
It doesn't matter yet as we are only creating memory without offset for
now but it will once we'll start sharing OMX memories.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
gstomx.c:1405:10: error: ‘OMX_IndexParamCustomContentPipe’ undeclared (first use in this function)
case OMX_IndexParamCustomContentPipe
Some enums have been deprecated in 1.2.0
https://gitlab.freedesktop.org/gstreamer/gst-omx/issues/27
|
|
|
|
|
| |
Use pkg-config to detect and configure rpi specific libs used in testegl
rather than hardcoding their flags.
|
|
|
|
| |
Neded for the declaration of eglSaneChooseConfigBRCM().
|
|
|
|
|
| |
We need to define __VCCOREVER__ and disable redundant-decls before
including the egl.h from the pi.
|
| |
|
| |
|
|
|
|
|
|
|
| |
gstomxvideoenc.c:2874:7: error: "USE_OMX_TARGET_ZYNQ_USCALE_PLUS" is not defined, evaluates to 0 [-Werror=undef]
#elif USE_OMX_TARGET_ZYNQ_USCALE_PLUS
Works on meson because it doesn't use -Wundef
|
|
|
|
|
|
|
|
|
|
|
| |
This commit adds a .gitlab-ci.yml file, which uses a feature
to fetch the config from a centralized repository. The intent is
to have all the gstreamer modules use the same configuration.
The configuration is currently hosted at the gst-ci repository
under the gitlab/ci_template.yml path.
Part of https://gitlab.freedesktop.org/gstreamer/gstreamer-project/issues/29
|
|
|
|
|
| |
No need to create debug structs which won't be used as DEBUG macros are
no-op.
|
|
|
|
| |
Extend OMX_API_TRACE by logging component configuration calls.
|
|
|
|
|
|
|
|
|
|
| |
This was the single place where this category was used in gst-omx so
most users, including me, are generally not turning it and were missing this
important information from logs.
The copying code uses gst_video_frame_copy() which is already logging
with CAT_PERFORMANCE so we can still have this information when using
only this debug category.
|
|
|
|
|
| |
We were silently ignoring the pool which was pretty confusing when
debugging.
|
| |
|
|
|
|
|
|
|
| |
Add more warnings flags and disabled unused variable warnings if gst
debug system is disabled.
Copied from gst-plugins-good/meson.build
|
| |
|
| |
|
|
|
|
| |
requirement
|
|
|
|
|
| |
Simplify the code and so we advertise the formats actually supported by
gst-omx.
|
|
|
|
| |
cpb-size cannot be smaller than initial-delay.
|
|
|
|
|
| |
The 'finish' function do the exact same check / drop, there is no
need to duplicate this here.
|
|
|
|
|
| |
The omxvideodec base class have a totally unused prepare_frame() vritual
function, remove it.
|
|
|
|
| |
Added adaptive gop-mode option to ZYNQ_USCALE_PLUS encoder properties
|
|
|
|
|
| |
Instead of going through a full reset, try and change the framerate
config on the encoder when only the framerate have change.
|
| |
|
|
|
|
| |
As the pi, the zynq has its own API to request keyframe.
|
|
|
|
|
|
|
|
|
| |
If buffers were released from the pool while
gst_omx_video_enc_handle_frame() was waiting for new buffers,
gst_omx_port_acquire_buffer() was never awaken as the buffers weren't
released through OMX's messaging system.
GQueue isn't thread safe so also protect it with the lock mutex.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We used to track the 'allocating' status on the pool. It is used while
allocating so output buffers aren't passed right away to OMX and input
ones are not re-added to the pending queue.
This was causing a bug when exporting buffers to v4l2src. On start
v4l2src acquires a buffer, read its stride and release it right away.
As no buffer was received by the encoder element at this point, 'allocating'
was still on TRUE and so the the buffer wasn't put back to the pending
queue and, as result, no longer available to the pool.
Fix this by checking the active status of the pool instead of manually
tracking it down. The pool is considered as active at the very end of
the activation process so we're good when buffers are released during
the activation.
|
|
|
|
| |
From ed78bee to 59cb678
|
|
|
|
| |
The GType was missing from the second field of the struct.
|
| |
|
|
|
|
|
|
|
| |
This debug category can now be used to track more OMX calls and events
so best to rename it to something more generic.
https://bugzilla.gnome.org/show_bug.cgi?id=797171
|
|
|
|
|
|
|
| |
It has been useful to have a clear raw and structured view of the gst
<-> OMX exchanges when debugging.
https://bugzilla.gnome.org/show_bug.cgi?id=797171
|
|
|
|
|
|
| |
No semantic change. I'm going to add extra debug in this function.
https://bugzilla.gnome.org/show_bug.cgi?id=797171
|
|
|
|
|
|
|
| |
It has been useful to have a clear raw and structured view of the gst
<-> OMX exchanges when debugging.
https://bugzilla.gnome.org/show_bug.cgi?id=797171
|
|
|
|
|
|
| |
I'm about to log more things under this category
https://bugzilla.gnome.org/show_bug.cgi?id=797171
|
|
|
|
|
|
|
|
| |
The method we call in the context of pushing a buffer are all thread
safe. Holding a lock would prevent input buffers from being queued while
pushing.
https://bugzilla.gnome.org/show_bug.cgi?id=715192
|
|
|
|
|
|
|
| |
We only enter this branch if nFilledLen > 0, there is not need
to check again.
https://bugzilla.gnome.org/show_bug.cgi?id=715192
|
|
|
|
|
|
|
| |
This was forgotton in previous patch. We no long hold the lock when goto
invalid_buffer is called.
https://bugzilla.gnome.org/show_bug.cgi?id=715192
|