summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* omxvideodec: Remove dead codeNicolas Dufresne2019-01-252-16/+0
| | | | | The omxvideodec base class have a totally unused prepare_frame() vritual function, remove it.
* omxvideoenc: add adaptive gop-mode optionVarunkumar Allagadapa2019-01-251-0/+2
| | | | Added adaptive gop-mode option to ZYNQ_USCALE_PLUS encoder properties
* omxvideoenc: Add dynamic framerate supportNicolas Dufresne2019-01-251-0/+52
| | | | | Instead of going through a full reset, try and change the framerate config on the encoder when only the framerate have change.
* Release 1.15.11.15.1Tim-Philipp Müller2019-01-176-58/+1702
|
* omxvideoenc: Add dynamic IDR insertion support on zynqVarunkumar Allagadapa2019-01-091-0/+9
| | | | As the pi, the zynq has its own API to request keyframe.
* omxbufferpool: fix race when releasing input buffersGuillaume Desmottes2019-01-083-1/+13
| | | | | | | | | If buffers were released from the pool while gst_omx_video_enc_handle_frame() was waiting for new buffers, gst_omx_port_acquire_buffer() was never awaken as the buffers weren't released through OMX's messaging system. GQueue isn't thread safe so also protect it with the lock mutex.
* omxbufferpool: fix early input buffer releaseGuillaume Desmottes2018-12-214-11/+1
| | | | | | | | | | | | | | | | | We used to track the 'allocating' status on the pool. It is used while allocating so output buffers aren't passed right away to OMX and input ones are not re-added to the pending queue. This was causing a bug when exporting buffers to v4l2src. On start v4l2src acquires a buffer, read its stride and release it right away. As no buffer was received by the encoder element at this point, 'allocating' was still on TRUE and so the the buffer wasn't put back to the pending queue and, as result, no longer available to the pool. Fix this by checking the active status of the pool instead of manually tracking it down. The pool is considered as active at the very end of the activation process so we're good when buffers are released during the activation.
* Automatic update of common submoduleThibault Saunier2018-12-051-0/+0
| | | | From ed78bee to 59cb678
* omx: fix OMX_EventBufferFlag OMX_API_TRACE structGuillaume Desmottes2018-11-261-1/+2
| | | | The GType was missing from the second field of the struct.
* Update git locations to gitlabMatthew Waters2018-11-052-3/+3
|
* omx: rename OMX_PERFORMANCE debug cat to OMX_API_TRACEGuillaume Desmottes2018-09-261-20/+20
| | | | | | | This debug category can now be used to track more OMX calls and events so best to rename it to something more generic. https://bugzilla.gnome.org/show_bug.cgi?id=797171
* omx: log OMX commands with OMX_PERFORMANCE debug categoryGuillaume Desmottes2018-09-191-0/+55
| | | | | | | It has been useful to have a clear raw and structured view of the gst <-> OMX exchanges when debugging. https://bugzilla.gnome.org/show_bug.cgi?id=797171
* omx: factor out gst_omx_component_send_command()Guillaume Desmottes2018-09-191-5/+18
| | | | | | No semantic change. I'm going to add extra debug in this function. https://bugzilla.gnome.org/show_bug.cgi?id=797171
* omx: log OMX events with OMX_PERFORMANCE debug categoryGuillaume Desmottes2018-09-191-0/+141
| | | | | | | It has been useful to have a clear raw and structured view of the gst <-> OMX exchanges when debugging. https://bugzilla.gnome.org/show_bug.cgi?id=797171
* omx: rename log_omx_performance() to log_omx_performance_buffer()Guillaume Desmottes2018-09-191-6/+6
| | | | | | I'm about to log more things under this category https://bugzilla.gnome.org/show_bug.cgi?id=797171
* omxvideoenc: Remove spurious lockingNicolas Dufresne2018-09-101-7/+3
| | | | | | | | The method we call in the context of pushing a buffer are all thread safe. Holding a lock would prevent input buffers from being queued while pushing. https://bugzilla.gnome.org/show_bug.cgi?id=715192
* omxvideoenc: Remove unneeded size checkNicolas Dufresne2018-09-101-11/+7
| | | | | | | We only enter this branch if nFilledLen > 0, there is not need to check again. https://bugzilla.gnome.org/show_bug.cgi?id=715192
* omxvideodec: Remove spurious unlock in error caseNicolas Dufresne2018-09-101-3/+1
| | | | | | | This was forgotton in previous patch. We no long hold the lock when goto invalid_buffer is called. https://bugzilla.gnome.org/show_bug.cgi?id=715192
* omxvideodec: don't hold the stream lock when trying to push a frameNicolas Dufresne2018-08-311-4/+2
| | | | | | | | | | The base class methods will lock this properly when needed, there seems to be no need to lock it explicitly. This allows the patch in gstvideodec for unlocking the stream lock when pushing buffers out to work. https://bugzilla.gnome.org/show_bug.cgi?id=715192
* omxvideodec: don't import OMX buffers from downstreamGuillaume Desmottes2018-08-301-4/+16
| | | | | | | | | | | | | | We already have code configuring the encoder stride and slice height when receiving the first buffer from upstream. We don't have an equivalent when the encoder is exporting its buffers to the decoder. There is no point adding it and making the code even more complex as we wouldn't gain anything by exporting from the encoder to the decoder. The dynamic buffer mode already ensures 0-copy between OMX components. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxvideoenc: implement dmabuf export on input buffersGuillaume Desmottes2018-08-305-62/+309
| | | | | | | | | | Propose pool upstream so input buffers can be allocated by the port and exported as dmabuf. The actual OMX buffers are allocated when the pool is activated, so we don't end up doing useless allocations if the pool isn't used. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omx: allow gst_omx_port_acquire_buffer() to not wait for buffersGuillaume Desmottes2018-08-307-20/+34
| | | | | | Will be needed to implement GST_BUFFER_POOL_ACQUIRE_FLAG_DONTWAIT. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxvideodec: don't import non-dmabuf when dec is in dmabuf modeGuillaume Desmottes2018-08-301-0/+7
| | | | | | Fix 'omxh264dec ! videocrop' pipeline. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxvideodec: factor out gst_omx_try_importing_buffer()Guillaume Desmottes2018-08-301-22/+64
| | | | | | No semantic change, just make the code clearer and improve debug output. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxvideodec: fix gst_video_info_from_caps() caps assertionGuillaume Desmottes2018-08-301-0/+3
| | | | | | | The "use buffers" code path uses gst_video_info_from_caps() which is asserting if caps is NULL (because pool was rejected). https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxvideodec: fix pool caps reference stealingGuillaume Desmottes2018-08-301-1/+1
| | | | | | | gst_buffer_pool_config_get_params() doesn't ref the returning caps; so gst_caps_replace() was unreffing the reference owned by the pool. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxvideodec: prevent timeout when shutting down because of pending out buffersGuillaume Desmottes2018-08-301-2/+9
| | | | | | | | | | | The OMX transition state to Loaded won't be complete until all buffers have been freed. There is no point waiting, and timeout, if we know that output buffers haven't been freed yet. The typical scenario is output buffers being still used downstream and being freed later when released back to the pool. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxbufferpool: reference the OMX componentGuillaume Desmottes2018-08-301-1/+3
| | | | | | | | | Now that the pool is responsible of freeing the OMX buffers, we need to ensure that the OMX component stay alive while the pool is as we rely on the component to free the buffers. The GstOMXPort is owned by the component so no need to ref this one. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* turn GstOMXComponent to a GstMiniObjectGuillaume Desmottes2018-08-307-8/+37
| | | | | | Will use it for refcounting. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxbufferpool: deallocate OMX buffers when stoppingGuillaume Desmottes2018-08-302-13/+19
| | | | | | | | The pool is stopped when all the buffers have been released. Deallocate when stopping so we are sure that the buffers aren't still used by another element. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omx: call gst_omx_buffer_unmap() when handling BUFFER_DONEGuillaume Desmottes2018-08-301-5/+7
| | | | | | | | | | | | | When using a input buffer pool, the buffer may be released to the pool when gst_omx_buffer_unmap() is called. We need to have buf->used unset at this point as the pool may use it to check the status of the pool. {Empty,Fill}BufferDone is called from OMX internal threads while messages are handled from gst elements' thread. Best to do all this when handling the message so we don't mess with OMX threads and keep the original thread/logic split. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxvideo{enc,dec}: stop calling shutdown() in change_stateGuillaume Desmottes2018-08-302-6/+0
| | | | | | | | | | | | | This is no longer needed since we implemented close() vfuncs as the encoder/decoder base class already take care of calling close() (which is calling shutdown()) in its own change_state implementation. We also move the shut down of the component from PAUSED_TO_READY to READY_TO_NULL. By doing so upstream will have already deactivated the pool from the encoder and so won't be preventing the OMX state change as the buffers will all be released. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omx: factor out gst_omx_buffer_get/set_omx_buf()Guillaume Desmottes2018-08-303-14/+25
| | | | | | | Move the qdata code to helper functions as I'm going to need them in omxvideoenc to implement dmabuf export. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxvideoenc: factor out gst_omx_video_enc_set_to_idle()Guillaume Desmottes2018-08-301-30/+38
| | | | | | | No semantic change. We'll have to use this when the input pool is activated so we can allocate buffers. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxvideoenc: factor out gst_omx_video_enc_deallocate_in_buffers()Guillaume Desmottes2018-08-301-2/+11
| | | | | | Will add extra code when adding input buffer pool. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omx: add pBuffer to OMX_PERFORMANCE logsGuillaume Desmottes2018-08-301-1/+4
| | | | | | Can be useful to check the fd being passed when using dmabuf. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omx: factor out gst_omx_port_set_dmabuf()Guillaume Desmottes2018-08-304-36/+38
| | | | | | No semantic change. I also made the debug message a bit clearer. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omx: wait for flush complete and buffers being released when flushingGuillaume Desmottes2018-08-291-6/+16
| | | | | | | | | | | | | | | | | | When flusing we should wait for OMX to send the flush command complete event AND all ports being released. We were stopping as soon as one of those condition was met. Fix a race between FillThisBufferDone/EmptyBufferDone and the flush EventCmdComplete messages. The OMX implementation is supposed to release its buffers before posting the EventCmdComplete event but the ordering isn't guaranteed as the FillThisBufferDone/EmptyBufferDone and EventHandler callbacks can be called from different threads (cf 2.7 'Thread Safety' in the spec). Only wait for buffers currently used by OMX as some buffers may not be in the pending queue because they are held downstream. https://bugzilla.gnome.org/show_bug.cgi?id=789475
* omx: factor out should_wait_until_flushed()Guillaume Desmottes2018-08-291-7/+15
| | | | | | | No semantic change. Makes the code easier to understand and I'm about to change the waiting condition. https://bugzilla.gnome.org/show_bug.cgi?id=789475
* omxvideoenc: pause component when flushingGuillaume Desmottes2018-08-281-0/+13
| | | | | | | | | As stated in the spec ("6.1.3 Seek Event Sequence") we should pause before flushing. We were pausing the decoder but not the encoder so I just aligned the two code paths. https://bugzilla.gnome.org/show_bug.cgi?id=797038
* omxvideoenc: fix vertical padding in NV16 formatsGuillaume Desmottes2018-07-131-14/+7
| | | | | | | My previous patch to calculate the vertical padding was always halfing the height of the chroma plane which is incorrect for NV16 formats. https://bugzilla.gnome.org/show_bug.cgi?id=796749
* omxvideoenc: include vertical padding in nFilledLen when copyingGuillaume Desmottes2018-07-051-2/+19
| | | | | | | | | | | According to the OMX spec (3.1.3.7.1) nFilledLen is meant to include any padding. We use to include the horizontal one (stride) but not the vertical one if nSliceHeight is bigger than the actual height. The calculated nFilledLen was wrong as it didn't include the padding between planes. https://bugzilla.gnome.org/show_bug.cgi?id=796749
* omxvideoenc: implement decide_allocationGuillaume Desmottes2018-06-085-12/+53
| | | | | | | | | Increase the number of output buffers by the number of buffers requested downstream. Prevent buffers starvation if downstream is going to use dynamic buffer mode on its input. https://bugzilla.gnome.org/show_bug.cgi?id=795746
* omxvideodec: implement propose_allocationGuillaume Desmottes2018-06-081-0/+22
| | | | | | | | | Tell upstream about how many buffer we plan to use so they can adjust their own number of buffers accordingly if needed. Same logic as the existing gst_omx_video_enc_propose_allocation(). https://bugzilla.gnome.org/show_bug.cgi?id=795746
* omxvideoenc: always signal drain cond when stopping streaming loopGuillaume Desmottes2018-06-082-34/+21
| | | | | | Similar change as the one I just did in omxvideodec. https://bugzilla.gnome.org/show_bug.cgi?id=796207
* omxvideodec: always signal drain cond when stopping streaming loopGuillaume Desmottes2018-06-082-23/+9
| | | | | | | | | | | | If for some reason something goes wrong and we stop the streaming loop we may end up with other threads still waiting on the drain cond. No more buffers will be produced by the component so they were waiting forever. Fix this by always signalling this cond when stopping the streaming loop. https://bugzilla.gnome.org/show_bug.cgi?id=796207
* omxvideoenc: factor out gst_omx_video_enc_pause_loop()Guillaume Desmottes2018-06-081-17/+16
| | | | | | No semantic change. I'm going to use it in more failure cases. https://bugzilla.gnome.org/show_bug.cgi?id=796207
* zynqultrascaleplus: enable 'ensure-buffer-count-actual' hackGuillaume Desmottes2018-06-081-4/+4
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=791211
* omxvideodec/enc: add hack updating nBufferCountActual before allocatingGuillaume Desmottes2018-06-084-0/+101
| | | | | | | | | | | | | | | | | | | | | | | The OMX specs states that the nBufferCountActual of a port has to default to its nBufferCountMin. If we don't change nBufferCountActual we purely rely on this default. But in some cases, OMX may change nBufferCountMin before we allocate buffers. Like for example when configuring the input ports with the actual format, it may decrease the number of minimal buffers required. This method checks this and update nBufferCountActual if needed so we'll use less buffers than the worst case in such scenarios. SetParameter() needs to be called when the port is either disabled or the component in the Loaded state. Don't do this for the decoder output as gst_omx_video_dec_allocate_output_buffers() already check nBufferCountMin when computing the number of output buffers. On some platform, like rpi, the default nBufferCountActual is much higher than nBufferCountMin so only enable this using a specific gst-omx hack. https://bugzilla.gnome.org/show_bug.cgi?id=791211
* omxvidee{enc,dec}: refresh input port definition after setting formatGuillaume Desmottes2018-06-082-2/+8
| | | | | | | | | Setting the input format and the associated encoder/decoder settings may also affect the nBufferCountMin of the input port. Refresh the input port so we'll use up to date values in propose/decide allocation. https://bugzilla.gnome.org/show_bug.cgi?id=796445
View Lorry Controller Status