summaryrefslogtreecommitdiff
path: root/omx/gstomxvideodec.c
Commit message (Collapse)AuthorAgeFilesLines
* omxvideodec: fix dmabuf importGuillaume Desmottes2019-09-021-2/+12
| | | | | When importing dmabuf, UseBuffer() has to be called with the fd as pBuffer rather than the mapped address of the buffer.
* omxvideodec: log supported caps by the decoderGuillaume Desmottes2019-08-051-0/+3
| | | | | Can be useful when debugging to check the caps supported by the decoder before filtering.
* omxvideo: add debug infos to find_nearest_frame()Guillaume Desmottes2019-06-171-1/+1
| | | | | | Those debug infos have proved to be very helpful when debugging timestamp issues. They are often linked to gst-omx picking the wrong frame when trying to map from OMX.
* omxvideodec: Deactivate negotiated pool when output own bufferShinya Saito2019-06-071-0/+2
| | | | | If decoder outputs internal buffer and not use OMX_UseBuffer, downstream bufferpool should be stopped.
* omxvideodec: add debug if proposed pool can't provide enough buffersGuillaume Desmottes2019-03-261-0/+2
| | | | | We were silently ignoring the pool which was pretty confusing when debugging.
* omxvideo: use GST_VIDEO_CAPS_MAKE() for template capsGuillaume Desmottes2019-01-251-3/+1
| | | | | Simplify the code and so we advertise the formats actually supported by gst-omx.
* omxvideodec: Remove duplicated QoS codeNicolas Dufresne2019-01-251-10/+1
| | | | | The 'finish' function do the exact same check / drop, there is no need to duplicate this here.
* omxvideodec: Remove dead codeNicolas Dufresne2019-01-251-15/+0
| | | | | The omxvideodec base class have a totally unused prepare_frame() vritual function, remove it.
* omxbufferpool: fix early input buffer releaseGuillaume Desmottes2018-12-211-3/+0
| | | | | | | | | | | | | | | | | We used to track the 'allocating' status on the pool. It is used while allocating so output buffers aren't passed right away to OMX and input ones are not re-added to the pending queue. This was causing a bug when exporting buffers to v4l2src. On start v4l2src acquires a buffer, read its stride and release it right away. As no buffer was received by the encoder element at this point, 'allocating' was still on TRUE and so the the buffer wasn't put back to the pending queue and, as result, no longer available to the pool. Fix this by checking the active status of the pool instead of manually tracking it down. The pool is considered as active at the very end of the activation process so we're good when buffers are released during the activation.
* omxvideodec: Remove spurious unlock in error caseNicolas Dufresne2018-09-101-3/+1
| | | | | | | This was forgotton in previous patch. We no long hold the lock when goto invalid_buffer is called. https://bugzilla.gnome.org/show_bug.cgi?id=715192
* omxvideodec: don't hold the stream lock when trying to push a frameNicolas Dufresne2018-08-311-4/+2
| | | | | | | | | | The base class methods will lock this properly when needed, there seems to be no need to lock it explicitly. This allows the patch in gstvideodec for unlocking the stream lock when pushing buffers out to work. https://bugzilla.gnome.org/show_bug.cgi?id=715192
* omxvideodec: don't import OMX buffers from downstreamGuillaume Desmottes2018-08-301-4/+16
| | | | | | | | | | | | | | We already have code configuring the encoder stride and slice height when receiving the first buffer from upstream. We don't have an equivalent when the encoder is exporting its buffers to the decoder. There is no point adding it and making the code even more complex as we wouldn't gain anything by exporting from the encoder to the decoder. The dynamic buffer mode already ensures 0-copy between OMX components. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omx: allow gst_omx_port_acquire_buffer() to not wait for buffersGuillaume Desmottes2018-08-301-3/+3
| | | | | | Will be needed to implement GST_BUFFER_POOL_ACQUIRE_FLAG_DONTWAIT. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxvideodec: don't import non-dmabuf when dec is in dmabuf modeGuillaume Desmottes2018-08-301-0/+7
| | | | | | Fix 'omxh264dec ! videocrop' pipeline. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxvideodec: factor out gst_omx_try_importing_buffer()Guillaume Desmottes2018-08-301-22/+64
| | | | | | No semantic change, just make the code clearer and improve debug output. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxvideodec: fix gst_video_info_from_caps() caps assertionGuillaume Desmottes2018-08-301-0/+3
| | | | | | | The "use buffers" code path uses gst_video_info_from_caps() which is asserting if caps is NULL (because pool was rejected). https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxvideodec: fix pool caps reference stealingGuillaume Desmottes2018-08-301-1/+1
| | | | | | | gst_buffer_pool_config_get_params() doesn't ref the returning caps; so gst_caps_replace() was unreffing the reference owned by the pool. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxvideodec: prevent timeout when shutting down because of pending out buffersGuillaume Desmottes2018-08-301-2/+9
| | | | | | | | | | | The OMX transition state to Loaded won't be complete until all buffers have been freed. There is no point waiting, and timeout, if we know that output buffers haven't been freed yet. The typical scenario is output buffers being still used downstream and being freed later when released back to the pool. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* turn GstOMXComponent to a GstMiniObjectGuillaume Desmottes2018-08-301-2/+2
| | | | | | Will use it for refcounting. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxbufferpool: deallocate OMX buffers when stoppingGuillaume Desmottes2018-08-301-13/+16
| | | | | | | | The pool is stopped when all the buffers have been released. Deallocate when stopping so we are sure that the buffers aren't still used by another element. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxvideo{enc,dec}: stop calling shutdown() in change_stateGuillaume Desmottes2018-08-301-3/+0
| | | | | | | | | | | | | This is no longer needed since we implemented close() vfuncs as the encoder/decoder base class already take care of calling close() (which is calling shutdown()) in its own change_state implementation. We also move the shut down of the component from PAUSED_TO_READY to READY_TO_NULL. By doing so upstream will have already deactivated the pool from the encoder and so won't be preventing the OMX state change as the buffers will all be released. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omx: factor out gst_omx_port_set_dmabuf()Guillaume Desmottes2018-08-301-20/+2
| | | | | | No semantic change. I also made the debug message a bit clearer. https://bugzilla.gnome.org/show_bug.cgi?id=796918
* omxvideoenc: implement decide_allocationGuillaume Desmottes2018-06-081-1/+1
| | | | | | | | | Increase the number of output buffers by the number of buffers requested downstream. Prevent buffers starvation if downstream is going to use dynamic buffer mode on its input. https://bugzilla.gnome.org/show_bug.cgi?id=795746
* omxvideodec: implement propose_allocationGuillaume Desmottes2018-06-081-0/+22
| | | | | | | | | Tell upstream about how many buffer we plan to use so they can adjust their own number of buffers accordingly if needed. Same logic as the existing gst_omx_video_enc_propose_allocation(). https://bugzilla.gnome.org/show_bug.cgi?id=795746
* omxvideodec: always signal drain cond when stopping streaming loopGuillaume Desmottes2018-06-081-22/+8
| | | | | | | | | | | | If for some reason something goes wrong and we stop the streaming loop we may end up with other threads still waiting on the drain cond. No more buffers will be produced by the component so they were waiting forever. Fix this by always signalling this cond when stopping the streaming loop. https://bugzilla.gnome.org/show_bug.cgi?id=796207
* omxvideoenc: factor out gst_omx_video_enc_pause_loop()Guillaume Desmottes2018-06-081-17/+16
| | | | | | No semantic change. I'm going to use it in more failure cases. https://bugzilla.gnome.org/show_bug.cgi?id=796207
* omxvideodec/enc: add hack updating nBufferCountActual before allocatingGuillaume Desmottes2018-06-081-0/+23
| | | | | | | | | | | | | | | | | | | | | | | The OMX specs states that the nBufferCountActual of a port has to default to its nBufferCountMin. If we don't change nBufferCountActual we purely rely on this default. But in some cases, OMX may change nBufferCountMin before we allocate buffers. Like for example when configuring the input ports with the actual format, it may decrease the number of minimal buffers required. This method checks this and update nBufferCountActual if needed so we'll use less buffers than the worst case in such scenarios. SetParameter() needs to be called when the port is either disabled or the component in the Loaded state. Don't do this for the decoder output as gst_omx_video_dec_allocate_output_buffers() already check nBufferCountMin when computing the number of output buffers. On some platform, like rpi, the default nBufferCountActual is much higher than nBufferCountMin so only enable this using a specific gst-omx hack. https://bugzilla.gnome.org/show_bug.cgi?id=791211
* omxvidee{enc,dec}: refresh input port definition after setting formatGuillaume Desmottes2018-06-081-1/+4
| | | | | | | | | Setting the input format and the associated encoder/decoder settings may also affect the nBufferCountMin of the input port. Refresh the input port so we'll use up to date values in propose/decide allocation. https://bugzilla.gnome.org/show_bug.cgi?id=796445
* omxvideodec: pass a GstOMXBufferMode to gst_omx_buffer_pool_new()Guillaume Desmottes2018-05-041-1/+2
| | | | The output_mode is supposed to be a GstOMXBufferMode, not a boolean.
* omxvideoenc/dec: fix handling of component enabling failingGuillaume Desmottes2018-04-181-1/+16
| | | | | | | | | - Report the error from OMX if any (OMX_EventError) - If not report the failing to the application (GST_ELEMENT_ERROR) - return GST_FLOW_ERROR rather than FALSE - don't leak @frame https://bugzilla.gnome.org/show_bug.cgi?id=795352
* omxvideodec: Don't drop the frame on empty payloadNicolas Dufresne2018-03-051-1/+3
| | | | This otherwise may lead to "No reference frame found" warning.
* omxvideodec: Fix CodecState leakNicolas Dufresne2018-03-051-0/+1
|
* add support for NV12_10LE32 and NV16_10LE32 on zynqultrascaleplusGuillaume Desmottes2018-02-281-0/+16
| | | | | | | The encoder and decoder on zynqultrascaleplus support these new 10 bits format. https://bugzilla.gnome.org/show_bug.cgi?id=793694
* omxvideodec: add internal-entropy-buffers property on zynqultrascaleplusGuillaume Desmottes2018-01-301-1/+106
| | | | | | | Custom property to control the number of internal buffers used in the decoder to smooth out entropy decoding performance. https://bugzilla.gnome.org/show_bug.cgi?id=792528
* omxvideodec: add hack to pass color format from caps to OMX decoderGuillaume Desmottes2018-01-301-0/+80
| | | | | | | | | | | This hack tries to pass as much information as possible from caps to the decoder before it receives any buffer. These information can be used by the OMX decoder to, for example, pre-allocate its internal buffers before starting to decode and so reduce its initial latency. This mechanism is currently supported by the zynqultrascaleplus decoder. https://bugzilla.gnome.org/show_bug.cgi?id=792040
* omxvideodec: ignore very little variations of the framerateJulien Isorce2017-12-141-1/+2
| | | | | | | | | | | | | If less than 1%. The dynamic format change should not happen when the resolution does not change and when only the framerate changes but very slightly, i.e. from 50000/1677=29.81 to 89/3=29.66 so a "percentage change" of less than 1% (i.e. 100*(29.81-29.66)/29.66 = 0.50 < 1 ). In that case just ignore it to avoid unnecessary renegotiation. https://bugzilla.gnome.org/show_bug.cgi?id=759043
* omxvideodec: use dynamic buffer mode on input if possibleGuillaume Desmottes2017-12-141-25/+153
| | | | | | | | Prevent from copying the input buffers between GStreamer and OMX. Tested on zynqultrascaleplus and rpi (without dynamic buffers). https://bugzilla.gnome.org/show_bug.cgi?id=787093
* omxvideoenc/dec: factor out input buffer allocationGuillaume Desmottes2017-12-141-5/+13
| | | | | | | No semantic change so far. I'm going to add an alternate way to allocate input buffers. https://bugzilla.gnome.org/show_bug.cgi?id=787093
* omxvideodec: consolidate the decision to try UseBufferJulien Isorce2017-12-131-3/+8
| | | | | | | | The tee element can call gst_query_add_allocation_pool with pool as NULL. Checking nth > 0 is not enough so we need to verify if there is a pool. https://bugzilla.gnome.org/show_bug.cgi?id=730758 https://bugzilla.gnome.org/show_bug.cgi?id=784069
* gstomxvideodec: fix framerate overflowJulien Isorce2017-12-131-6/+3
| | | | | | | | | Some live streams can set the framerate to 50000/1677 (=29.81). GstVideoInfo.fps_n << 16 is wrong if the fps_n is 50000 (i.e. greater than 32767). https://bugzilla.gnome.org/show_bug.cgi?id=759043
* omxvideodec: retrieve OMX_IndexParamVideoPortFormat before setting itGuillaume Desmottes2017-11-291-0/+8
| | | | | | | | | | The usual pattern when setting OMX params is to first get the struct param, override the values we want to set and then set the updated param. We were not doing this with OMX_IndexParamVideoPortFormat and so were resetting some fields such as OMX_VIDEO_PARAM_PORTFORMATTYPE.xFramerate https://bugzilla.gnome.org/show_bug.cgi?id=790979
* omxvideodec: remove redundant debug messageGuillaume Desmottes2017-10-191-2/+0
| | | | | | We have already a debug message right after. https://bugzilla.gnome.org/show_bug.cgi?id=789058
* add gst_omx_buffer_flags_to_string()Guillaume Desmottes2017-10-111-1/+2
| | | | | | | Make debug logs more readable so users don't have to manually figure out the meaning of flags. https://bugzilla.gnome.org/show_bug.cgi?id=788767
* omxvideodec: log info about frame before releasing itGuillaume Desmottes2017-09-141-2/+2
| | | | | | | gst_video_decoder_release_frame() takes ownership of the frame and will destroy it. So we should no longer use it after calling it. https://bugzilla.gnome.org/show_bug.cgi?id=787628
* omxvideodec: EGLDisplay is not indirectly defined by gstgl headers inclusionJulien Isorce2017-08-221-1/+1
| | | | | | | Just use gpointer as done in GstGL to not include EGL/egl.h just for EGLDisplay. https://bugzilla.gnome.org/show_bug.cgi?id=784779
* omxvideodec: remove wrong SettingsChanged ackJulien Isorce2017-08-171-13/+1
| | | | | | | | | | Partially revert 1b7d0b8: omxvideodec: handle IL 1.2 behavior for OMX_SetParameter It turned out it was a problem in the decoder which was not updating some local variables upon SetParameter. https://bugzilla.gnome.org/show_bug.cgi?id=783976
* omx{audio,video}{dec,enc}: sequentially disable ports because buffers are ↵Julien Isorce2017-08-171-7/+18
| | | | | | | | | | | | | | | | | | | | | | | not shared For the history, the parallel disable port has been introduced by: "00be69f omxvideodec: Disable output port when setting a new format" and then replicated to videoenc, audiodec and audioenc. This is only required to do 'parallel' if buffers are shared between ports. But for decoders and encoders the input and output buffer are of different nature by definition (bitstream vs images). So they cannot be shared. Also starting from IL 1.2.0 it is written in the spec that the parallel disable is not allowed and will return an error. Except when buffers are shared. Again here we know in advance that they are not shared so let's always do a sequential disable. Tested on Desktop, rpi and zynqultrascaleplus. https://bugzilla.gnome.org/show_bug.cgi?id=786348
* omxvideodec: use the decoder API to set latencyGuillaume Desmottes2017-08-101-1/+1
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=785125
* omxvideoenc/dec: declare latency on zynqultrascaleplusGuillaume Desmottes2017-08-091-0/+33
| | | | | | | | | The OMX specification doesn't provide any API to expose the latency introduced by encoders and decoders. We implemented this as a custom extension as declaring the latency is needed for live pipelines like video conferencing. https://bugzilla.gnome.org/show_bug.cgi?id=785125
* omxvideodec/enc: delay allocation after the allocation queryGuillaume Desmottes2017-08-081-3/+6
| | | | | | | | | | | | Allocating OMX components buffers in set_format() is too early. Doing it when receiving the first buffers will allow the element to use the information from the allocation query and/or the first incoming buffer to pick to best allocation mode. Tested on raspberry pi with dynamic resolution changes on decoder and encoder input. https://bugzilla.gnome.org/show_bug.cgi?id=785967
View Lorry Controller Status