| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Move the profile <-> enum mapping to one place. Make changes easier as
I'm about to add extra profiles.
No semantic change.
https://bugzilla.gnome.org/show_bug.cgi?id=794177
|
|
|
|
|
|
|
| |
The zynqultrascaleplus OMX gained support for more format range
extensions profiles (A.3.5).
https://bugzilla.gnome.org/show_bug.cgi?id=794177
|
|
|
|
|
|
|
|
|
| |
Move the profile <-> enum mapping to one place. Make changes easier as
I'm about to add some profiles.
No semantic change.
https://bugzilla.gnome.org/show_bug.cgi?id=794177
|
|
|
|
|
|
|
| |
NV16 format wasn't supported on encoder input while it was on decoder
output.
https://bugzilla.gnome.org/show_bug.cgi?id=794175
|
|
|
|
|
|
| |
More convenient when debugging.
https://bugzilla.gnome.org/show_bug.cgi?id=794175
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
0xffffffff is the magic number in gst-omx meaning 'the default value
defined in OMX'. This works fine with OMX parameters which are only set
once when starting the component but not with configs which can be
changed while PLAYING.
Save the actual OMX default bitrate so we can restore it later if user
sets back 0xffffffff on the property.
Added GST_OMX_PROP_OMX_DEFAULT so we stop hardcoding magic numbers
everywhere.
https://bugzilla.gnome.org/show_bug.cgi?id=794998
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
set_format
We weren't using the usual pattern when re-setting the bitrate:
- get parameters from OMX
- update only the fields different from 0xffffffff (OMX defaults)
- set parameters
Also added a comment explaining why we re-set this param.
https://bugzilla.gnome.org/show_bug.cgi?id=794998
|
|
|
|
|
|
| |
No semantic change, I'm about to re-use this function in set_format().
https://bugzilla.gnome.org/show_bug.cgi?id=794998
|
|
|
|
|
|
|
|
|
| |
- Report the error from OMX if any (OMX_EventError)
- If not report the failing to the application (GST_ELEMENT_ERROR)
- return GST_FLOW_ERROR rather than FALSE
- don't leak @frame
https://bugzilla.gnome.org/show_bug.cgi?id=795352
|
|
|
|
|
|
| |
G_TYPE_POINTER are not serialized in logs.
https://bugzilla.gnome.org/show_bug.cgi?id=794331
|
|
|
|
|
|
|
|
|
|
|
| |
We already have the exact same message at the beginning of
gst_omx_video_enc_handle_frame(). Having it twice is confusing when
reading/grepping logs.
I kept the earlier one to keep the symetry with
gst_omx_video_dec_handle_frame().
https://bugzilla.gnome.org/show_bug.cgi?id=794897
|
|
|
|
|
|
| |
New QP mode used to handle ROI metadata.
https://bugzilla.gnome.org/show_bug.cgi?id=793696
|
|
|
|
|
|
|
|
| |
h265parse is gaining support for the format range extension profile
(bgo#793876).
Use the profile names defined in h265parse.
https://bugzilla.gnome.org/show_bug.cgi?id=793928
|
|
|
|
| |
This otherwise may lead to "No reference frame found" warning.
|
|
|
|
| |
This otherwise may lead to "No reference frame found" warning.
|
|
|
|
|
| |
To indicate we are doing dynamic buffers importation, we pass
a list of NULL pointers, but we forgot to free that list.
|
| |
|
|
|
|
| |
This reverts commit 4211e4c29a262f110cb92ddf9c06b403ced233ef.
|
|
|
|
|
|
| |
Padding can be left undefined there is no point filling it with 0.
https://bugzilla.gnome.org/show_bug.cgi?id=793694
|
|
|
|
|
|
|
| |
The encoder and decoder on zynqultrascaleplus support these new 10 bits
format.
https://bugzilla.gnome.org/show_bug.cgi?id=793694
|
|
|
|
|
|
|
| |
No semantic change, I'm going to re-use it to copy the NV12_10LE32
format.
https://bugzilla.gnome.org/show_bug.cgi?id=793694
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=793694
|
|
|
|
|
|
|
|
|
| |
Check input buffers for ROI meta and pass them to the encoder by using
zynqultrascaleplus's custom OMX extension. Also add a new
"default-roi-quality" in order to tell the encoder what quality level
should be applied to ROI by default.
https://bugzilla.gnome.org/show_bug.cgi?id=793696
|
|
|
|
|
|
| |
This property isn't actually mutable in the PLAYING state.
https://bugzilla.gnome.org/show_bug.cgi?id=793458
|
|
|
|
|
|
|
|
| |
The 'target-bitrate' property can be changed while PLAYING
(GST_PARAM_MUTABLE_PLAYING). Make it thread-safe to prevent concurrent
accesses between the application and streaming thread.
https://bugzilla.gnome.org/show_bug.cgi?id=793458
|
|
|
|
|
|
|
|
|
|
| |
I spent quiet some time figuring out why performance of my pipeline were
terrible. Turned out it was because of output frames being copied
because of stride/offset mismatch.
Add a PERFORMANCE DEBUG message to make it easier to spot and debug from logs.
https://bugzilla.gnome.org/show_bug.cgi?id=793637
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix the 'nick' of the property.
omxh265enc is based on the code from omxh264enc and suffers the same
typo as we fixed in https://bugzilla.gnome.org/show_bug.cgi?id=784370
This element isn't part of a stable release yet so it's not an API
break.
https://bugzilla.gnome.org/show_bug.cgi?id=793390
|
|
|
|
|
|
|
|
| |
The OMX specs defines 8 headers that implementations can use to define
their custom extensions. We were checking and including 3 and ignoring
the other ones.
https://bugzilla.gnome.org/show_bug.cgi?id=792043
|
|
|
|
|
|
|
| |
We are now always checking which files are present or not, even when using our
internal copy of OMX, rather than hardcoding the ones present in it.
https://bugzilla.gnome.org/show_bug.cgi?id=792043
|
|
|
|
| |
This reverts commit 9d37a92a615e54e8ee12f8c65bcfe386ec9de2d0.
|
|
|
|
|
|
|
| |
constrained-intra-prediction and loop-filter-mode.
Those map standard OMX settings.
https://bugzilla.gnome.org/show_bug.cgi?id=792528
|
|
|
|
|
|
|
| |
entropy-mode, constrained-intra-prediction and loop-filter-mode.
Those map standard OMX settings.
https://bugzilla.gnome.org/show_bug.cgi?id=792528
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=792528
|
|
|
|
|
|
|
| |
nTargetBitrate and nEncodeBitrate are defined in bits per second in the
OMX spec.
https://bugzilla.gnome.org/show_bug.cgi?id=792528
|
|
|
|
|
|
|
| |
Custom property to control the number of internal buffers used in the
decoder to smooth out entropy decoding performance.
https://bugzilla.gnome.org/show_bug.cgi?id=792528
|
|
|
|
|
|
|
|
|
|
|
| |
It seems cleaner to use the proper meson tools to include this path
rather than manually tweak the build flags.
This also allows us to simplify the OMX extensions detection code. We
are now always checking which files are present, even when using our
internal copy of OMX, rather than hardcoding the ones present in it.
https://bugzilla.gnome.org/show_bug.cgi?id=792043
|
|
|
|
|
|
|
| |
As we added in the parser (bgo#792039) expose the chroma and bit
depth information in output caps.
https://bugzilla.gnome.org/show_bug.cgi?id=792040
|
|
|
|
|
|
| |
No semantic change so far.
https://bugzilla.gnome.org/show_bug.cgi?id=792040
|
|
|
|
|
|
|
|
|
|
|
| |
This hack tries to pass as much information as possible from caps to the
decoder before it receives any buffer. These information can be used by
the OMX decoder to, for example, pre-allocate its internal buffers
before starting to decode and so reduce its initial latency.
This mechanism is currently supported by the zynqultrascaleplus decoder.
https://bugzilla.gnome.org/show_bug.cgi?id=792040
|
|
|
|
|
|
|
|
|
| |
I find it confusing when debugging that OMX calls returning an error
where not logged as GST_LEVEL_ERROR making them harder to spot.
Fix this by introducing simple log macros checking the return value of
the OMX call and logging failures as errors.
https://bugzilla.gnome.org/show_bug.cgi?id=791069
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Can be used to log buffers exchange between OMX and gst-omx to profile
performances of the OMX component.
Ideally this should be done using tracer hooks but it's currently not
possible to define custom hooks outside of core.
Use GST_DEBUG="OMX_PERFORMANCE:8" to enable it.
See also
https://github.com/gdesmott/gst-log-parser/blob/master/src/bin/omx-perf.rs
as a simple program consuming those logs to generate gnuplot files and
stats.
https://bugzilla.gnome.org/show_bug.cgi?id=791093
|
|
|
|
|
|
|
|
|
|
| |
The Zynq UltraScale+ encoder implements a custom OMX extension to
directly import dmabuf saving the need of mapping input buffers.
This can be use with either 'v4l2src io-mode=dmabuf' or an OMX video
decoder upstream.
https://bugzilla.gnome.org/show_bug.cgi?id=792361
|
|
|
|
|
|
|
|
| |
Make use of the new GstVideoEncoder QoS API to drop late input frames. This may
help a live pipeline to catch up if it's being late and all frames end up
being dropped at the sink.
https://bugzilla.gnome.org/show_bug.cgi?id=792783
|
|
|
|
|
|
|
|
|
|
|
|
| |
If something goes wrong while trying to manually copy the input buffer,
the 'break' was moving us out of the 'for' loop but not out of the switch block.
So we ended up calling gst_video_frame_unmap() a second time (raising
assertions) and returning TRUE rather than FALSE.
Reproduced with a WIP zynqultrascaleplus OMX branch reporting wrong
buffer sizes and so triggering this bug.
https://bugzilla.gnome.org/show_bug.cgi?id=792167
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If less than 1%.
The dynamic format change should not happen when the
resolution does not change and when only the framerate
changes but very slightly, i.e. from 50000/1677=29.81
to 89/3=29.66 so a "percentage change" of less than 1%
(i.e. 100*(29.81-29.66)/29.66 = 0.50 < 1 ). In that case
just ignore it to avoid unnecessary renegotiation.
https://bugzilla.gnome.org/show_bug.cgi?id=759043
|
|
|
|
|
|
|
|
| |
Prevent from copying the input buffers between GStreamer and OMX.
Tested on zynqultrascaleplus and rpi (without dynamic buffers).
https://bugzilla.gnome.org/show_bug.cgi?id=787093
|
|
|
|
|
|
|
|
|
|
| |
If the OMX component supports dynamic buffer mode and the input buffers
are properly aligned avoid copying each input frame between OMX and
GStreamer.
Tested on zynqultrascaleplus and rpi (without dynamic buffers).
https://bugzilla.gnome.org/show_bug.cgi?id=787093
|
|
|
|
|
|
|
| |
No semantic change so far. I'm going to add an alternate way to allocate
input buffers.
https://bugzilla.gnome.org/show_bug.cgi?id=787093
|
|
|
|
|
|
|
|
|
|
|
|
| |
OMX 1.2.0 introduced a third way to manage buffers by allowing
components to only allocate buffers header during their initialization
and change their pBuffer pointer at runtime.
This new feature can save us a copy between GStreamer and OMX for each
input buffer.
This patch adds API to allocate and use such buffers.
https://bugzilla.gnome.org/show_bug.cgi?id=787093
|
|
|
|
|
|
|
|
| |
The tee element can call gst_query_add_allocation_pool with pool as NULL.
Checking nth > 0 is not enough so we need to verify if there is a pool.
https://bugzilla.gnome.org/show_bug.cgi?id=730758
https://bugzilla.gnome.org/show_bug.cgi?id=784069
|