summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorReynaldo H. Verdejo Pinochet <reynaldo@collabora.com>2012-10-02 01:43:35 -0300
committerSebastian Dröge <sebastian.droege@collabora.co.uk>2012-10-18 14:35:16 +0200
commita818d5c77164384dd8cd3c1133ae76051e475157 (patch)
tree9cbeef6e7aab79ca84810bbe9a836e56a0df57cc
parent162f63e064889ab320153df595851d57917c4090 (diff)
downloadgstreamer-plugins-bad-a818d5c77164384dd8cd3c1133ae76051e475157.tar.gz
eglglessink: Do not update_surface_dims() once per frame
And.. Upgrade debug message to warging on weird DAR. Correct fix to avoid spaming with this message once per each frame is avoid calling update_surface_dims() at render_and_display(). This is handled at egl surface init.
-rw-r--r--ext/eglgles/gsteglglessink.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/ext/eglgles/gsteglglessink.c b/ext/eglgles/gsteglglessink.c
index 061c99e1c..efffc25e3 100644
--- a/ext/eglgles/gsteglglessink.c
+++ b/ext/eglgles/gsteglglessink.c
@@ -1404,7 +1404,7 @@ gst_eglglessink_update_surface_dimensions (GstEglGlesSink * eglglessink)
}
if (eglglessink->eglglesctx->pixel_aspect_ratio == EGL_UNKNOWN) {
- GST_DEBUG_OBJECT (eglglessink, "PAR value returned doesn't make sense. "
+ GST_WARNING_OBJECT (eglglessink, "PAR value returned doesn't make sense. "
"Will use default: %d/%d", EGL_DISPLAY_SCALING, EGL_DISPLAY_SCALING);
eglglessink->eglglesctx->pixel_aspect_ratio = EGL_DISPLAY_SCALING;
}
@@ -2039,8 +2039,7 @@ gst_eglglessink_render_and_display (GstEglGlesSink * eglglessink,
* do this trying to take PAR/DAR into account unless the
* calling party explicitly ask us not to.
*/
- if (gst_eglglessink_update_surface_dimensions (eglglessink) ||
- !eglglessink->display_region.w || !eglglessink->display_region.h) {
+ if (!eglglessink->display_region.w || !eglglessink->display_region.h) {
g_mutex_lock (eglglessink->flow_lock);
if (!eglglessink->force_aspect_ratio) {
eglglessink->display_region.x = 0;