diff options
| author | Víctor Manuel Jáquez Leal <vjaquez@igalia.com> | 2018-01-29 12:50:36 +0100 |
|---|---|---|
| committer | Víctor Manuel Jáquez Leal <vjaquez@igalia.com> | 2018-01-31 14:18:20 +0100 |
| commit | 198b3703e295ae415b5853c563a143ae805ef86c (patch) | |
| tree | fc0afada2d17d3199c9dd1785718cf69e0413e48 | |
| parent | 14a839aa29e0a16649ab81d739c4d8ef606b5d1e (diff) | |
| download | gstreamer-plugins-bad-198b3703e295ae415b5853c563a143ae805ef86c.tar.gz | |
gdpdepay: don't allocation query if caps aren't fixed
When querying downstream for allocation, and the source caps hasn't
set its caps, using ANY by default, it raises a critical message in
console:
CRITICAL **: gst_video_info_from_caps: assertion 'gst_caps_is_fixed (caps)' failed
This patch bails out decide_allocation() if the caps aren't fixed.
https://bugzilla.gnome.org/show_bug.cgi?id=789476
| -rw-r--r-- | gst/gdp/gstgdpdepay.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/gst/gdp/gstgdpdepay.c b/gst/gdp/gstgdpdepay.c index 4d2093870..750571e6f 100644 --- a/gst/gdp/gstgdpdepay.c +++ b/gst/gdp/gstgdpdepay.c @@ -560,6 +560,11 @@ gst_gdp_depay_decide_allocation (GstGDPDepay * gdpdepay) return; } + if (!gst_caps_is_fixed (caps)) { + GST_LOG_OBJECT (gdpdepay, "Caps on src pad are not fixed. Not querying."); + return; + } + query = gst_query_new_allocation (caps, TRUE); if (!gst_pad_peer_query (gdpdepay->srcpad, query)) { GST_WARNING_OBJECT (gdpdepay, "Peer allocation query failed."); |