summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhilippe Normand <philn@igalia.com>2017-12-27 13:08:18 +0000
committerPhilippe Normand <philn@igalia.com>2017-12-27 15:50:04 +0000
commit46897797c2ab835ca525e098f3d48db2f8a475d4 (patch)
tree2ba65db1d20f120f09edeb0a0d91cc281914b933
parentbe5b414e3455d643bf0c6d2139ae693f66393be7 (diff)
downloadgstreamer-plugins-bad-46897797c2ab835ca525e098f3d48db2f8a475d4.tar.gz
player: transfer ownership of info properties
The previous code would emit GObject critical warnings when the info properties are NULL. https://bugzilla.gnome.org/show_bug.cgi?id=791982
-rw-r--r--gst-libs/gst/player/gstplayer.c12
1 files changed, 4 insertions, 8 deletions
diff --git a/gst-libs/gst/player/gstplayer.c b/gst-libs/gst/player/gstplayer.c
index 6ee202352..d0d9f26bf 100644
--- a/gst-libs/gst/player/gstplayer.c
+++ b/gst-libs/gst/player/gstplayer.c
@@ -773,29 +773,25 @@ gst_player_get_property (GObject * object, guint prop_id,
}
case PROP_MEDIA_INFO:{
GstPlayerMediaInfo *media_info = gst_player_get_media_info (self);
- g_value_set_object (value, media_info);
- g_object_unref (media_info);
+ g_value_take_object (value, media_info);
break;
}
case PROP_CURRENT_AUDIO_TRACK:{
GstPlayerAudioInfo *audio_info =
gst_player_get_current_audio_track (self);
- g_value_set_object (value, audio_info);
- g_object_unref (audio_info);
+ g_value_take_object (value, audio_info);
break;
}
case PROP_CURRENT_VIDEO_TRACK:{
GstPlayerVideoInfo *video_info =
gst_player_get_current_video_track (self);
- g_value_set_object (value, video_info);
- g_object_unref (video_info);
+ g_value_take_object (value, video_info);
break;
}
case PROP_CURRENT_SUBTITLE_TRACK:{
GstPlayerSubtitleInfo *subtitle_info =
gst_player_get_current_subtitle_track (self);
- g_value_set_object (value, subtitle_info);
- g_object_unref (subtitle_info);
+ g_value_take_object (value, subtitle_info);
break;
}
case PROP_VOLUME: