summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChris Bass <floobleflam@gmail.com>2017-04-19 14:07:06 +0100
committerSebastian Dröge <sebastian@centricular.com>2017-04-19 18:28:31 +0100
commit98ce1e11bc3da9d3b383a224e28a7a9b61ca7ad5 (patch)
treefcf8ddfb64f1330b2ce5e22c00f7aa650c1f4578
parent3fbd12b14140a5ee8e9aa8dcae47174525a5bf5b (diff)
downloadgstreamer-plugins-bad-98ce1e11bc3da9d3b383a224e28a7a9b61ca7ad5.tar.gz
ttmlparse: Fix potential NULL dereference identified by coverity
Hopefully fixes CID #1405131.
-rw-r--r--ext/ttml/ttmlparse.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/ext/ttml/ttmlparse.c b/ext/ttml/ttmlparse.c
index 016523cb1..cb54fc363 100644
--- a/ext/ttml/ttmlparse.c
+++ b/ext/ttml/ttmlparse.c
@@ -734,9 +734,9 @@ ttml_style_set_inherit (TtmlStyleSet * parent, TtmlStyleSet * child)
* fontSize based on the parent's fontSize; otherwise, we simply keep
* the value defined in the child's style set. */
if (g_strcmp0 ((const gchar *) attr_name, "fontSize") == 0
- && ttml_style_set_contains_attr (ret, (const gchar *) attr_name)) {
+ && ttml_style_set_contains_attr (ret, "fontSize")) {
const gchar *original_child_font_size =
- ttml_style_set_get_attr (child, "fontSize");
+ ttml_style_set_get_attr (ret, "fontSize");
gchar *scaled_child_font_size =
ttml_get_relative_font_size ((const gchar *) attr_value,
original_child_font_size);