diff options
| author | Naveen Cherukuri <naveen.cherukuri@xilinx.com> | 2018-12-04 16:15:22 +0530 |
|---|---|---|
| committer | Tim-Philipp Müller <tim@centricular.com> | 2019-05-02 09:51:37 +0100 |
| commit | 78f35b40ef969c85ecc57ce5a38ba4f7d9acaaf1 (patch) | |
| tree | 0040e6ebdbebe63997c04a502ffae94c4e080f25 | |
| parent | 668cdf8c4694437fc1ebb3d4b4d9e8178d7567a8 (diff) | |
| download | gstreamer-plugins-bad-78f35b40ef969c85ecc57ce5a38ba4f7d9acaaf1.tar.gz | |
kmssink: Avoiding get_property to take ownership of object members
Double free will happen if application frees string retuned by _get_property
| -rw-r--r-- | sys/kms/gstkmssink.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sys/kms/gstkmssink.c b/sys/kms/gstkmssink.c index 1331883ce..2cf08f570 100644 --- a/sys/kms/gstkmssink.c +++ b/sys/kms/gstkmssink.c @@ -1626,10 +1626,10 @@ gst_kms_sink_get_property (GObject * object, guint prop_id, switch (prop_id) { case PROP_DRIVER_NAME: - g_value_take_string (value, sink->devname); + g_value_set_string (value, sink->devname); break; case PROP_BUS_ID: - g_value_take_string (value, sink->bus_id); + g_value_set_string (value, sink->bus_id); break; case PROP_CONNECTOR_ID: g_value_set_int (value, sink->conn_id); |