summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHaihao Xiang <haihao.xiang@intel.com>2019-01-09 08:58:00 +0800
committerTim-Philipp Müller <tim@centricular.com>2019-05-02 11:57:01 +0100
commit935b3db951c62b442ae4812e618f04ee95dfa19e (patch)
tree66df808b1b7dd6e9dbe57155a0183693332107a2
parent6d35510a3666e6de697412c6334a65583fea4ffc (diff)
downloadgstreamer-plugins-bad-935b3db951c62b442ae4812e618f04ee95dfa19e.tar.gz
msdk: release resources if failing to create the buffer pool
Needn't check the pointers against NULL because the pointers are non-NULL
-rw-r--r--sys/msdk/gstmsdkdec.c3
-rw-r--r--sys/msdk/gstmsdkenc.c3
2 files changed, 6 insertions, 0 deletions
diff --git a/sys/msdk/gstmsdkdec.c b/sys/msdk/gstmsdkdec.c
index 62c59a6b9..db329835c 100644
--- a/sys/msdk/gstmsdkdec.c
+++ b/sys/msdk/gstmsdkdec.c
@@ -757,11 +757,14 @@ error_no_pool:
error_no_allocator:
{
GST_INFO_OBJECT (thiz, "failed to create allocator");
+ gst_object_unref (pool);
return NULL;
}
error_pool_config:
{
GST_INFO_OBJECT (thiz, "failed to set config");
+ gst_object_unref (pool);
+ gst_object_unref (allocator);
return NULL;
}
}
diff --git a/sys/msdk/gstmsdkenc.c b/sys/msdk/gstmsdkenc.c
index 28ccc72db..7eabd46d2 100644
--- a/sys/msdk/gstmsdkenc.c
+++ b/sys/msdk/gstmsdkenc.c
@@ -918,11 +918,14 @@ error_no_pool:
error_no_allocator:
{
GST_INFO_OBJECT (thiz, "failed to create allocator");
+ gst_object_unref (pool);
return FALSE;
}
error_pool_config:
{
GST_INFO_OBJECT (thiz, "failed to set config");
+ gst_object_unref (pool);
+ gst_object_unref (allocator);
return FALSE;
}
}