diff options
author | Tim-Philipp Müller <tim@centricular.com> | 2018-02-21 19:45:33 +0000 |
---|---|---|
committer | Tim-Philipp Müller <tim@centricular.com> | 2018-02-21 19:46:04 +0000 |
commit | 9af73aa1d1536a99d682519e930490a145b263ba (patch) | |
tree | 16d99ee963b3be53fee2625ee77abe526d517027 | |
parent | a73e5eba55d5b18eb0da14328fa7b0a456d8c84b (diff) | |
download | gstreamer-plugins-bad-9af73aa1d1536a99d682519e930490a145b263ba.tar.gz |
meson: simplify GST_DISABLE_GST_DEBUG check and don't use add_global_*
add_global_arguments() can't be used in subprojects. It's
entirely possible that -bad is a subproject but gstreamer
is picked up from an installed location, so we should
really use add_project_arguments() in both cases.
-rw-r--r-- | meson.build | 28 |
1 files changed, 8 insertions, 20 deletions
diff --git a/meson.build b/meson.build index 1d355c050..b6c00442f 100644 --- a/meson.build +++ b/meson.build @@ -425,27 +425,15 @@ else endif if gst_dep.type_name() == 'internal' - gst_proj = subproject('gstreamer') - - if gst_proj.get_variable('disable_gst_debug') - message('GStreamer debug system is disabled') - add_project_arguments('-Wno-unused', language: 'c') - else - message('GStreamer debug system is enabled') - endif + gst_debug_disabled = subproject('gstreamer').get_variable('disable_gst_debug') else - # We can't check that in the case of subprojects as we won't - # be able to build against an internal dependency (which is not built yet) - if not cc.compiles(''' -#include <gst/gstconfig.h> -#ifdef GST_DISABLE_GST_DEBUG -#error "debugging disabled, make compiler fail" -#endif''' , dependencies: gst_dep) - message('GStreamer debug system is disabled') - add_global_arguments('-Wno-unused', language: 'c') - else - message('GStreamer debug system is enabled') - endif + # We can't check that in the case of subprojects as we won't + # be able to build against an internal dependency (which is not built yet) + gst_debug_disabled = cc.has_header_symbol('gst/gstconfig.h', 'GST_DISABLE_GST_DEBUG', dependencies: gst_dep) +endif + +if gst_debug_disabled and cc.has_argument('-Wno-unused') + add_project_arguments('-Wno-unused', language: 'c') endif gst_plugins_bad_args = ['-DHAVE_CONFIG_H'] |