diff options
author | Tim-Philipp Müller <tim@centricular.com> | 2019-03-07 00:02:13 +0000 |
---|---|---|
committer | Tim-Philipp Müller <tim@centricular.com> | 2019-03-08 01:18:39 +0000 |
commit | 679fa2d200f9e57704afa7cc4fc067bd20453aba (patch) | |
tree | 8709b6cddeb8395885b33274384270d30db4f581 | |
parent | 92e5c5a85ae39d23704afa52ab8795f2dc125a7b (diff) | |
download | gstreamer-plugins-bad-679fa2d200f9e57704afa7cc4fc067bd20453aba.tar.gz |
srt: fix uri and string leaks
And simplify property getter to avoid unnecessary copy.
-rw-r--r-- | ext/srt/gstsrtobject.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/ext/srt/gstsrtobject.c b/ext/srt/gstsrtobject.c index f60a56be5..1237cc24b 100644 --- a/ext/srt/gstsrtobject.c +++ b/ext/srt/gstsrtobject.c @@ -217,6 +217,8 @@ gst_srt_object_destroy (GstSRTObject * srtobject) GST_DEBUG_OBJECT (srtobject->element, "Cleaning up SRT"); } + g_clear_pointer (&srtobject->uri, gst_uri_unref); + g_free (srtobject); } @@ -226,9 +228,8 @@ gst_srt_object_set_property_helper (GstSRTObject * srtobject, { switch (prop_id) { case PROP_URI:{ - gchar *uri = g_value_dup_string (value); + const gchar *uri = g_value_get_string (value); gst_srt_object_set_uri (srtobject, uri, NULL); - g_free (uri); break; } case PROP_MODE: @@ -268,7 +269,7 @@ gst_srt_object_get_property_helper (GstSRTObject * srtobject, { switch (prop_id) { case PROP_URI: - g_value_set_string (value, gst_uri_to_string (srtobject->uri)); + g_value_take_string (value, gst_uri_to_string (srtobject->uri)); break; case PROP_MODE:{ GstSRTConnectionMode v; |